Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4131704rwd; Tue, 30 May 2023 00:32:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7N6oxg72u3VVCpj5MzvIyAjHWR+m5se7GUWiNDJvqXXmaAIOlAd8RcSyBJloQGRraSu56p X-Received: by 2002:a05:6a20:12cc:b0:104:7454:d858 with SMTP id v12-20020a056a2012cc00b001047454d858mr11454403pzg.19.1685431978375; Tue, 30 May 2023 00:32:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685431978; cv=none; d=google.com; s=arc-20160816; b=qArXIgCKFuUIHcnry7FKuWfNqTfJMHBfhUh40SH6hwK6Tp4JVS47DC8/xBTFz+rEI4 TxesVKovYzvzUT7vPsrTcyyY9QMKgXF8aHsfgdAjTsBllEIEFMshu2/TGMkohyYnsjny aTdgbX3iIyIkA//zgdz2A/Hw2PRyiAfq1rVd4pEHDw3ctKlfa4WrSsbz3IF+6CZ1xE7K iuYThUvnEvFqywd5FxyniGF0yPPTCIbMIhld1UNuxZg9r3EBx0UeJ163YAdU4gnKzRYh FnisVxCWgdqnXJcxI105TrdlkuTJ0KVJohVDVRWEfg0oXEZgUlUD9vMBz0cvwRudQial 1qag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:subject:cc:to:from:message-id :date:dkim-signature; bh=U7It4Z8HnsJ07P1Nui/0XhRU5YCscVY5uMfO0X+y8lc=; b=F8TxR/E8qzm4HC606zwtX8irvHfBqEd2LNKZo+920tceCwc/lTM3tn+NuqAR3JF9W7 sVnPuthTzaNyJA1ZUJqqf5GkcIim7u3MDf64XXhnPI1uuBsLAzcwATSItCz54FyE5byM rQvzokFZJ9qIbZEXKj7kC1AA+L2b4mAYPhp4l0YIrIpjdu/YfG5Loo6IPC3na4MDt3q4 1ArB10MiRsl5TlvwBJJVW+QFF1mgbJlkd25RVIm2Jbr499BKuWLWRepR477szEIxaedh 4QA5SuTnpcPAZ8bpfyBOMOmFQWe4QpPYD6O81Al679mv4JtNfqVqiOSxvhOYwn2ky4de 7nEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KRBDqNd3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j24-20020a637a58000000b005340840c0c0si9838815pgn.11.2023.05.30.00.32.46; Tue, 30 May 2023 00:32:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KRBDqNd3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230460AbjE3HQM (ORCPT + 99 others); Tue, 30 May 2023 03:16:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230459AbjE3HPz (ORCPT ); Tue, 30 May 2023 03:15:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02CE190 for ; Tue, 30 May 2023 00:15:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7473D62AE5 for ; Tue, 30 May 2023 07:15:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D61ABC4339B; Tue, 30 May 2023 07:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685430951; bh=X+BQQC4rj6ECAJci4wdH+HxbQRJqFPTHu0vmtpJ2wLk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KRBDqNd3TjiBDur7/H8etO2RqXb/WtjlFUeXjcMwxFqG+F0j9Yl/vrOKfyp75rIY7 v90qRATHlP1UhTI7/HHKjtERBh2hk8hQJF+xr+GrtkiK6Bjc/V3Vrs7pLTiv79y74i Xt8RrLWylthnWdOY/VdZ86Fv/UEH56lAR90bUfy2gmq3sKo/F+nbucPTLY3LFTvv4N KtuHXQGpI9CxFcL8U8r1K4TY5iOauWVSOfyEiSRHoID+vPdFTjQzql07gLfKKuLOcS Gt6vFQ4ecqcZ0M7hfoKRssmctO2a1s9Nnc0ILRUWLIUkmbKlAUDmfE9exBwu9AMfw7 csqdW9JWAfYFg== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q3ta9-001Dwc-88; Tue, 30 May 2023 08:15:49 +0100 Date: Tue, 30 May 2023 08:15:47 +0100 Message-ID: <87r0qyjnmk.wl-maz@kernel.org> From: Marc Zyngier To: Yan =?UTF-8?B?WmhlbmfvvIjkuKXmlL/vvIk=?= Cc: "linux-kernel@vger.kernel.org" , Gao =?UTF-8?B?TWVpdGFv77yI6auY546r5rab77yJ?= , =?UTF-8?B?Ilpob3UgUWlhbyjlkajkvqgpIg==?= , "tglx@linutronix.de" , =?UTF-8?B?IlpoYW5nIFpoaXpob3Uo?= =?UTF-8?B?5byg5rK75rSyKSI=?= Subject: Re: [PATCH v2] irqchip/gic-v3: workaround for ASR8601 when reading mpidr In-Reply-To: <6452e00de4e446ddb25588e29fa9e768@exch03.asrmicro.com> References: <20230517075500.43516-1-zhengyan@asrmicro.com> <20230522110643.3063073-1-zhengyan@asrmicro.com> <87sfbfji4q.wl-maz@kernel.org> <6452e00de4e446ddb25588e29fa9e768@exch03.asrmicro.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: zhengyan@asrmicro.com, linux-kernel@vger.kernel.org, meitaogao@asrmicro.com, qiaozhou@asrmicro.com, tglx@linutronix.de, zhizhouzhang@asrmicro.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 May 2023 07:07:21 +0100, Yan Zheng=EF=BC=88=E4=B8=A5=E6=94=BF=EF=BC=89 wrote: >=20 > > I came up with the following patch, which keeps the workaround *in > > a single spot*. > >=20 > > Let me know if that works for you. > >=20 > > M. > >=20 >=20 > Really thanks for your help, this patch works well for us. > My previous patch was too ugly, this one looks better. I didn't find this= good solution. > Should I send a patch for v3, considering that you're the author? See [1]. I've split the refactoring in its own patch, and kept your authorship for what is left of the workaround code. No need to resend, I'll queue that for 6.5. M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/l= og/?h=3Dirq/gic-v3-asr8601 --=20 Without deviation from the norm, progress is not possible.