Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 09:41:23 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     wei.fang@nxp.com
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
        netdev@vger.kernel.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 net-next] net: fec: remove last_bdp from
 fec_enet_txq_xmit_frame()
Message-ID: <ZHWoo2QNW0z3pZdb@corigine.com>
References: <20230529022615.669589-1-wei.fang@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230529022615.669589-1-wei.fang@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z+u3E+lR1L2y9yYwUjLeLS8ozicun3RKEp87nWIBi6NbM0unlmQzK6hikBWy?=
 =?us-ascii?Q?WJRTg5sz6SEaQiOtmQ5MnsKZExsTaV/slVRfEzo9I3QeLQ50PwWoMDxp0K4a?=
 =?us-ascii?Q?mF9QFYUX6T3BsBHqWtOCW/Oz3UlU+d59cH8iUKc1ZNMZaoD6bdKUonbVNI8F?=
 =?us-ascii?Q?Fb97xWmlNvB3E+gJYRvmQmf8WBFWgKfP3KaC+GXyC1j7AxAmm/+U+xwvDX8J?=
 =?us-ascii?Q?jUEaDQsYtuxs/KYdIeg04sMUOX6h4WZq0uw1IXgfK0qFAHIprLHY3/6vPPYx?=
 =?us-ascii?Q?0McrbbeciYLugTA+GzBCn07dL6sVwObNiUv4bn7byxaX38qifacQ2g0DtjtR?=
 =?us-ascii?Q?3U5GpLZqEEb1uPBcLwoI1ruPOHOUpBaOzpp3PDVeIwpu/LcayhCCenebBiA6?=
 =?us-ascii?Q?OxSI/S5hC+RvuiiW1vPa1dUdINEFIUfKqV7GMxBx5bcJ8mCRmf5KSHBhFXht?=
 =?us-ascii?Q?Vh6PIaipOFb7mszBsROzw7lJr0s25bvgXNcvo+7Ens5yuD2OaPE6pMj+cWRQ?=
 =?us-ascii?Q?PEp6PjcvcrQLn8m3GzlKUA7dvjxCLPkZ3ZwdFbxBN0EbQeri+5DJUqKN9izG?=
 =?us-ascii?Q?BpSXF68ZPoGisO2i+Uae35rGcXhOP91eD4SEZigC5x7/Hk/l5UrRulIFshCf?=
 =?us-ascii?Q?F8s1q5BetwxtoK7l250nSwReZqcP5Jtj4ELv8v13MytjtA848OIbEvEYYdT5?=
 =?us-ascii?Q?hBA85lsSdXeZApavcoKvnHV7OPmntKselq39uRt+ZTHsgi5SuQFx5T1wSla/?=
 =?us-ascii?Q?+Y6iiJIkwcjPT9SpH39EVOblX1H3NsH4iQUd88EAnY0Fy/Vvwjx+lpCy1AS9?=
 =?us-ascii?Q?r5iFfAgzeyxvraZa5tGDHGb3EV7kPLwKMuf2fDDThqKRkyvVP74yptE1lojW?=
 =?us-ascii?Q?8RctPmo78X696S9/b6GtG886scPVs8DG+6/xbF7siplFasZLXvPhM+tRHgDp?=
 =?us-ascii?Q?AG2TY58FTwJYvclUEUBUJKXNNZGz/HKBh3BEK4ET862La9CZrpmxOvR5m/Qo?=
 =?us-ascii?Q?UCUjsBHS6Pb19ehfzu9KngOs8fgHO4CXDzlU/zRy/Te+S/sVf+dSXaDoSzk0?=
 =?us-ascii?Q?LXVdcAlAs5ICsuMBHIWw8cM/9up9Xsqu8DbENt7Uk+i1aEld2x2eFAELGp2o?=
 =?us-ascii?Q?7Yqs1elaRHp4Y3VV48VlKGLv4xC3T4Zipzf0/iwOlEVU8eaQATwL/TfHNWCh?=
 =?us-ascii?Q?r9MssEw8VRaA/+dLwtnP8KJDpdK8Imums8DneZMhwDQAJCQ50jX1zM4IFzMm?=
 =?us-ascii?Q?731eCDWQFYFURNR37fy4/DF3UHXgB4UYvYZnl7CQy3fEDhg8lIIgsBWVhWRA?=
 =?us-ascii?Q?EU4pKPeSR8WQvcMgkNPYoriAWXx6xX4pu6/u1rx5aEyEhsTV4GNtIF8MYywI?=
 =?us-ascii?Q?Y1BnWEdFxC7C7TC68BP6E6DFhf4F7oq4+N9s2pxBF4G6+FImrnheGHO+ShHr?=
 =?us-ascii?Q?yGfHETPPXD4DLBpF+5DpQRCcV1qqsjTMetvvADkgz1I4Rk2fEopD5uQaIvGi?=
 =?us-ascii?Q?mchuM/xKwWhZOIZGYO4L9/8TO2kcTU+wRjt1N4QM9Dav3hmdfBh7pD8Dcmfe?=
 =?us-ascii?Q?lnekTy3GKiqxc0gsA6eqkCP5Ro9P/cER2a2szGwUhsVBWaBeSx1wRy++R86f?=
 =?us-ascii?Q?KYxWQslMuK8h+PYc8qrXbtsotHfJlklUVMc5nb8mDWfBfuTNFo46MYIrLpKu?=
 =?us-ascii?Q?WFXKLA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff5ab763-4257-4af9-11b7-08db60e1489f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 07:41:30.6528
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BVCMW+lm672LIpt5tFcT81fhLYu4/lhqAjFndI9kW2y+DjDbhXDETwqbs4TIeX5aTWTDyR5oR2jgDyHR1YswutvcgDAif2DIBD2y12Vx4QM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR13MB6494
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 29, 2023 at 10:26:15AM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
> 
> The last_bdp is initialized to bdp, and both last_bdp and bdp are
> not changed. That is to say that last_bdp and bdp are always equal.
> So bdp can be used directly.
> 
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> V2 change:
> Refine the commit message to make it more clear which is suggested
> by Simon Horman.

Thanks!

Reviewed-by: Simon Horman <simon.horman@corigine.com>