Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 11:26:39 +0300
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     gregkh@linuxfoundation.org, r-gunasekaran@ti.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tps6598x: Fix broken polling mode after
 system suspend/resume
Message-ID: <ZHWzP6qsgzSayhIO@kuha.fi.intel.com>
References: <20230530065926.6161-1-rogerq@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230530065926.6161-1-rogerq@kernel.org>
Precedence: bulk

On Tue, May 30, 2023 at 09:59:26AM +0300, Roger Quadros wrote:
> During system resume we need to resume the polling workqueue
> if client->irq is not set else polling will no longer work.
> 
> Fixes: 0d6a119cecd7 ("usb: typec: tps6598x: Add support for polling interrupts status")
> Signed-off-by: Roger Quadros <rogerq@kernel.org>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tipd/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 438cc40660a1..603dbd44deba 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -920,7 +920,7 @@ static int __maybe_unused tps6598x_resume(struct device *dev)
>  		enable_irq(client->irq);
>  	}
>  
> -	if (client->irq)
> +	if (!client->irq)
>  		queue_delayed_work(system_power_efficient_wq, &tps->wq_poll,
>  				   msecs_to_jiffies(POLL_INTERVAL));
>  
> -- 
> 2.34.1

-- 
heikki