Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230530083911.1104336-1-glider@google.com>
In-Reply-To: <20230530083911.1104336-1-glider@google.com>
From:   Alexander Potapenko <glider@google.com>
Date:   Tue, 30 May 2023 10:40:26 +0200
Message-ID: <CAG_fn=U67cq4502h2G8kms8r6e=13tn8Ta+QWhA8N6cK-PFyaA@mail.gmail.com>
Subject: Re: [PATCH v2] string: use __builtin_memcpy() in strlcpy/strlcat
To:     glider@google.com, andy@kernel.org, akpm@linux-foundation.org
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org, elver@google.com,
        dvyukov@google.com, kasan-dev@googlegroups.com,
        ndesaulniers@google.com, nathan@kernel.org, keescook@chromium.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, May 30, 2023 at 10:39=E2=80=AFAM Alexander Potapenko <glider@google=
.com> wrote:
>
> lib/string.c is built with -ffreestanding, which prevents the compiler
> from replacing certain functions with calls to their library versions.
>
> On the other hand, this also prevents Clang and GCC from instrumenting
> calls to memcpy() when building with KASAN, KCSAN or KMSAN:
>  - KASAN normally replaces memcpy() with __asan_memcpy() with the
>    additional cc-param,asan-kernel-mem-intrinsic-prefix=3D1;
>  - KCSAN and KMSAN replace memcpy() with __tsan_memcpy() and
>    __msan_memcpy() by default.
>
> To let the tools catch memory accesses from strlcpy/strlcat, replace
> the calls to memcpy() with __builtin_memcpy(), which KASAN, KCSAN and
> KMSAN are able to replace even in -ffreestanding mode.
>
> This preserves the behavior in normal builds (__builtin_memcpy() ends up
> being replaced with memcpy()), and does not introduce new instrumentation
> in unwanted places, as strlcpy/strlcat are already instrumented.
>
> Suggested-by: Marco Elver <elver@google.com>
> Signed-off-by: Alexander Potapenko <glider@google.com>
> Link: https://lore.kernel.org/all/20230224085942.1791837-1-elver@google.c=
om/

Sorry, missed a "Reviewed-by: Marco Elver <elver@google.com>" from the
previous thread:
https://lore.kernel.org/lkml/CAG_fn=3DUzQ-jnQrxzvLE6EV37zSVCOGPmsVTxyfp1wXz=
Bir4vAg@mail.gmail.com/T/


> Acked-by: Kees Cook <keescook@chromium.org>