Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c15a90d6-b3c1-e432-9216-c4c1e2c44ce6@camlingroup.com>
Date:   Tue, 30 May 2023 11:30:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v4 0/9] serial: sc16is7xx: fix GPIO regression and rs485
 improvements
To:     Hugo Villeneuve <hugo@hugovil.com>, gregkh@linuxfoundation.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com,
        l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com
CC:     linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Hugo Villeneuve <hvilleneuve@dimonoff.com>
References: <20230529140711.896830-1-hugo@hugovil.com>
From:   Lech Perczak <lech.perczak@camlingroup.com>
In-Reply-To: <20230529140711.896830-1-hugo@hugovil.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qz/bfQia/tou7gc7oA7750IK9GZzXy1OItFycnZ2a95yDihz1dtbVAjAe9yw?=
 =?us-ascii?Q?2/wY0oL3p3isJZj/x1vw8BoLkZARKtB9d8HNUrpWUkbZwrXDUVE/x4GRhGiO?=
 =?us-ascii?Q?odORgnDSVqPW7QaPnd8rthngPdaGAd7zaseHmZLYI+x2cPovKoDd/LWkcgmS?=
 =?us-ascii?Q?GcSLNQH/g3Knl1zB5tGCp5XoGURrj333t4km310rnVhil6+4TILEGuu0+Spm?=
 =?us-ascii?Q?t4CBDjui5eSmwH5pWdy4MA4yfnJBro1qjBiUgez56Qpp8gqiA2u6Wp/BnVRy?=
 =?us-ascii?Q?Ilb5gk4L+Ne3lH53Tkfm4vU+yKiABaSIN3qK+iXfPxr5epGgh2MiO3rpNJiA?=
 =?us-ascii?Q?RW01yJMY6SmyBGYOim/ak0TDF/JzHt7cHMRHouFg2J/cuOQrMFR4bdVuJsJa?=
 =?us-ascii?Q?vlZNfDUJWZrpSIDhTLYGILap8LBdDKMkeb66AY+KHEAb+LdUlYxcTU5F88aW?=
 =?us-ascii?Q?Uhr3UxSiWsMxW03l+EYDS1NPBzuWPg/BnJ2xEVSc5NxBBVOlAOUo7Ihnb/tn?=
 =?us-ascii?Q?TMykh9Y5h97lRYxFMQcKrO8iNS6ASrowfWsXXk6YvOPz/g9n0zZdvicoQKK1?=
 =?us-ascii?Q?PGmBUPY8I7bUbmZU1AnJ1GhzjHyVID8+zpLEzNfnNdltuTMI0uM66yiDMcEE?=
 =?us-ascii?Q?bGdDLjbItawiQo+W5GvgRCNA4/HKd5X4jjWSckq1HSk9al+lBJkHSzP5cimG?=
 =?us-ascii?Q?kFn2zaM0ZGxDj7KFUsHH9DR1DsgAByT7CS4f7QDqAzdUpfdjWVB234u8Z6mM?=
 =?us-ascii?Q?duAFiXbOT5CzGGnYRMMDGCc9jcwYDstsHq24rZd7n/kWW0z/dj0c1zD4gifr?=
 =?us-ascii?Q?jjW+piEgd+cA8pwg6YKtVW1OdOzvjrFBj0vMSJveroLwHJSxGdyHS1GGRa2s?=
 =?us-ascii?Q?55LB8acV7OA6dXb1U0Mp8E9i/VHcCZJnhM1pOnK3P0RmFeBz4+uwnr7KXhKQ?=
 =?us-ascii?Q?GX446yAmQtFOV4fc43xlX6zcRHdlknJqmHrzCLkUVl6uCEy6VB5v3K62J0d0?=
 =?us-ascii?Q?mMHbh6iYS72K3m/8c4WV/Ues86BkqrYpLump46RrGnz8zXkgDwzUk7PtvU3y?=
 =?us-ascii?Q?8Gj5FDD8AT82YsDgsPGhY53Q6KewgDhWjORFEJGU8xc6QFkIpGgw7zL/rWDI?=
 =?us-ascii?Q?+KMQkJCbUPONk/l0LkAwIQZkjtpB4XaNckzTQdwyY9z2sMceUhGlmHg08klX?=
 =?us-ascii?Q?OBw+pdpIxL2yedXxRu48Rt6ndBTrhtzzL+QUeOAbOgW1a1tln1fRggC1MXt6?=
 =?us-ascii?Q?w8qK+ZQ5H95g+uNzTGpWI2apDgncu17beGfxZXhK7hvQp4pvpNzSdxWYMAz4?=
 =?us-ascii?Q?tYuT970mH6TXcadN0s4rGjeGoU51jwgARrY1vbYxQULw/Ryzcw3/yBEnkX4t?=
 =?us-ascii?Q?37NFCtAOW0fa4qU8chsqXd59YbTWeJHTOyb+TIpRIhx1tb6iQadswU4r7kOd?=
 =?us-ascii?Q?nBuxezpfMgkQewrWJyIcVK7HACW8bu+pi4yE1xZmDkvp1iAE+e0DH5fla0VX?=
 =?us-ascii?Q?0n6TmOWBVaumi4ujKF5n3BfnxQgERIGCzA8qothx/bK5zElhtlW35/nDVjfq?=
 =?us-ascii?Q?qUYQ+pGv/eZQ5hSgHfFIswtnWd+O0xwiMylbIJoYkwwOohKW7jGlhsw1uZx5?=
 =?us-ascii?Q?nQ=3D=3D?=
X-OriginatorOrg: camlingroup.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57b1d8c8-2a40-428d-7c8f-08db60f0848d
X-MS-Exchange-CrossTenant-AuthSource: CWXP123MB5267.GBRP123.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 09:30:33.7037
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fd4b1729-b18d-46d2-9ba0-2717b852b252
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /oynNsH4gvo4OIVcCMObpK69mZytSvdEv8/3aWcXcI7pMjtF4pyZ/lE7+9U4z+yHxhlrlc1VjM+KL0RoIZ/ZzQW+zv/3gTWjQa+645IRHdE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P123MB7163
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: camlingroup.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

W dniu 29.05.2023 o=C2=A016:07, Hugo Villeneuve pisze:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Hello,
> this patch series mainly fixes a GPIO regression and improve RS485 flags =
and
> properties detection from DT.
>
> It now also includes various small fixes and improvements that were previ=
ously
> sent as separate patches, but that made testing everything difficult.
>
> Patch 1 fixes an issue when debugging IOcontrol register. After testing t=
he GPIO
> regression patches (patches 6 and 7, tests done by Lech Perczak), it appe=
rs that
> this patch is also necessary for having the correct IOcontrol register va=
lues.
>
> Patch 2 introduces a delay after a reset operation to respect datasheet
> timing recommandations.
>
> Patch 3 fixes an issue with init of first port during probing.
>
> Patch 4 fixes a bug with the output value when first setting the GPIO dir=
ection.
>
> Patch 5 is a refactor of GPIO registration code.
>
> Patches 6 and 7 fix a GPIO regression by (re)allowing to choose GPIO func=
tion
> for GPIO pins shared with modem status lines.
>
> Patch 8 allows to read common rs485 device-tree flags and properties.
>
> Patch 9 improves comments about chip variants.
>
> I have tested the changes on a custom board with two SC16IS752 DUART usin=
g a
> Variscite IMX8MN NANO SOM.
>
> Thank you.
>
> Link: [v1] https://lkml.org/lkml/2023/5/17/967 <https://lkml.org/lkml/202=
3/5/17/967>
> [v1] https://lkml.org/lkml/2023/5/17/777 <https://lkml.org/lkml/2023/5/17=
/777>
> [v1] https://lkml.org/lkml/2023/5/17/780 <https://lkml.org/lkml/2023/5/17=
/780>
> [v1] https://lkml.org/lkml/2023/5/17/785 <https://lkml.org/lkml/2023/5/17=
/785>
> [v1] https://lkml.org/lkml/2023/5/17/1311 <https://lkml.org/lkml/2023/5/1=
7/1311>
> [v2] https://lkml.org/lkml/2023/5/18/516 <https://lkml.org/lkml/2023/5/18=
/516>
> [v3] https://lkml.org/lkml/2023/5/25/7 <https://lkml.org/lkml/2023/5/25/7=
>
>
> Changes for V3:
> - Integrated all patches into single serie to facilitate debugging and te=
sts.
> - Reduce number of exported GPIOs depending on new property
> nxp,modem-control-line-ports
> - Added additional example in DT bindings
>
> Changes for V4:
> - Increase reset post delay to relax scheduler.
> - Put comments patches at the end.
> - Remove Fixes tag for patch "mark IOCONTROL register as volatile".
> - Improve commit messages after reviews.
> - Fix coding style issues after reviews.
> - Change GPIO registration to always register the maximum number of GPIOs
> supported by the chip, but maks-out GPIOs declared as modem control lines=
.
> - Add patch to refactor GPIO registration.
> - Remove patch "serial: sc16is7xx: fix syntax error in comments".
> - Remove patch "add dump registers function"
>
> Hugo Villeneuve (9):
> serial: sc16is7xx: mark IOCONTROL register as volatile
> serial: sc16is7xx: add post reset delay
> serial: sc16is7xx: fix broken port 0 uart init
> serial: sc16is7xx: fix bug when first setting GPIO direction
> serial: sc16is7xx: refactor GPIO controller registration
> dt-bindings: sc16is7xx: Add property to change GPIO function
> serial: sc16is7xx: fix regression with GPIO configuration
> serial: sc16is7xx: add call to get rs485 DT flags and properties
> serial: sc16is7xx: improve comments about variants
>
> .../bindings/serial/nxp,sc16is7xx.txt | 46 ++++++
> drivers/tty/serial/sc16is7xx.c | 150 +++++++++++++-----
> 2 files changed, 156 insertions(+), 40 deletions(-)
>
>
> base-commit: 8b817fded42d8fe3a0eb47b1149d907851a3c942

It would be a lot of sending, to do that for every patch separately, so for=
 whole series:
Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com>

And where applicable - for code patches:
Tested-by: Lech Perczak <lech.perczak@camlingroup.com>

I tested whole series at the same time.
I did my tests on an i.MX6 board with SC16IS760 over SPI, which differs a t=
iny bit from SC16IS752,
and everything works as it should.
Thank you for fixing this!

> --=20
> 2.30.2
>
--=20
Pozdrawiam/With kind regards,
Lech Perczak

Sr. Software Engineer
Camlin Technologies Poland Limited Sp. z o.o.
Strzegomska 54,
53-611 Wroclaw
Tel:     (+48) 71 75 000 16
Email:   lech.perczak@camlingroup.com
Website: http://www.camlingroup.com