Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Moudy Ho <moudy.ho@mediatek.com>,
        Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
        Arnd Bergmann <arnd@arndb.de>, Lu Hongfei <luhongfei@vivo.com>,
        Sun Ke <sunke32@huawei.com>,
        linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE
        (V4L/DVB)),
        linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support),
        linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC
        support),
        linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC
        support)
Cc:     opensource.kernel@vivo.com
Subject: [PATCH] media: Fix resource leaks in for_each_child_of_node() loops
Date:   Tue, 30 May 2023 17:45:34 +0800
Message-Id: <20230530094541.23396-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y19Pa7yWFBVAxHLb1GrUBAbf6Y+FIdr3/Hs3W7s/Twds2i7ge9JlPJ5lgPgc?=
 =?us-ascii?Q?f+y9KNcsmdH8BaTIYvW67F+Xvoh2oyRzBYpXcemqKkh7eSo+RtkkIBXkT4+/?=
 =?us-ascii?Q?3UNcvKQQ8RWpFcBUMQ4n4ZVuEj2pKzUuK0/frTNv8i81FsRVScOR9CpbPZ0M?=
 =?us-ascii?Q?m8uOsMP8Z7yH0rEA6+o9u6HE84pbBtoi0Eh5mMG/niN8gUwT+U3mXKIP16bK?=
 =?us-ascii?Q?gv9dOHDnhY0O9heduM3UzJFwmhtIlXAC+e4sLjJCmulpFMaHraq/4uzFQPhw?=
 =?us-ascii?Q?BVYgPqmmAWmFpwt/7DQhhHW/PJ0PUbOYziB1eiU52G6uC9qRTlD5lyG4aJvp?=
 =?us-ascii?Q?KNMeUGY9BwIlOWzcN9CE36jufP40Bb46d/Zqj675Ja4/0aCOQWARydQfCKh5?=
 =?us-ascii?Q?MrPxn41SWFcEKdmsYGw1GNSSLr7a6S8s7qU6y5HxXhd2BpGHcmEPKsFD3SgZ?=
 =?us-ascii?Q?IEvpMG27EDYpllgbumk+dCvrU03M3A6otytZPGSLpLAubyqAm7LgZPkL9dHS?=
 =?us-ascii?Q?BQF4HQFd8pZAc00KLgtweQ0m9nvkYfCiLbnX9vh9hCy55JOIJE5r5oXDdBxO?=
 =?us-ascii?Q?+spHbGgmoxYh/tVUc3e6Vfkxt1b5ugt9LP1Yp1Lk7K8ZghDKRuxPMTY4j5op?=
 =?us-ascii?Q?p4vyn5WlJR3ofSzs55emPsaKh86qfZA6gIMz3gYgD3uqPirLHkBcWNPJtfiO?=
 =?us-ascii?Q?sPog/A7kgDhDKWaiyqaHN3EUFZ0z4Z9r4FeRPpkpVqvDOX4HbpFGvs83OyEi?=
 =?us-ascii?Q?U64MrHWs1uwjFmZF532FAsvoOm5qvhSLaPOdV8hn9cpZdyJd4RHUjCboaKh0?=
 =?us-ascii?Q?04xhQwn7V+1ZVYh1fUoMQYFJj79iyKbzaDuEEGW/uzb0ZBgorMVDyS8En3ji?=
 =?us-ascii?Q?jV+ZeASYkwilV2axMUOYdv3SByp7hVnkeiqq2EtqcFTa7frrxWLOTqyGzF/I?=
 =?us-ascii?Q?K+D2Db1YrsRRUCcDwdwooADNIXOF2Obo0QgkXKAG80kGQO2xnXWIfq441Hyo?=
 =?us-ascii?Q?bFWKQTAWGhB5fdiSPe5qmt3ZBwuoyS85RAmzSlatv9hQA1tEoEma7P2lEnke?=
 =?us-ascii?Q?/K37TK3pvIARiFc4ba34y0BnyfAOMf6mv91loVBuL++aWshyhs6skaMGtWQG?=
 =?us-ascii?Q?ppvJFCa3qy52GJDmLkrYOS0wGUpDid4JXM8zNyWsBvmAyzdaJflzPB2iL4xE?=
 =?us-ascii?Q?w5Bkn0s4n+EQPY1u5xJaliHmAslLvrzIztF4bybASw+tF6cVTIGkYCowuSCH?=
 =?us-ascii?Q?IBbtwhzq/OSpLrRpba4iCqslnzuATohfJUO/gIDn7Y1EWJ+tX7mTmyYIhVlQ?=
 =?us-ascii?Q?HdQebETML6rSU8QTqsfblJjjB29sGvppwlyBQbevtj5mKgq1CJ+BdeQLehuC?=
 =?us-ascii?Q?n/WxnnTBkmAf1P3M0vLWVvyemLWDd7MijN15xeibHmAG5yy15ih2+x3LkT4C?=
 =?us-ascii?Q?WZCUo7KohghiinfWbNc9PabhDgDBbCGDySKBuTrTjj3Y9O4QRVEO4+fOoRtm?=
 =?us-ascii?Q?XcNZO7cMI+T31635KwJ9mgfUb/lh9hKfm57XXh+3VDqDadNFnfvPSlQM9wxS?=
 =?us-ascii?Q?Tq7/rJAZi+7jLcG2ULVZBz8r+G2LHuv7a5g10NWZ?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5709294f-cdf5-4ce6-a408-08db60f2a74d
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 09:45:51.0730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: emFrmuSny5RNCjFkKRaoXITCu15tIskva+gyN7/3/6L0N/VCkUBixW5UpmOiX2GYer7kiKv4nnTsZCJivCjTbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB4394
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

for_each_child_of_node should have of_node_put() avoid resource leaks.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 3 +++
 1 file changed, 3 insertions(+)
 mode change 100644 => 100755 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c

diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
index 19a4a085f73a..5a6a61d68cba
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
@@ -1128,6 +1128,7 @@ int mdp_comp_config(struct mdp_dev *mdp)
 		comp = mdp_comp_create(mdp, node, id);
 		if (IS_ERR(comp)) {
 			ret = PTR_ERR(comp);
+			of_node_put(node);
 			goto err_init_comps;
 		}
 
@@ -1137,6 +1138,8 @@ int mdp_comp_config(struct mdp_dev *mdp)
 		pm_runtime_enable(comp->comp_dev);
 	}
 
+	of_node_put(node);
+
 	ret = mdp_comp_sub_create(mdp);
 	if (ret)
 		goto err_init_comps;
-- 
2.39.0