Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 11:02:48 +0100
From:   Mark Brown <broonie@kernel.org>
To:     William Qiu <william.qiu@starfivetech.com>
Cc:     devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Emil Renner Berthing <kernel@esmil.dk>,
        Ziv Xu <ziv.xu@starfivetech.com>
Subject: Re: [PATCH v1 1/3] dt-bindings: qspi: cdns,qspi-nor: Add clocks for
 StarFive JH7110 SoC
Message-ID: <d417628d-7994-4b07-a670-ec14ad938764@sirena.org.uk>
References: <20230526062529.46747-1-william.qiu@starfivetech.com>
 <20230526062529.46747-2-william.qiu@starfivetech.com>
 <87e9ed95-ea57-44c8-85f8-34264b5c6dde@sirena.org.uk>
 <a09cc0c9-ef4e-120f-e61a-94f628d67e38@starfivetech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="OStcWnmwJi2B52q7"
Content-Disposition: inline
In-Reply-To: <a09cc0c9-ef4e-120f-e61a-94f628d67e38@starfivetech.com>
Precedence: bulk


--OStcWnmwJi2B52q7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 29, 2023 at 02:44:13PM +0800, William Qiu wrote:
> On 2023/5/26 23:33, Mark Brown wrote:
> > On Fri, May 26, 2023 at 02:25:27PM +0800, William Qiu wrote:

> >> +        clock-names:
> >> +          items:
> >> +            - const: qspi-ref
> >> +            - const: qspi-ahb
> >> +            - const: qspi-apb

> 	I'm going to change the names of these three clocks to hclk, pclk,
> and ref_clk, as defined in the data book. What do you think?

That looks fine.  ref, ahb and apb would also be fine, it's just the
qspi- prefix that I was querying.

--OStcWnmwJi2B52q7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmR1yccACgkQJNaLcl1U
h9DfAgf5Ad6LjZ0DMJ0r5lAycWLFFFtfNyz0mTrawQwG8YBWBhOCeCcdPjjJIiUg
NFKMOUJHcx60wG72KuRjERBeDR3xqA7KdREBspEM004CeKMYPUX4WmG9Wt4VNjtJ
Dcrt2QUrhdx8yvc1nf83wj2bF4xxKtI31Y/6zK2dVrrloTXfne04z3Kv3snetvtc
ZICIfgYQzb3Nzi6Uc0ib6CPNh6lEF+liqsPghw1K1TAC4dGLg9yOIxvxv2MEBKBX
dsGCuq4W1fi1Uzm9hQFm+TqjfdKSqCdtaf4insH1t7KI8ih60bcUuKC2R/NeK8FG
VqH2t0tD1RUh562zh4jZBFepUEaJpg==
=SLrS
-----END PGP SIGNATURE-----

--OStcWnmwJi2B52q7--