Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Moudy Ho <moudy.ho@mediatek.com>, Sun Ke <sunke32@huawei.com>,
        Arnd Bergmann <arnd@arndb.de>, Lu Hongfei <luhongfei@vivo.com>,
        linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE
        (V4L/DVB)),
        linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support),
        linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC
        support),
        linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC
        support)
Cc:     opensource.kernel@vivo.com
Subject: [PATCH] media: Fix resource leaks in of_find_device_by_node
Date:   Tue, 30 May 2023 18:17:18 +0800
Message-Id: <20230530101724.31412-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OvJHRLUu+NJQ1N8cHr+mH0rY2feN0donY7dLKU954CkzztGdJCxNJWV4qeqG?=
 =?us-ascii?Q?JbrfWLwBX1VuNIAx1D2DXTsXOw2OZftFqbgf9yzYrhCC66Bg9PJaZKCgUAW+?=
 =?us-ascii?Q?38iG7y0bDT5wS+gNgnFLTxM0f5lS3B3Ev1Ul80XStB9elGw/N8ngswrL7JG0?=
 =?us-ascii?Q?dqBkMiBHQPFOch/FYtto5Blmx558VXAyntkzwfnXScClYPKlOXcfMq6aielM?=
 =?us-ascii?Q?mYrsD9JNnp4zjlr7Y5SHVWqJuUSSjxqm45YWtmiQJ0YYI7LnYO4iV8ImH8Oz?=
 =?us-ascii?Q?Mp24XjQ+mWgb4HbWUrwOZX03842NdsT/kN/eJyNWxhBi+JuP2nWyN3OSqr84?=
 =?us-ascii?Q?kNxbZv1iQ2g1Gc8qpOmWeOP8o0lBw3WKLTL5bd7afBi1PbfJ4zWaTpBxtjaJ?=
 =?us-ascii?Q?nmNWehi8M269QaJny7KhdwbxnE66ylPJViuztt1IzdTII8ilQftQ4aYkq+Rf?=
 =?us-ascii?Q?KpaX+5cFjYefH3YIc9QKwW4WsEykUkUamdvp3WfRo53WpDrDYF7BpbATdLqn?=
 =?us-ascii?Q?QCpL/Ufk6+3i4TRzTguJoeILua9WPqe90QHsMmmlyy7RNmjv83ZFzXheUkqo?=
 =?us-ascii?Q?IJkVVSdO8D5df20P2eFxn9hP0ga1krmRfH3ssfwFgR8Fo2BLpatOaaNvtop9?=
 =?us-ascii?Q?5qlM0DRiMAXw4JPDnj+7Od5gBtraGwcL7Vuq5g62I3oVzs7BnJ683HElgy0T?=
 =?us-ascii?Q?rk4k+nCPmev4fqZQZoAMPNnrXXICPGEx9aIs/Hb0ZSkL/E1EA/K5ECgOOq1i?=
 =?us-ascii?Q?5s9TxtHl03kIezTyuNjLpUkoxEoRI/znlCE5OPVRuzkx5fHcsfV7nuZ0fxKZ?=
 =?us-ascii?Q?AYNL8NV+syyL1rI9s3IqBoHCBuTj1o+kaCD3fgqWdAIwC5YH38bt61iVtMj0?=
 =?us-ascii?Q?LMFAiNQ1413OIYxFJolyT+skUzPQA3Tg0O8vL/VJTo7877vslWvkUkVU++mi?=
 =?us-ascii?Q?+Q/qRpIkkGXPoVMGMKp3JkJs9WYpeFiz3uXRhU8Bc/2l1oO0ybK5mQDA6cKf?=
 =?us-ascii?Q?HFKkNS/3/msKkdM4KzoRKmNJc80eWHxEj+spjqLDcoGDUhwbwVNgWDYi65Ni?=
 =?us-ascii?Q?/4XwdNXFrP4UbOCJqQYYtrSMC320h4tdcTKgSiTOHQG6JQ2Bo9voHalt5zLo?=
 =?us-ascii?Q?xrLteCa1VSCQQ5ScgKsR39P/GsoVYZctfUMaZQ9HTKVtNT9z0K4J+eteD7yy?=
 =?us-ascii?Q?hi06GXgz+Su1x+Ubs2XVqw18Ur/4AMZWcINE5D3nxKO7pMQwlU+Fn8l8ANah?=
 =?us-ascii?Q?J1IJzAq+1MPrHmviTa09l8zgqra9EkhJjmqIDjaxC0yLqclUh11KL9dyMWD6?=
 =?us-ascii?Q?QiJdC7XNn0Gqsd6ddhS43aBc4lCECGqXn7h/3iJlGmwcn2fwhtMlL2vCUChY?=
 =?us-ascii?Q?0VKlrcNUZqYR0UIAeIcuwnlqAbnNOeZ2mURZY9132yFdQLc6f4wkMGL4qJWV?=
 =?us-ascii?Q?FDGmJL611gofrxm3D79iqQo7QPTq5b5d63KevrcwySiKofvnsm69lF3jYAYo?=
 =?us-ascii?Q?qAwld9NuEzaL6LNVMItdlpTQ/+un/0+YahegE3J7rEFDsNAih0sVh2FQS2Je?=
 =?us-ascii?Q?pln1z09n3qjYhFmokunGL46aB+PUyUzIMJEB28uQ?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b71193f-fd70-4f20-7ee5-08db60f715ee
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 10:17:34.6622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6JHC7MzLp71kFw+SZzcs1tqyY04mLVEKgv2/5nHSoM9FuPhplnAHzC26gbuezG1/VjDAayu1BhmvEJwJ7z7XKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB6032
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Use put_device to release the object get through of_find_device_by_node,
avoiding resource leaks.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 2 ++
 1 file changed, 2 insertions(+)
 mode change 100644 => 100755 drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c

diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
index 19a4a085f73a..1fe10a21e395
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
@@ -892,11 +892,13 @@ static int mdp_get_subsys_id(struct mdp_dev *mdp, struct device *dev,
 	ret = cmdq_dev_get_client_reg(&comp_pdev->dev, &cmdq_reg, index);
 	if (ret != 0) {
 		dev_err(&comp_pdev->dev, "cmdq_dev_get_subsys fail!\n");
+		put_device(&comp_pdev->dev);
 		return -EINVAL;
 	}
 
 	comp->subsys_id = cmdq_reg.subsys;
 	dev_dbg(&comp_pdev->dev, "subsys id=%d\n", cmdq_reg.subsys);
+	put_device(&comp_pdev->dev);
 
 	return 0;
 }
-- 
2.39.0