Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4351385rwd; Tue, 30 May 2023 04:22:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Nc/CzqeKD9OKEinBpR7KswP3aQi7jRnB3q1MGzinIEMTzpL+4gGoJSAoaNQuswgQJsueU X-Received: by 2002:a05:6a21:6d8c:b0:10b:d70d:f971 with SMTP id wl12-20020a056a216d8c00b0010bd70df971mr2301769pzb.3.1685445750428; Tue, 30 May 2023 04:22:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685445750; cv=none; d=google.com; s=arc-20160816; b=KP4B0sr9fp4sVGEbbTKSDjZlloF+UCWM2/aEfMdaUa00yXm/xs5bVulesiSMQIui8o PBovi0UdllKnJAALULDXibD7M42fkqQ+Wqs6XXpuoo07A1LUFJcPykrBCXJAzB45N1NK jijZik/hjoYdlhLV3mwn8IAbCikqw1RF1trcKhgD32UcuPQnA85MJWjFCxRj7r9eJo8K 37n4pgDa60cvu2XZgIYxJY2CcVSv5ACDUgpYsPkHfQmZCA5VTvf3QumIpeumdA4c4f1k zCnzujq7e0IdhKdKU+2HIIb7Q5XBFztJuCi6MB2AlqhB6xufLwhE4peHhiVBToIS4jpP muzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:date:from; bh=OvSRGFisYODuy4tsKVrFm27CeWgSUY2e0my6bCNH7ME=; b=rpcPok7qeXqQi1yoMPJWQ520mtkJ8WRP+Oy6HEhBOiRl7acA6m4ZMvkhCxwo0I0vxP lOjdCHWma5DAW0aG+cEDywvVI9EWT1BpiIlAt/wnPhv91wBm5ZmPPTTnutf23kG6wKSn g3G5gX/a0qD7uOqC+1WqGYzp2PZUhikmZvZ8jJkaTRlw93zMM87cvkovRjUxCXWenwDz LEtyFPSEOfMJo0ETh40SH8QTW9VMOc9HPzmXchzzG8xNqBtuUXgvQo+SxsconoM/0SRY yHEK6eNPq72kvhgFinle9NT1naXmVnOkYBubyTR9tpmqI+uMhQKpSlb08c3SJIs/GaXS +B9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y17-20020aa793d1000000b0063b872934a4si1512823pff.340.2023.05.30.04.22.17; Tue, 30 May 2023 04:22:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229551AbjE3LPq (ORCPT + 99 others); Tue, 30 May 2023 07:15:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjE3LPn (ORCPT ); Tue, 30 May 2023 07:15:43 -0400 Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92A5A93 for ; Tue, 30 May 2023 04:15:42 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 4f256f9d-fedb-11ed-b3cf-005056bd6ce9; Tue, 30 May 2023 14:15:40 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Tue, 30 May 2023 14:15:39 +0300 To: Hugo Villeneuve Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Hugo Villeneuve Subject: Re: [PATCH v4 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements Message-ID: References: <20230529140711.896830-1-hugo@hugovil.com> <20230529220708.66f7825fed9ee36b181128cf@hugovil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230529220708.66f7825fed9ee36b181128cf@hugovil.com> X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, May 29, 2023 at 10:07:08PM -0400, Hugo Villeneuve kirjoitti: > On Tue, 30 May 2023 01:31:28 +0300 > andy.shevchenko@gmail.com wrote: > > Mon, May 29, 2023 at 10:07:02AM -0400, Hugo Villeneuve kirjoitti: > > > From: Hugo Villeneuve > > > > > > Hello, > > > this patch series mainly fixes a GPIO regression and improve RS485 flags and > > > properties detection from DT. > > > > > > It now also includes various small fixes and improvements that were previously > > > sent as separate patches, but that made testing everything difficult. > > > > > > Patch 1 fixes an issue when debugging IOcontrol register. After testing the GPIO > > > regression patches (patches 6 and 7, tests done by Lech Perczak), it appers that > > > this patch is also necessary for having the correct IOcontrol register values. > > > > > > Patch 2 introduces a delay after a reset operation to respect datasheet > > > timing recommandations. > > > > These two patches are w/o Fixes tag, they should be moved in the series further > > as I explained before. > > Your explanation was not clear. Sorry if it feels like this. The documentation should have more clarity on the matter. > Anyway, I moved them in position 7 and 8. Thank you, but take also what Greg KH replied to you into consideration. He is the maintainer and seems other patches needs some additional work in the scope of Fixes / backport (see stable kernel patches flow in the kernel documentation, which I also mentioned earlier). -- With Best Regards, Andy Shevchenko