Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed797fc9-98de-bcc0-583c-6b1c4a807204@nvidia.com>
Date:   Tue, 30 May 2023 12:22:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] arm64: tegra: Fix PCIe regulator for Orin Jetson AGX
Content-Language: en-US
From:   Jon Hunter <jonathanh@nvidia.com>
To:     Thierry Reding <thierry.reding@gmail.com>,
        Vidya Sagar <vidyas@nvidia.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
References: <20230526111727.26058-1-jonathanh@nvidia.com>
 <6dd9edcb-40cf-9873-b8aa-993bb18a3584@nvidia.com>
In-Reply-To: <6dd9edcb-40cf-9873-b8aa-993bb18a3584@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmFscnJVVzhaeDNVazl1Y1pNU2ZnSjlPdUtuWTBxSE55LzBlLzExZFA2SkIw?=
 =?utf-8?B?RldwOFNsVGZWUk5WUitURWIxUnRpZzV2TTdCTllWaTJnUjZ1Vzg0eXAxd3B1?=
 =?utf-8?B?MzVXOW83VFkrWXg2S3A0TFgvMG41U210dUZibjgxbi9kZUd2NEV6ZWpiNk1I?=
 =?utf-8?B?T1RRNWJLWkI1UG51VnBpTzdZNVl3dXJaOVJSVGE2ZHlsNW9COHkrRVFTU2Vq?=
 =?utf-8?B?dlpYeVFwU3lWYWN5aUpqaThpdDBicmZVQzIxZnhGOSs4eVptYlNOVjhtL0Iz?=
 =?utf-8?B?WEZ1bW5Tc083a3pFck92Mnl0cTV0NWhZelpCTzUxNzlIbE9MN2RqdFZQS1Qy?=
 =?utf-8?B?bjBNVjZoVHJGWnkzQTNsSmh3eDNEYlg2amdJRFZLZURCWXFxWFI4VGJFSThy?=
 =?utf-8?B?STJBL1J6YUZRRGp6eXpWWERJcE4yaWFlQ3NUazFaTVBzL1hSbmdGMURjbGVF?=
 =?utf-8?B?VkVJODBBb25ITy9HSW5zZDlLSlZQdGZvN3U0SHIyL2tXbnRMSzR4ckxXMnN5?=
 =?utf-8?B?NjJZTXI3bWMwMUxpcGY3bEx5K2RpU1h1VlZoWWtRVFJIVHFod0ozNG1SOHZH?=
 =?utf-8?B?YXZCM1pmTTk1NWM3WmhZOUNXTUFPWUV6NU9Ra0NsUlhkYko3VWh3V0IwZ2tv?=
 =?utf-8?B?dVFsaWZveFFaTnFKdW1Yci9jeDV6NS9vaTlsVHJzajA2Q0FrZmYyYzBJUHRI?=
 =?utf-8?B?SEdpdVJlQVZ2N1VsN2xXWmlNTTBEa1d4MStDTmpjRHBudXFUVEVxVWVLaFFY?=
 =?utf-8?B?anBBdlBid1pvTkNpVkVxQjZqeExzRFZ0bVlVNkNjY2lNeXl2SWQ0UFFZZU9T?=
 =?utf-8?B?RlFiTnBUVGV3VnBTMlhQZEJwYXlsbGFWQ2R2TG9TZzc1SjhqN2VnbitrM0Vn?=
 =?utf-8?B?TDd5OHJQM2JpOWdaU1pSY0ZtWUZOU0wxT0RGMWM5b0tncnMzNmpjTTJWT0cx?=
 =?utf-8?B?Nmk4eG9wVjRsREh2WThzU21YOUpURmlTbmUzR0ZFeVFlVzF6ZGxBalZuZmM4?=
 =?utf-8?B?L3BpOFd4NVF5MHREVXpVbGNlMFdYUVhTc2w4dWRINFBnVk94R3dWTlM1bld4?=
 =?utf-8?B?ZXlsWWNrdTFWU0ljQzcxenJIaFVMbk1TQkdEZVczNDlnTDNFeTBPRDJxYlFP?=
 =?utf-8?B?QWFZUEs5UmVhSXFqSEUwZ3o2ckF0MmZvbldCM3k5M0wzMlRPMzRrN2xYZllm?=
 =?utf-8?B?dnBWMjJkczNMbWtrUEhxR25wc2UvemZEeG5YbXNwRmEvcHVtSWlhSWRFdUZO?=
 =?utf-8?B?VjQwSlhZeTNBSWdrbnFrK0VKTytCLzY2bjRCSWRwMWt2YkQ5aklVeS80dCtY?=
 =?utf-8?B?R043b3lnUEhVeUZtTlJUVWVKM3hKMjJ1d2VtWkVOVHdraVA3WWV2UG40RG9V?=
 =?utf-8?B?a0NQUlJCUVNQeUExY1J1M0l6VDhGVUU0Zk9HKzJ1c3hhcGVTZ2UvN085VmJs?=
 =?utf-8?B?TStVcGtBRVlOOXowcUNNaTRFR1R6MHd2UTYrU21lbzhTN1c0MjZLZytxL0dN?=
 =?utf-8?B?bEVwcG8wd2lrSjhzdEFSNXZxbGMxbTc1SHFUc2Q5d0xYYUJadTRMNTFucVV1?=
 =?utf-8?B?czJaYk1sb2RGaStyOW9qdXRNdkRpb2hkSXJUMWlDY1RuZVlHTENmdVhKOExu?=
 =?utf-8?B?UWhZMWRlSjc0ZHdobTJleXVUTjIveFErdlh6RXdnYkpVWElWVVZPYm9DL1pK?=
 =?utf-8?B?T09MSWk2NS9iYXY0WnlKYW5JeDlsaW5vNlZ3UW1qbVE2a3NGZkRCZFZ1Rk9C?=
 =?utf-8?B?RzBNUVU5WG9xSWJXM251bHNpZzlwTGxzQ0VyeVpBZE5JUUw2dURtVHFnU3FE?=
 =?utf-8?B?bWFML3JCRVJKMi9VdzB5MlJZZHhOak43ZzJVZnBPMUNvTkFrT3ZaYVZuMnJa?=
 =?utf-8?B?bXBjcFNTMGFNWnpVWWNPM3pETTNML0pYTTBnbGlGLytWUTY5S2pKdkJEUVVQ?=
 =?utf-8?B?dlZvY1NrS3g1Tjk1Q0Rac3V5cFNXdURyTmxIdTNGOWtsRkEzVDZwWnkwdlFS?=
 =?utf-8?B?RWNsWUFsL2djRUxLdElaNmpyT2VKTzR2MjBXeEdwT2UrNkk0cGkwaCt0RHBo?=
 =?utf-8?B?OXIzVm96WEt5YnpuWHZwQUpTVDlKb25uK21TNTRkZ3FMckxPN012dklRL3k0?=
 =?utf-8?Q?e2kqyLMfzkq5VkhYclVkiqJr+?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f905e14-b5ed-4532-0833-08db61003a44
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 11:23:01.1382
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PY/w7ubpyjEAb65Q7xYc5FYJp6Eee30E20qfvZwC5BWlQcOlPG2E+kdy8mqtJgQQnIT0sYSxGsYZ/0hWeEd15A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4062
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 26/05/2023 12:19, Jon Hunter wrote:
> Adding linux-tegra ...
> 
> On 26/05/2023 12:17, Jon Hunter wrote:
>> The PCIe slot on the Jetson Orin AGX is not working and PCIe cards
>> are not detected. The regulator for the 3.3V regulator for the PCIe is
>> using the wrong GPIO for turning on the regulator. Fix this by updating
>> the 3.3V regulator to use the correct GPIO.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>>   arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi 
>> b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
>> index e161618cfca8..4dce2e214002 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
>> @@ -142,7 +142,7 @@ vdd_3v3_pcie: regulator-vdd-3v3-pcie {
>>           regulator-name = "VDD_3V3_PCIE";
>>           regulator-min-microvolt = <3300000>;
>>           regulator-max-microvolt = <3300000>;
>> -        gpio = <&gpio TEGRA234_MAIN_GPIO(Z, 2) GPIO_ACTIVE_HIGH>;
>> +        gpio = <&gpio TEGRA234_MAIN_GPIO(H, 4) GPIO_ACTIVE_HIGH>;


Apparently the original GPIO we had was for pre-production boards and 
hence the mistake was made. Let me know if you want me to add that 
detail to the commit message.

Jon

-- 
nvpublic