Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4373037rwd; Tue, 30 May 2023 04:42:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4StpElOU7RYkhNFwlr1AOubATRpF4MfL6AhswEgM+AFUAd7ZFdvagIIlkVMRDe+azmtdDd X-Received: by 2002:a05:6a21:3989:b0:10f:32ec:aa20 with SMTP id ad9-20020a056a21398900b0010f32ecaa20mr2038060pzc.32.1685446944463; Tue, 30 May 2023 04:42:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685446944; cv=none; d=google.com; s=arc-20160816; b=CSGA/0wVj7VsgmhC11eoKN7PwUskQlk9l5BJbyrozlr8NuTuHT+L5/bj1cCexcArwb o30TGrbrEDN0FBR03149/ihvTx/K/9k/I4Fklg5g6L6CLC/uD0UqgzcDpMRIEOx9pW2/ 5R58qLtB+hGiY13HPUwXBZMDl1VNSBIuUx0kNvOm+2lP9lD9TnP1/fRyWLHg3ab+NSzy qHhYTfZRsn8/fqYauuyJcXRiZYAQbI0ytfW5GpePiD/6EoRWLwjHQaFW5kgIlAJ5dSG6 hzyOFeyCzQQK6oaXwOX+sNMfMNGiXXk14J/xlAzDxcckZGdIptNWcqPimL0+CVK9XFfo DDjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XodjMCNxRE+aBuboF6N0VyrefMFmSnUt0j/MLo3XTYY=; b=h4CMHhSJBTHJ4y8nHO0ohgK1M7RCN71JqRfKN3xeK71mmdsMiJb7BxzZEpZXlOM/28 icxHakP6hyIxAgEfGeryySTTHrcyozXrxYF28yJqYQcjl3Dwrqa5KmY8DADvZPEwCdBu D80s3fvu832UeDct6MtGnhL4E0kRstZDs+YhPjKPrrpt94eVXk2JHk9eRgXY/3uYrCBx UOanH0RdkdgG1qO4qNR7yJq7G9JGm22uP/rccQur1Cw+vroi3MJVhXl13spKhcFj9ljK ybRYVlVO7vECkH+jO9Tv6/3Dq0Uid/zbbFZgyspHTBhf+awXDKsdKikCnMmVufR+6A9J kRJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Tfb+wCjf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i2-20020a056a00004200b00643652c8879si1556863pfk.326.2023.05.30.04.42.11; Tue, 30 May 2023 04:42:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Tfb+wCjf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231312AbjE3LUU (ORCPT + 99 others); Tue, 30 May 2023 07:20:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229873AbjE3LUT (ORCPT ); Tue, 30 May 2023 07:20:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27441D9; Tue, 30 May 2023 04:20:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE80062917; Tue, 30 May 2023 11:20:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA15DC433EF; Tue, 30 May 2023 11:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685445617; bh=cTSrXo17OxJMEg/viqIAtotQJ9pg1/100e11SFoN9t4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tfb+wCjfsdJoZ6gRw3MxwYZbumyEtAymr8i4eN79VquflgTL+VpldR/VlciQwnQP0 EGhgFlfw5LLDkGZomJlP9xvFx7NMv/+urT9wyPVOtRyybgpmweUojiawAJvUT5yYNu xINkIOZJJZm2bhwAgOIpOOw+f0wYQYV+FySW6Ees= Date: Tue, 30 May 2023 12:20:14 +0100 From: Greg Kroah-Hartman To: Tony Lindgren Cc: Arnd Bergmann , Jiri Slaby , Arnd Bergmann , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Lukas Wunner , Andy Shevchenko , Matthias Schiffer , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH] serial: 8250: omap: convert to modern PM ops Message-ID: <2023053059-swapping-dominoes-e9b3@gregkh> References: <20230517202012.634386-1-arnd@kernel.org> <20230519054431.GV14287@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230519054431.GV14287@atomide.com> X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 19, 2023 at 08:44:31AM +0300, Tony Lindgren wrote: > * Arnd Bergmann [230517 20:20]: > > From: Arnd Bergmann > > > > The new uart_write() function is only called from suspend/resume code, causing > > a build warning when those are left out: > > > > drivers/tty/serial/8250/8250_omap.c:169:13: error: 'uart_write' defined but not used [-Werror=unused-function] > > > > Remove the #ifdefs and use the modern pm_ops/pm_sleep_ops and their wrappers > > to let the compiler see where it's used but still drop the dead code. > > This looks good to me as an alternative for Geert's fix. If Geert's > fix gets applied first, this needs to be rabased. No need for rebase, it applied cleanly. thanks, greg k-h