Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 11:42:16 +0000
Mime-Version: 1.0
Message-ID: <20230530114216.1420790-1-yimingtseng@google.com>
Subject: [PATCH] PM: domains: fix overflow in genpd_parse_state
From:   YiMing Tseng <yimingtseng@google.com>
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Kevin Hilman <khilman@kernel.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        marscheng@google.com, YiMing Tseng <yimingtseng@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Add type casters to prevent 32-bit overflow before assigning to s64
variables. It allows full 32-bit range support for latency and
residency.

Signed-off-by: YiMing Tseng <yimingtseng@google.com>
---
 drivers/base/power/domain.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 32084e38b73d..26a04cd8d8dc 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2939,10 +2939,10 @@ static int genpd_parse_state(struct genpd_power_state *genpd_state,
 
 	err = of_property_read_u32(state_node, "min-residency-us", &residency);
 	if (!err)
-		genpd_state->residency_ns = 1000 * residency;
+		genpd_state->residency_ns = (s64)1000 * residency;
 
-	genpd_state->power_on_latency_ns = 1000 * exit_latency;
-	genpd_state->power_off_latency_ns = 1000 * entry_latency;
+	genpd_state->power_on_latency_ns = (s64)1000 * exit_latency;
+	genpd_state->power_off_latency_ns = (s64)1000 * entry_latency;
 	genpd_state->fwnode = &state_node->fwnode;
 
 	return 0;
-- 
2.41.0.rc0.172.g3f132b7071-goog