Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4397839rwd; Tue, 30 May 2023 05:04:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4QPWSUHLgq+Fm49npUPzsCiqWurrA3kCpyi3dghfMr5wulNRj4n7z5lqsfWxAK+YXCZAGQ X-Received: by 2002:a17:902:e892:b0:1aa:cddd:57f2 with SMTP id w18-20020a170902e89200b001aacddd57f2mr2525395plg.25.1685448274382; Tue, 30 May 2023 05:04:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685448274; cv=none; d=google.com; s=arc-20160816; b=NDsY90mA0q7raYgkF3jYxQ6RqJB+yHa40Q91V/gQW22BOFVsfhGi+iyy5p+FTL3lDH vDAVRqvCKaRwto99fGprH8Tky6b9qbprZYh7l34ucTD0qrzHj8rnqGpaH+Jsuyzaposy bbK5/0FXA3geh7GQ/Z07aMtOjdMe8i8sW/4OV+f9QKTgiJj9K5R1KDNzqbdBY5piTruQ d2PHUOckTSSIYf8twGOFDGA9A2b3wKpi6MYJ4FuTuaah75cz33vaTYM4JghXMCDU0jAf Df1nqhsp8okwOegu2aOohnEkX2XvcTPa4o2coRd4Sb50CdRibd84zBDMyBnAB2Oq/LYG jOsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=NXwxmYeftYzF4jtqCiLrlUMOqQIXZv6xuhc1OQJvYiE=; b=kS7xlMiapj41JdyeZuGcJM6OkZnXH1eyddgygbW3fT7j9FHrrJHtrqZZiVcEEPeins spF0jGwbBKnPQjpP/+cX0vQZ/GVBeUPn6WG5BuXNh3tCTYl29ltgGxaWk9iapFyw9UTe iaEDWl4UvYuVknXiopk4wegWqVOyO9DU9qxJQjRU9H59ilhS1iipx/sKxSEl5Ar6P/d9 +Zr1bWbTF616Bela1ZoTec4pwH45XyuCGfSc11Wx5x3ypWIi9Fo7t6P4SMFDc4vvVEo4 lEqgci6ZWEVQMCHwKxqHHrI4mvrf44JN/BGVQvkLHV3WVgFOaq0sKWLoLVCjJOOvfAlr erwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HJgN16oo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x3-20020a170902ea8300b001b06fa86af9si302252plb.462.2023.05.30.05.04.18; Tue, 30 May 2023 05:04:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HJgN16oo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230362AbjE3LqK (ORCPT + 99 others); Tue, 30 May 2023 07:46:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231183AbjE3Lpz (ORCPT ); Tue, 30 May 2023 07:45:55 -0400 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44E5EE5A for ; Tue, 30 May 2023 04:45:23 -0700 (PDT) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-566586b180fso27572837b3.0 for ; Tue, 30 May 2023 04:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685447117; x=1688039117; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NXwxmYeftYzF4jtqCiLrlUMOqQIXZv6xuhc1OQJvYiE=; b=HJgN16ooshsHiGI4V9zZekl8WfBy0TCwlt4G4xj0wTN4T0V5SPWaECI89YjxMfYqZ7 5J0+lobIDDpFs8nyZLHxt5X02ikL160kPbWvnId/jSEED27yjhRfOJnfa3AQgIHRQ36s 8fptYF6EhjEtpUyBtKluUOw8En7dFNPlpOS0gCy6+CeFbSEhk+9gPlxPMEkU+HCFNXIq XUxlKnb0y0HRT2MknggVsoTrvukOAXFXoMV3sEJhWwBC7bApfAcCwwi1SrGcvdZ13Db0 Ys3OVcirp6azO7+heXcstqN7opBBGbNqbBg6GpzgkjWWaz7U/pcK6K4XfId0vSM6UbBx DB9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685447117; x=1688039117; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NXwxmYeftYzF4jtqCiLrlUMOqQIXZv6xuhc1OQJvYiE=; b=iS3eP+W1rK+DV+fZLhvcX0Rg/UsENWERAwL/YVGolUTn45N4+LWLMLqq2gAQT6/a7U xG1X8CryEqI/gD3nTLw4H/5Wf0qOniqhc+RjnP2oJGbBpUniT11c5q+XIP1VHcp88Rwq eihmEoBZw+V8h3LXBhW5osOjXIJvm54DeBszF8qylnu9Jzd8Ls9Edce4gC22BaTOSIbz 1TkS7yyIfTfglu6JX1ieuxkZkopa5J6kVfy95iSTxP6bLVDsbwVDxr2yFSjGngy/EBC+ 68QWkJbuOTkHnLfahR9077mzJl8rACrgYOCy2fiWHfqyDoL0gUzq6SEnKXSDOLYZYo+t c3ew== X-Gm-Message-State: AC+VfDw9+dxTDrZT9EyAenDVZYLnkU2kSSvb0vWbRx9aVpvwKPKnbD5Z qn9XVOakNXJ3xQAOa7VEeXWqzCkXl7y0UKacCy5wIQ== X-Received: by 2002:a81:5cc3:0:b0:562:7f3:bee6 with SMTP id q186-20020a815cc3000000b0056207f3bee6mr1880035ywb.45.1685447116862; Tue, 30 May 2023 04:45:16 -0700 (PDT) MIME-Version: 1.0 References: <20230527114057.36091-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230527114057.36091-1-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Tue, 30 May 2023 13:45:05 +0200 Message-ID: Subject: Re: [PATCH v1 1/2] gpiolib: Consolidate the allocated mask freeing APIs To: Andy Shevchenko Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 27, 2023 at 1:41=E2=80=AFPM Andy Shevchenko wrote: > There is a common API to allocate a mask, but more than one duplicative > counterparts. Consolidate the latter into a single common API beneath. > > Signed-off-by: Andy Shevchenko Microoptimization, but I'm game for this one because it has a good descriptive name making the code more readable. Reviewed-by: Linus Walleij Yours, Linus Walleij