Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <974c3ce3-5081-67d0-ae80-444e99e437e5@denx.de>
Date:   Tue, 30 May 2023 13:42:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 7/8] ARM: dts: stm32: adopt generic iio bindings for adc
 channels on dhcor-drc
To:     Alexandre TORGUE <alexandre.torgue@foss.st.com>,
        Olivier MOYSAN <olivier.moysan@foss.st.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc:     kernel@dh-electronics.com, devicetree@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230524133918.1439516-1-olivier.moysan@foss.st.com>
 <20230524133918.1439516-8-olivier.moysan@foss.st.com>
 <cc7a0a1a-31bb-92f4-6365-5e0c4a4bc85c@denx.de>
 <5bb496d0-6dc1-6ba3-6126-6429037ecf5a@foss.st.com>
 <8a4f3112-54ed-e0c1-52ee-395a41255163@foss.st.com>
Content-Language: en-US
From:   Marek Vasut <marex@denx.de>
In-Reply-To: <8a4f3112-54ed-e0c1-52ee-395a41255163@foss.st.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/30/23 09:59, Alexandre TORGUE wrote:
> Marek, Olivier
> 
> On 5/24/23 17:39, Olivier MOYSAN wrote:
>> Hi Marek,
>>
>> On 5/24/23 15:54, Marek Vasut wrote:
>>> On 5/24/23 15:39, Olivier Moysan wrote:
>>>> Use STM32 ADC generic bindings instead of legacy bindings on
>>>> DHCOR DRC Compact board.
>>>>
>>>> The STM32 ADC specific binding to declare channels has been deprecated,
>>>> hence adopt the generic IIO channels bindings, instead.
>>>> The STM32MP151 device tree now exposes internal channels using the
>>>> generic binding. This makes the change mandatory here to avoid a mixed
>>>> use of legacy and generic binding, which is not supported by the 
>>>> driver.
>>>>
>>>> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
>>>> ---
>>>>   .../dts/stm32mp15xx-dhcor-drc-compact.dtsi    | 28 
>>>> ++++++++++++++++---
>>>>   1 file changed, 24 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi 
>>>> b/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
>>>> index 39af79dc654c..92d906bfd5d7 100644
>>>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
>>>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-drc-compact.dtsi
>>>> @@ -57,15 +57,35 @@ &adc {    /* X11 ADC inputs */
>>>>       status = "okay";
>>>>       adc1: adc@0 {
>>>
>>>
>>> I sent similar patch recently too:
>>>
>>> [PATCH] ARM: dts: stm32: Update to generic ADC channel binding on 
>>> DHSOM systems
>>>
>>> But I needed to add #address-cells/#size-cells here and to adc@100, 
>>> otherwise DTB checker was complaining . Did you run DTB check and was 
>>> it OK on your side ?
>>
>> The first patch in this serie adds the #address-cells/#size-cells to 
>> the   SoC DT. So, there is no need to add them later in the board DT.
>>
>> I can send a v2 with your patch (after removing the cells properties 
>> from the patch). Having all the patches in the same serie, will help 
>> avoiding sequencing problems.
>>
>> Do you agree with this ?
> 
> What is the status of this patch ?
> 
> Marek, I would prefer to take all ADC updates in this series if you agree.

I missed the reply from Olivier, sorry. Please pick the whole thing.