Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 20:08:31 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     "Yang, Weijiang" <weijiang.yang@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
        <rppt@kernel.org>, <binbin.wu@linux.intel.com>,
        <rick.p.edgecombe@intel.com>, <john.allen@amd.com>,
        Zhang Yi Z <yi.z.zhang@linux.intel.com>
Subject: Re: [PATCH v3 07/21] KVM:x86: Refresh CPUID on write to guest
 MSR_IA32_XSS
Message-ID: <ZHXnP5bEvxPrDg3m@chao-email>
References: <20230511040857.6094-1-weijiang.yang@intel.com>
 <20230511040857.6094-8-weijiang.yang@intel.com>
 <ZG77wu4PyBn1z587@chao-email>
 <23169e5f-9793-9486-fd5f-287e3317b837@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <23169e5f-9793-9486-fd5f-287e3317b837@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Hp3vWte5yvpXSRCBdB119r1hOGuiXz0+M3L8wX67UEQtJvTgIi+KjquwfYz+?=
 =?us-ascii?Q?DDtBckgVxiPldJSZyAeBBcywpDoBaon4zYMWBgBsJSwHP6nzE2VZGZtVpiby?=
 =?us-ascii?Q?/3SSMVt4b0V9BycLYkTItPKzsxZj5ivXBPWC5YpSPwdmNXyhC1w35eOheM5p?=
 =?us-ascii?Q?Qfkv1IJZ5RumBXhBaHwnEL2gqAy+DJyqDSBHvIU0r2hDUK/X8fidRZkfIeCx?=
 =?us-ascii?Q?ljNndLGDMcWIw0415WKopAq2XX5eCK0ToPYE4i+9uS6STvoKujyt0eKe61rD?=
 =?us-ascii?Q?KjPpZ/NRlwdTYP7QCmB9t5dwOlKBoQ4sceARfYR8cwFmrzo4VCN4Y9+vaxCP?=
 =?us-ascii?Q?8XFTrn8S0K5z8RNeKC8BOPlOinnXPi8ltsUkXV0s670T07yX3mzPBsmeyd8G?=
 =?us-ascii?Q?pnJ9O+wgo43pgwL2uUL08mhycyN7nQViIP9omGyQXczhI0eFg8R/BzYslrG1?=
 =?us-ascii?Q?qeWmaBhkTT7Cz6vkWsKVF/L0YuhBCyvoU489GAHncpn+GWl2jFhLdmiUNvIT?=
 =?us-ascii?Q?Jcpcd9YowInypQOpYcFlUfAN+O5F+5Y94ox7dNXBaZQ3RHTQuqhH7RU55lW4?=
 =?us-ascii?Q?BtpdbE/WV62TkZNBgM/emC3/ry4fkJb3dmiBXL8r8e+tEzyDJJLr1z5cZ8s0?=
 =?us-ascii?Q?K9auHY2JiSxDMXWkGg38RSjy24VnVM7g1t1GFC3zNhNv1lJtdCAToK7oGkGP?=
 =?us-ascii?Q?A7SFbwz+20w/TU7RPUkXM7w0LO+Ri4GK+DL49LvsQw/N9u6a+TLLT3dxPdzL?=
 =?us-ascii?Q?NxpoRpEZfWX7DMRRG0/lsFWAAlbLGP4i0Cw43YMWCk0giNsG541QmkAI+Y2R?=
 =?us-ascii?Q?v2cB7Kr6dnCnFSC7iPhEQegWct35oCYlq+3QfsOuZmNG/Ayt+vxq1LEqFSuE?=
 =?us-ascii?Q?nvM0juaJbVtkngZG4EuyyC5t4zIPnkVrGdjl66RJqrQxbgTnanm8B1ssxgba?=
 =?us-ascii?Q?TiVI8RN56Lv0q5lpxCfxRoE3Qcr94RHVwGpTjstG9FtwEeAsNjqiGDhIp9vZ?=
 =?us-ascii?Q?pHrqynCGil4+bUdBfATzRJTYk5visn7Z1iTsnkWQO33Op5fKNGxLE2zDFqZh?=
 =?us-ascii?Q?mWAnJdH0aYDTUEv/lWyzqO9MG+BntSWIFAbUf+sPFMvsacDKTDfKijKeUjM/?=
 =?us-ascii?Q?RnE/cnYjnMTVZ3o62WdHk4tXH6LPUaa4/QsyprIUfslaGT+ccyA3I5IQinqE?=
 =?us-ascii?Q?aVyUSyAz5XrG6KGkam1g9XJxZSU8QoFssQB9f/iASpsN4Z1sAtjDKjFR4n/G?=
 =?us-ascii?Q?lraI90VlLc4tI6422iDW2rwJfwkdsj0VGgjO+YOcjJOCVw1DlONdLhfcUdru?=
 =?us-ascii?Q?j1d6//cbMISvCbiZQydGl9zg/K/rSlIbc8EF4hAJKoSbIc18pYor234fKUnH?=
 =?us-ascii?Q?hhUpBrvs+zywr8kHVmgD6yJDQwMsy4Gz/QknVTPZ855KWcNs3rQh43PKWrF2?=
 =?us-ascii?Q?zpTIJOnE9gG4sH5Z52DLttKGybPw53GvnaP9iARZdaZIJNrQCwiN8fjOKfoz?=
 =?us-ascii?Q?wXR8ui2BqQtY3oCfEx2IsADRKHlBZbufqDtOe4RoLdLy0fC42aJ4qvn/8NjP?=
 =?us-ascii?Q?D1WbR+HMhk5K9pgOJUlDmRRubKNkbo7vwYdG3XiF?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 818074d5-a39b-4344-8b6a-08db61069cd7
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 12:08:43.4431
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LtdqMT9Ggsw3roQEh3jcMxWnLeC1TiZMhv0RSi42U97kf604PTbkpvD7G5NcTvHkhpJK6kt66xGe161UdL9eKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6962
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> > --- a/arch/x86/kvm/x86.c
>> > +++ b/arch/x86/kvm/x86.c
>> > @@ -3776,8 +3776,10 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>> > 		 */
>> > 		if (data & ~kvm_caps.supported_xss)
>> Shouldn't we check against the supported value of _this_ guest? similar to
>> guest_supported_xcr0.
>
>I don't think it requires an extra variable to serve per guest purpose.
>
>For guest XSS settings, now we don't add extra constraints like XCR0, thus

QEMU can impose constraints by configuring guest CPUID.0xd.1 to indicate
certain supervisor state components cannot be managed by XSAVES, even
though KVM supports them. IOW, guests may differ in the supported values
for the IA32_XSS MSR.