Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4308327f-d2e2-e9a2-6add-5e0352d3f1e2@foss.st.com>
Date:   Tue, 30 May 2023 14:08:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 02/11] pinctrl: stm32: add stm32mp257 pinctrl support
Content-Language: en-US
To:     Conor Dooley <conor.dooley@microchip.com>
CC:     Conor Dooley <conor@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Olof Johansson <olof@lixom.net>, <soc@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
References: <20230529162034.20481-1-alexandre.torgue@foss.st.com>
 <20230529162034.20481-3-alexandre.torgue@foss.st.com>
 <20230529-enrich-clammy-14b498baf09f@spud>
 <879b7689-5663-28b5-9431-2fdd243ffff2@foss.st.com>
 <20230530-payday-gravity-45a26bd7f2dc@wendy>
From:   Alexandre TORGUE <alexandre.torgue@foss.st.com>
In-Reply-To: <20230530-payday-gravity-45a26bd7f2dc@wendy>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/30/23 10:56, Conor Dooley wrote:
> On Tue, May 30, 2023 at 10:38:30AM +0200, Alexandre TORGUE wrote:
>> Hi Conor
>>
>> On 5/29/23 20:04, Conor Dooley wrote:
>>> On Mon, May 29, 2023 at 06:20:25PM +0200, Alexandre Torgue wrote:
>>>> Add stm32mp257 pinctrl support.
>>>> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.h b/drivers/pinctrl/stm32/pinctrl-stm32.h
>>>> index e0c31c4c8bca..5e5de92ddd58 100644
>>>> --- a/drivers/pinctrl/stm32/pinctrl-stm32.h
>>>> +++ b/drivers/pinctrl/stm32/pinctrl-stm32.h
>>>> @@ -24,6 +24,9 @@
>>>>    #define STM32MP_PKG_AB		BIT(1)
>>>>    #define STM32MP_PKG_AC		BIT(2)
>>>>    #define STM32MP_PKG_AD		BIT(3)
>>>> +#define STM32MP_PKG_AI		BIT(8)
>>>> +#define STM32MP_PKG_AK		BIT(10)
>>>> +#define STM32MP_PKG_AL		BIT(11)
>>>
>>> Mainly out of curiosity, why have you go duplicate defines for these?
>>
>> Mainly to fit with available packages for various STM32 MPU. Currently MP1
>> SoCs are available with packages AB/AC/AD and MP2 series with AI/AK/AL but
>> in the future we could have package AB/AC/AD/AI available for a particular
>> SoC and then I need to anticipate this case.
> 
> Sorry, what I meant was "why have you got defines for these in this
> header, when there is an existing set in
> include/dt-bindings/pinctrl/stm32-pinfunc.h?".

Ok, I see. To be honest I do it as we did in the past for STM32 MCU and 
MP1 products. We had this discussion maybe 5 or 6 years ago about the 
fact to include or not the "dt-bindings" file in the stm32 drivers. I 
don't remember exactly the rational behind our choice. It is something 
that we could improve for all our STM32 products. Sorry for this 
imprecise answer.

Alex


> 
> Cheers,
> Conor.
>