Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 13:16:32 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@orcam.me.uk>
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
cc:     Paul Cercueil <paul@crapouillou.net>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        linux-kernel@vger.kernel.org,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH 1/2] MIPS: Allow MIPS32R2 kernel to run on P5600 and
 M5150
In-Reply-To: <BCECE3BF-7A4D-43BF-8AA8-2232D974CD71@flygoat.com>
Message-ID: <alpine.DEB.2.21.2305301315120.42601@angie.orcam.me.uk>
References: <20230529135245.4085-1-jiaxun.yang@flygoat.com> <alpine.DEB.2.21.2305300321520.25569@angie.orcam.me.uk> <684C1A48-C743-4045-AF12-B0846FCE8EBE@flygoat.com> <alpine.DEB.2.21.2305301152080.42601@angie.orcam.me.uk>
 <BCECE3BF-7A4D-43BF-8AA8-2232D974CD71@flygoat.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, 30 May 2023, Jiaxun Yang wrote:

> > Sure, but this change is not needed for it.  You just need to declare 
> > which ISA revisions your platform supports and leave `__get_cpu_type' 
> > alone.  It has worked like that for a decade now.
> 
> I’m afraid it won’t work as you expected.
> 
> Actually I ran into a problem that `case CPU_P5600` in c-r4k.c is optimised out
> by compiler, because the codepath is marked as unreachable.

 Maybe there's a bug elsewhere then.  Send me your .config and I'll try to 
reproduce it.

  Maciej