Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Marc Zyngier <maz@kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Zheng Wang <zyytlz.wz@163.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M
 {modprobe,bind} error
Thread-Topic: [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M
 {modprobe,bind} error
Thread-Index: AQHZj99wvrGBFYOn5Ea9mIuOTwGccK9wyqwAgAAi9sCAAAmpAIAABFqAgAF9FPA=
Date:   Tue, 30 May 2023 12:37:30 +0000
Message-ID: <OS0PR01MB59227AF1F83A73620179CDF8864B9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20230526143615.372338-1-biju.das.jz@bp.renesas.com>
        <20230529061714.GA25984@pendragon.ideasonboard.com>
        <OS0PR01MB592296756992262EC6D382D0864A9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
        <20230529085656.GL25984@pendragon.ideasonboard.com>
 <86a5xncxhc.wl-maz@kernel.org>
In-Reply-To: <86a5xncxhc.wl-maz@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B3Vg3xpriwtLXO2amJvb7Fk28jaL8ge/Fc32m3hcvvvMEhizH8pXmDFF1zFe?=
 =?us-ascii?Q?JjaRvfTxYTvn+IANJSTg92FaPpvaixMH7IkTj49GLBz2k1i7fPA8dENedMi+?=
 =?us-ascii?Q?k3fSaHXPr91jHdZXb+9Qxz9r0nXF43hhOMzf8DOPU880LyVZiZ3LiIYVemeP?=
 =?us-ascii?Q?h4SkiIbGMubsop6zVezEPhowdapW5KtGZUgDW4eSSYESlxpLPrKlzA7bJrDv?=
 =?us-ascii?Q?fh/4pY+QEAhbO2SfcKsynhHGJGIvo3sPWtsIkRAUJELQ4tDVkDQV1mucOkQG?=
 =?us-ascii?Q?O3VjDU2DzCm3UR9uCtDjWbk8tbnpjDYiGGCr7flXNLQc7yqXdpMZSvAW/SIC?=
 =?us-ascii?Q?pbVKMhWY4EPIW6PhfJOTwY41M8+QydE9vU2bal1DhtTwyMbJIP56hBvexYX5?=
 =?us-ascii?Q?dlR4eE1Dmp1WVXQ+dGY910J97Y33PY/CmuMRAReuna1aR1Ty2JiGHMiHR9Ja?=
 =?us-ascii?Q?qV87jwNDWy27opAe2Miiony911r5NI1mqaf0Rz2JPXV1HXwiQTxKT6hA26nn?=
 =?us-ascii?Q?sG9LZQasJ6fH5ykiH1dVsf4Hv+iGoS7nA1iDu0ycJ5jd+MhooY3zi2b6xXB/?=
 =?us-ascii?Q?YkkPINk2K9rNnQzImpHVah5yl5WC/mr/4yxr0rHHyHIC5N47sDJbVaUVqNN/?=
 =?us-ascii?Q?3GFVGB1jG6Uy+b153bIDZ4/SVAp/MxBM7QXI1liOadS/kqOpv5eVxohlXWv8?=
 =?us-ascii?Q?76iOheiDDxRLFl0vRzTgdIPhgw8w4zUr2PqKpnS9IlkKvrrjOKjcF2mgCrRd?=
 =?us-ascii?Q?M7QhDvEzVJyBCdzLzGJwYRyx3HwbVi2WVVaEkl8gDKq6l3hyMHtzoTZTt84v?=
 =?us-ascii?Q?JUo5u2qaUt0+/fbc1V5peCTQ7aOGNfJNF5bVOzvVUlbzKoB68BbGUSVdwHgI?=
 =?us-ascii?Q?ka3GWZ5ds9SBAFL9QscBrF6qCpoqXSmlVbfmxtRXYVZTbEfxn7bnY7mWDNlq?=
 =?us-ascii?Q?wME/lcWR5dlLDFK+ut0nG4VT2qvL6tBPTkBWxyQR61fLwNK7mYQF30TJKDGU?=
 =?us-ascii?Q?7HOXkQwDJTWh/FRMG9xIZiVip/Ff8hh30uHtFoBdgue1ARbzzlCuzS0uiSWo?=
 =?us-ascii?Q?t/A3Im1wtSZprzXLibaVhiSCpHC/CXxQkUuqgMLn/1DSOUMGmHj+5n0xrkC3?=
 =?us-ascii?Q?vmrwKJPydVOcoulQBK/BwQuBfj8P4ylRzfFoaoWKLOmydI3+od0G3C2fCqY0?=
 =?us-ascii?Q?OqMRFAcC5PecC8Hb9P1nxi3iU0vBfR106tZ6ib8mbXJ7FDBfPE5Y3uX4B2YF?=
 =?us-ascii?Q?gpg/n0GcA/BpmOzgVchQamDXj7Vr1/b2XfVe2a/egV2qkdgsvUo/pg6mci+D?=
 =?us-ascii?Q?3R1TAQYy3xc5kR/cZr9Tr7PcGxP8TnXlrOEmGFxDFnH568DrJM00ofeAtGd2?=
 =?us-ascii?Q?9nC/xPQLU983oM4WgeYLxhpiWakAm3HQE+ylwELcY+YfFbJnG58l3n42BhBV?=
 =?us-ascii?Q?JeQwrahSGQjOw21YdpGorArawBaKbIVBWKY6bIFcuK8ZgOuJnqh63JC5SfMe?=
 =?us-ascii?Q?Rju8NZkELZUNPIQJsrXkQVUVzwimw9D9zVcY/PyOgH/jtOC6OY/T0eEYrbsN?=
 =?us-ascii?Q?pkSBB1tMPK8PDWMJ0eacwPdtYPf1Z7v4XrOOArf4Ot2prqXVsnyilAqqw/TI?=
 =?us-ascii?Q?gA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9016c0d9-5841-473f-d783-08db610aa25b
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2023 12:37:30.3995
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NYmU0zpxdoKUifIp49UeDEBKce0Qkk9uO7a/gZK1HoWAttS8NG5PXKqLHjxVpKYq/+b9prpB5IYPfT7G1c/lSBm+F3qqOxa+methg4H2ryo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB9665
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Laurent and Marc,

Thanks for your feedback.

> Subject: Re: [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M
> {modprobe,bind} error
>=20
> On Mon, 29 May 2023 09:56:56 +0100,
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> >
> > The name is just informative so I suppose it's ok. It makes me wonder,
> > though, if the usb3drd driver shouldn't register the interrupt handler
> > itself.
>=20
> Well, it registers it itself, but pretending to be another device.
> Which is wrong on many levels.

OK, Will register the handler in usb3drd driver and expose register/unregis=
ter handler API
with cb function to avoid duplication of the code with renesas_usb3 driver.

Basically, there will be 2 exported functions + 1 spinlock introduced in us=
b3drd driver

USB3DRD driver register the IRQ handler

Probe/remove from renesas_usb3 driver register/unregister the cb function. =
Whenever there is drd irq
cb function will be called.

I will send next version with these changes.

Cheers,
Biju