Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 16:33:48 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     "Maciej W. Rozycki" <macro@orcam.me.uk>,
        Paul Cercueil <paul@crapouillou.net>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
        linux-kernel@vger.kernel.org,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH 1/2] MIPS: Allow MIPS32R2 kernel to run on P5600 and M5150
Message-ID: <20230530133348.2jsrbkh6kixonwbm@mobilestation>
References: <20230529135245.4085-1-jiaxun.yang@flygoat.com>
 <alpine.DEB.2.21.2305300321520.25569@angie.orcam.me.uk>
 <684C1A48-C743-4045-AF12-B0846FCE8EBE@flygoat.com>
 <alpine.DEB.2.21.2305301152080.42601@angie.orcam.me.uk>
 <BCECE3BF-7A4D-43BF-8AA8-2232D974CD71@flygoat.com>
 <alpine.DEB.2.21.2305301315120.42601@angie.orcam.me.uk>
 <5CC33034-4AF3-4522-9942-8BCCEF1086AE@flygoat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5CC33034-4AF3-4522-9942-8BCCEF1086AE@flygoat.com>
Precedence: bulk

On Tue, May 30, 2023 at 02:10:04PM +0100, Jiaxun Yang wrote:
> 
> 
> > 2023年5月30日 13:16，Maciej W. Rozycki <macro@orcam.me.uk> 写道：
> > 
> > On Tue, 30 May 2023, Jiaxun Yang wrote:
> > 
> >>> Sure, but this change is not needed for it.  You just need to declare 
> >>> which ISA revisions your platform supports and leave `__get_cpu_type' 
> >>> alone.  It has worked like that for a decade now.
> >> 
> >> I’m afraid it won’t work as you expected.
> >> 
> >> Actually I ran into a problem that `case CPU_P5600` in c-r4k.c is optimised out
> >> by compiler, because the codepath is marked as unreachable.
> > 
> > Maybe there's a bug elsewhere then.  Send me your .config and I'll try to 
> > reproduce it.
> 

> Ok I see the problem, after applying patch 2 the issue is gone.
> So actually only patch 2 is necessary.
> 
> The unreachable mark here leads gcc to generate some confusing code
> and I misread it.
> 
> Sorry for the noise.

Great! Indeed enabling the SYS_HAS_CPU_MIPS32_R5 config is enough to
stop the CPU_P5600 being optimized out. Thanks for your work. Let me
know if you need some tests on another instance of the P5600 hw.

-Serge(y)

> 
> Thanks
> - Jiaxun
> 
> > 
> >  Maciej
>