Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 16:47:31 +0200
From:   Lukasz Majewski <lukma@denx.de>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC] net: dsa: slave: Advertise correct EEE capabilities at
 slave PHY setup
Message-ID: <20230530164731.0b711649@wsk>
In-Reply-To: <35546c34-17a6-4295-b263-3f2a97d53b94@lunn.ch>
References: <20230530122621.2142192-1-lukma@denx.de>
        <ZHXzTBOtlPKqNfLw@shell.armlinux.org.uk>
        <20230530160743.2c93a388@wsk>
        <ZHYGv7zcJd/Ad4hH@shell.armlinux.org.uk>
        <35546c34-17a6-4295-b263-3f2a97d53b94@lunn.ch>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/l7qCvXq/FTQDT3bLEkM2sDq";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/l7qCvXq/FTQDT3bLEkM2sDq
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Andrew,

> > So, I'm wondering what's actually going on here... can you give
> > any more details about the hardware setup? =20
>=20
> And what switch it actually is.

It is mv88e6071.

> I've not looked in too much detail,
> but i think different switch families have different EEE capabilities.

Yes, some (like b53) have the ability to disable EEE in the HW.

The above one from Marvell seems to have EEE always enabled (in silicon)
and the only possibility is to not advertise it [*].

> But in general, as Russell pointed out, there is no MAC support for
> EEE in the mv88e6xxx driver.

I may be wrong, but aren't we accessing this switch PHYs via c45 ?
(MDIO_MMD_PCS devices and e.g. MDIO_PCS_EEE_ABLE registers)?

>=20
>     Andrew


[*] - maybe it is possible via some "reserved" registers. However,
there are "register pages" for EEE, which allow tuning timers.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/l7qCvXq/FTQDT3bLEkM2sDq
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmR2DIMACgkQAR8vZIA0
zr3AjAgAtbAzj9ESVpzSo3QNSuO9KOphrBagbND3PolryZptPV6XhIg2jqxqLM+q
zN4Di8DnRtkQ2CuD9pVUd2iACa+CKQy6Q/tOhAWdi1XH13+Iblovy4w/hSBDoOgu
uXdGc+ps4cnmfPI60/9CT6BtbXNDwWM4egt9F9WqOA4PHR3CPurUfzd16U76Qtyn
r3XkhYx3R1TuJQ3SMhWu4l9d/XAxO6f1HwqeRdmN6r8ylqReaQ9+m/BlKtlRMKjG
ID3DhH0BJOmjr8WTe33PeJPzFDiqbt0GA80ycU7TRSjgNLNzUyy2JcGQ2QWZ9Y0B
yYQuE4NB02vYFLeHdENRCTG9Pw/5mg==
=JV1w
-----END PGP SIGNATURE-----

--Sig_/l7qCvXq/FTQDT3bLEkM2sDq--