Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4651671rwd; Tue, 30 May 2023 08:08:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70x664bJE+klUS29EV3wtssnqJCykaIE3pl2ifH3rRtsG74ox/+SWRYMRiPzWp284jP4YI X-Received: by 2002:a05:6a00:cc5:b0:645:d02d:9a83 with SMTP id b5-20020a056a000cc500b00645d02d9a83mr3349119pfv.17.1685459319250; Tue, 30 May 2023 08:08:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685459319; cv=none; d=google.com; s=arc-20160816; b=feut8IFZxTEBPLLwyUEU88hnt1ex2fDwkgPnvmxMl12kRPX4f2uDTF+HM/OOne//Fs F8eYkB+WaI2TTTifoQv9vZubuCqqBqLkZAoCXLHIZsdz5fSVU9xqWexGWuL6plKTCxJJ u4RftxhILGE7jtmjKeHfto/E5Fms6YL9ldQrJLsDPIFdmygCeQ+LKRgstLiwDLzWCxoF 9oYz2yDjMHOkANVV5UgX16pn8o0UN84q+PQtl5cjakBRUiquNT+zm3NE75NDzUI0IIKq yI2DX9fjmUkntFzpR1X+TqEeTH3PuzfRWYGr1fKNeDxL8HmuTIAy+RV7unG49z5Wf4WB Sv7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=FP27oe6YRkTmUSFag2bWsNftLiVcxV5TwwZBiMn8rPI=; b=bRPPH2N0xRRsK4fBHY38lF0YdQSXoTZrf4HH5zssKXy+jzFNsyyxusLTh89po61TGc IKw3IjNZR83jx4QioRJ6YYFGCPcYXVba+QcjWxY5Bj2ONFtYkDHRpNc2LgVRSXBMEh03 XHO6TdsyL3JTNZrk0aTiJkYH/FWYdjwlHkNRtWnLsY7MQlsurWsU9pSwvv6JlicgRT1K oGk1evKwA0CKSEjny0FYFHcxoPZLNn2wx+77SQsZ8DBA6S0uxjfaQf3cFy/QajXQ9UTN bqft3PMGhCsnQB5zp4mWnmBUOIPE38HgJpKddY8ZUJOLxGIWMVLsgoDsCp3+t8kBHHyt ugHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=BbZp328Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w191-20020a6382c8000000b0053fb7d0fa78si1163015pgd.812.2023.05.30.08.08.22; Tue, 30 May 2023 08:08:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=BbZp328Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231952AbjE3OyE (ORCPT + 99 others); Tue, 30 May 2023 10:54:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230261AbjE3OyC (ORCPT ); Tue, 30 May 2023 10:54:02 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 838A28F; Tue, 30 May 2023 07:54:01 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f623adec61so47876155e9.0; Tue, 30 May 2023 07:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685458440; x=1688050440; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FP27oe6YRkTmUSFag2bWsNftLiVcxV5TwwZBiMn8rPI=; b=BbZp328QYvFDMdyEBRjOtAnaOclV0kL0oOPIlL8WdPHLXQWlTjdM0IR/FuFx3AVfdG mzib27Q5zSjiZuXTMAtbmQziNuPPYV+Pz3I7vfcrm2n3qf3ZRGTFwubNUgx+vm+dPnrL 0gAT1msaREHYNqQPBnTifKYkDWi6qggkgvWfELNvDhlXtJK3k1rvO28MpTVePfRTqJmU knNwGTN0JmG3TNL6LCVySqm/4X04Op+cKfk9YY0kmcSDponkEgvtJZQMPlpDmmvk0kpR 3IiNs6jkLONPjaycgU8JmiWHDm7GTweNL8OtZNZOhdlE1V+y9egLPNOjk6WvtVGkudmH wKRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685458440; x=1688050440; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FP27oe6YRkTmUSFag2bWsNftLiVcxV5TwwZBiMn8rPI=; b=ZUhssjudF6P4PYMLj8gCAQdYiAlgxqJu8HJ4dYwQvjrecK3yapBMfwqbgbK12VXCud plZT2ShG2W+nW4NeuV8YL+vSYCLzD7o0DldhXYLWBX2+D7cs68YRExPwyyBAeStbQYlu /FKsNbptyopkKuF9SIjdyK3Prp+GVHpdHnozQf7y23cDB1hrBI/Wav+Blp9gNvSEEhyW ABVLFGn/rNZUjq23IdM4v557ZXVpdcOD5GskeBQcpgB0/z53UeiH740XNdIdBvMobyUQ 2vcRHkx2oHwXshyZDpNvmpPxWQuTu6NBmB9kRawAiK4J2Si1oM1NjjiF+1db8juKYmfU kVKA== X-Gm-Message-State: AC+VfDzzqnPMb3aqm0H2Qaa+E+edO7/jwJqEnTa/K2kGQnDlYUswCUlt v90lDaYzSMq5OtGeC2U5yZG0V9IA03g= X-Received: by 2002:a05:600c:2290:b0:3f6:89a:94c8 with SMTP id 16-20020a05600c229000b003f6089a94c8mr2032423wmf.24.1685458439652; Tue, 30 May 2023 07:53:59 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:4a02:2aff:fe07:1efc]) by smtp.googlemail.com with ESMTPSA id x21-20020a05600c21d500b003f6041f5a6csm17709352wmj.12.2023.05.30.07.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 07:53:59 -0700 (PDT) Date: Tue, 30 May 2023 16:53:56 +0200 From: Corentin Labbe To: linux@roeck-us.net, jdelvare@suse.com Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFT] hwmon: (nct6755) Add support for NCT6799D Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello I have tested your patch against a 6.3.4: sensors nct6799-isa-0290 Adapter: ISA adapter in0: 832.00 mV (min = +0.00 V, max = +1.74 V) in1: 1000.00 mV (min = +0.00 V, max = +0.00 V) ALARM in2: 3.38 V (min = +0.00 V, max = +0.00 V) ALARM in3: 3.34 V (min = +0.00 V, max = +0.00 V) ALARM in4: 1.02 V (min = +0.00 V, max = +0.00 V) ALARM in5: 1.04 V (min = +0.00 V, max = +0.00 V) ALARM in6: 760.00 mV (min = +0.00 V, max = +0.00 V) ALARM in7: 3.38 V (min = +0.00 V, max = +0.00 V) ALARM in8: 3.30 V (min = +0.00 V, max = +0.00 V) ALARM in9: 1.67 V (min = +0.00 V, max = +0.00 V) ALARM in10: 560.00 mV (min = +0.00 V, max = +0.00 V) ALARM in11: 552.00 mV (min = +0.00 V, max = +0.00 V) ALARM in12: 1.04 V (min = +0.00 V, max = +0.00 V) ALARM in13: 480.00 mV (min = +0.00 V, max = +0.00 V) ALARM in14: 408.00 mV (min = +0.00 V, max = +0.00 V) ALARM fan1: 808 RPM (min = 0 RPM) fan2: 589 RPM (min = 0 RPM) fan3: 0 RPM (min = 0 RPM) fan4: 809 RPM (min = 0 RPM) fan5: 510 RPM (min = 0 RPM) fan7: 0 RPM (min = 0 RPM) SYSTIN: +33.0?C (high = +80.0?C, hyst = +75.0?C) sensor = thermistor CPUTIN: +38.0?C (high = +80.0?C, hyst = +75.0?C) sensor = thermistor AUXTIN0: +39.5?C sensor = thermistor AUXTIN1: +19.0?C sensor = thermistor AUXTIN2: +20.0?C sensor = thermistor AUXTIN3: +73.0?C sensor = thermistor PECI Agent 0 Calibration: +41.5?C PCH_CHIP_CPU_MAX_TEMP: +0.0?C PCH_CHIP_TEMP: +0.0?C PCH_CPU_TEMP: +0.0?C TSI0_TEMP: +52.4?C intrusion0: ALARM intrusion1: ALARM beep_enable: disabled Part of dmesg: [16453.196174] nct6775: Found NCT6799D or compatible chip at 0x2e:0x290 So you could add: Tested-by: Corentin Labbe Thanks