Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 17:11:00 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
        platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating
 entries to gpio tables
Message-ID: <20230530171100.75e5b86c@md1za8fc.ad001.siemens.net>
In-Reply-To: <ZHHFMPEYNz9jBBRd@smile.fi.intel.com>
References: <20230524124628.32295-1-henning.schild@siemens.com>
        <20230524124628.32295-2-henning.schild@siemens.com>
        <ZHHFMPEYNz9jBBRd@smile.fi.intel.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TVg8pPzogruTFM14+q1G2KB96YBm2EBTJ3iYuFzyu7ENMN8B0EHRr+CQgiXX?=
 =?us-ascii?Q?7bc6Q8B4bnXWn8dwt4emVa0i38qLACbkkHOqdIKwO5W7Qb90ReLKnU/erbPx?=
 =?us-ascii?Q?brHHwR634s9ryqOD0g0B5m8hjEje5NMvJupX4+NUFTFjEFi7DML7sCabQ/f9?=
 =?us-ascii?Q?Dt/JtcV30c/uH9LAF3IbQGTbYodF0jfulWTwVDsTpDJy/9eKLDwN56MmGkAs?=
 =?us-ascii?Q?IGIh8Ugfi07+GbJUF+Ebj05UAvEPs9U2giIj0d9f0GeghvYGpbkhe4sJ1Qs6?=
 =?us-ascii?Q?XxmAwXYC51/Kwsy2RBU130Vv4ryMW56eJy66+FWVTttf/as/CzDb3+X8TjVf?=
 =?us-ascii?Q?sx1QT7bQ2e7p14QxoGSCHZ3U5rbliYCAoJ8iyasa3xfbi1+V6nH5Dv5dc30V?=
 =?us-ascii?Q?MOG4JtqoDO+gMwscvO2BJ4TGHumRyyaVVBwaojeJ7TVykSG8ABbCmCmUKu1+?=
 =?us-ascii?Q?AGS6wGaJP9zYeZQlCHp5e3clYKzs/ajsmqefKsW78RNcrXDdcrsZXqbdWXYu?=
 =?us-ascii?Q?dZFNoxU2xalPM9gUsix4lh+9wurH5+DRHHmDlQJ9eem3YL4rDXasi2mWHyRA?=
 =?us-ascii?Q?MPriIJCiJgMw0/a+wnmyofz3xycjOauDj7mrwn9jbKzaOAa23zWIW3yqlDRc?=
 =?us-ascii?Q?oD4mKBgVXUuEHeG4zcmZMqXNt0+KxxkQrWANxi01oW/dq90xt6NUQCIaUJPb?=
 =?us-ascii?Q?aknyfschXDrw+Z+XYB31Q5sMRaXDNSdqxs/Qxga8eKIHdp7iGjuRefBHbBvE?=
 =?us-ascii?Q?NukKWWHOn1uJQOJl0Pn7NI+uCY6xTZ5W7Y6N+/FoijGWNBsgUZpQebtolPvC?=
 =?us-ascii?Q?9JMKfB1MbjMRSIwez9fJq27rZx6sM52nSaYhtCfdfGK1u5WqGidAjjoUOQWT?=
 =?us-ascii?Q?wL7EqXicci1O9Iq3CLOujd5OlLk/O/6HQpcnliaxpNfQg/00ni68bH+pLglt?=
 =?us-ascii?Q?zMdWK9p3rFyZDfIJfiJAZIEU4MQIe8F9dMlwcxoOq+62CaFUhvcXkUOvW1Ua?=
 =?us-ascii?Q?h1FrkvNDHqlxwZHhg+7YLWdFzqyj352Lcn3+LeSIaHsMe5ylD5I99vlrFwHQ?=
 =?us-ascii?Q?LnvftoePtCxGOmnKeB/6AgiRXDNzyDvFbopv60Z95Tl1gZ+D2KY8K5DaLkdN?=
 =?us-ascii?Q?4KAwMwaH4ljwGTJGA+hS5OWfJSJi+mDu+5lfNoz8vhlQz1tv8aCfwaKWAlZF?=
 =?us-ascii?Q?E7/kwY8g6TSfKpDcpEDEAtVQG4RVRfTbPGanqFh0Q2KtVQW+pMYUGjTS3IJd?=
 =?us-ascii?Q?iqmALwRhxOr0wBD/BN+KfvM26imklOzE/QR0PHxz4y4c6FsofO0ukIeNvmyC?=
 =?us-ascii?Q?AHarlYsgCQwfhtEZawNGFkwoGdadEh8O5Gzi7swtyRsfCN+7HRT4AdEGKWdH?=
 =?us-ascii?Q?7j8Sljw5/hfcu6bAhoqc68GhJIClcjjZjXJLzdd0fkFsnWiN+kBGYW1Pmtd+?=
 =?us-ascii?Q?4A81a3hHgPKDmmNZkuJgli/tI2TKrYYSmc3Io02FL/eDqr7PN7XPwtL4WRrH?=
 =?us-ascii?Q?bEtckxcfoJEPnUqr6g+NcnByBTEHmm9JPav8qAeKqOoaeGdMUdzwJZSSH90g?=
 =?us-ascii?Q?bDD3TGmrT3+szC6fQb/I6NqAMDtYPCr3L3fewMkn/AcQtW4mrEJ3qG1wYVBc?=
 =?us-ascii?Q?Uj9ojq5hL1jMbaEwgsc01Qa0ZtGu3d83IRmGyDT/DOevPUIxqytizKqu1YWc?=
 =?us-ascii?Q?qAEhCw=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6171f370-f7c8-41f2-f84c-08db612017e2
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 15:11:07.2011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WTgaFeyCBDACKQ7qT3kNPFjALl1GVH1PuNw+pM8piaOz0OKHIJsUaojoOsbsi1ejuW7cQ4AEXpFJ7CId8KCyTmZVLu47rPFxKVklKdhDE9c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB3230
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Sat, 27 May 2023 11:54:08 +0300
schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:

> On Wed, May 24, 2023 at 02:46:25PM +0200, Henning Schild wrote:
> > The entries do not seem to be stricly needed when the number of
> > entries is given via the number of LEDs. But adding them is a
> > safeguard should anyone ever iterate over the tables to their end,
> > it also gets us in line with other drivers that register
> > "leds-gpio" tables.  
> 
> Reported-by?
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I think we could do

Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

on merge. But i would not want to send the whole series again for that
one line.

Thanks!
Henning

> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.c
> > b/drivers/leds/simple/simatic-ipc-leds-gpio.c index
> > e8d329b5a68c..1a1cfdad6218 100644 ---
> > a/drivers/leds/simple/simatic-ipc-leds-gpio.c +++
> > b/drivers/leds/simple/simatic-ipc-leds-gpio.c @@ -28,6 +28,7 @@
> > static struct gpiod_lookup_table simatic_ipc_led_gpio_table_127e =
> > { GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 51, NULL, 5,
> > GPIO_ACTIVE_LOW), GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 56, NULL,
> > 6, GPIO_ACTIVE_LOW), GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 59,
> > NULL, 7, GPIO_ACTIVE_HIGH),
> > +		{} /* Terminating entry */
> >  	},
> >  };
> >  
> > @@ -42,6 +43,7 @@ static struct gpiod_lookup_table
> > simatic_ipc_led_gpio_table_227g = {
> > GPIO_LOOKUP_IDX("gpio-f7188x-2", 5, NULL, 5, GPIO_ACTIVE_LOW),
> > GPIO_LOOKUP_IDX("gpio-f7188x-3", 6, NULL, 6, GPIO_ACTIVE_HIGH),
> > GPIO_LOOKUP_IDX("gpio-f7188x-3", 7, NULL, 7, GPIO_ACTIVE_HIGH),
> > +		{} /* Terminating entry */
> >  	}
> >  };
> >  
> > -- 
> > 2.39.3
> >   
>