Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Daniel Gomez <da.gomez@samsung.com>
To:     Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
        "Christoph Hellwig" <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
CC:     Pankaj Raghav <p.raghav@samsung.com>,
        "mcgrof@kernel.org" <mcgrof@kernel.org>,
        Daniel Gomez <da.gomez@samsung.com>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] nvme: Increase block size variable size to 32-bit
Thread-Topic: [PATCH] nvme: Increase block size variable size to 32-bit
Thread-Index: AQHZkw1l1o9oL0yVTkSu68uk9vZQvw==
Date:   Tue, 30 May 2023 15:42:53 +0000
Message-ID: <20230530154231.8313-1-da.gomez@samsung.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [106.210.248.108]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTYRjG+3aOZ8fF4nNKvq0bLbqotZIKTxejKw0qukoXiFzuYNGcsuOW
        RpRCWJlgmSkercyWOS0ru9kWRoYuLXNl5bKUNJem1ErtD1tqbsfC/37f+7zv8z68fDQhM/nI
        6QO6eFavU2sVlIS8X91fP/foBKNmvvXqVKakOZ1izCVVIiaj8h1iGix5FHOp0ClmHGeciCnt
        dpErxKr6ltukqqHOoCorPkWp7piOqazvkyhVb9mUzdRuyTINqz1gZPXzlkdK9nd86EBxLknC
        n+99Pkmon05FvjTghZBSbCVTkYSW4SIEra9tYo8gw30IPvGJgtCLwJSSKvo34XL/oQThGoKs
        upvU/y576x1KGH+BwNUZIghmBF+Gnnp9KRwEFTVlYo8QgE8gqHZ/9D4IPIjA3ZtGerr88SrI
        sn9FHg7A68DhfOYjsBJyat3eOolnwKf0i8OhaFqKGeBPSz1lhCdDX3IJ4WECB0JT+6WR3H5Q
        kPuIEHg8DFpaKYHnQF1jOxJ4Pty7WkEKPB2cRU1iwUcJjvOZlMAhUHi52+sjHfasyWn3Xg/w
        A1+wF7cQnjyA10CracTTH7psd8UCT4Ln59JG/KPBVMqTZ1AwPyoqP2odP2odP2pdPiKLUSBr
        4GKiWS5Uxx5ScuoYzqCLVkbFxpSh4Y/0fNDWU44udP1UViIRjSoR0IQiQBqu5jQyqUadeJjV
        x+7VG7QsV4km0qQiUBoSXhMlw9HqePYgy8ax+n+qiPaVJ4ki4xoe5U+PjDh5xLhRW/9qiZ2r
        GuJXdhxbI7XpiB/pYbb4BW2HruT/MnZapi6d2WxtoprTGm01tpRdPXEfwqEv63hYSIQm/Y3W
        WOTvaJv24ktsf9DnsT1bCujHFrOtNnHPenogw0wbnQkJ18tPMqG7Vq6Vm030acfiATKsd8ae
        zL2hBR2TmzSOG7lZmiuOoJ/JTNfEhziixeQ3a8Nso8W+aOsAfTZ/k+kJ0/35+JxE17ZxzAl5
        4RaJ5Hey3/12nwWrrcH7ds6+MdjQuH2Mb1UgX5HdWZW5uVbxbSgh5qWzfF1b6YaMCd1pOcvf
        zsrOPXf58IpfeTtwttUudxu2lt5yK0huvzo0mNBz6r+d6xSKtwMAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42I5/e/4Xd1aybIUg8bTJhar7/azWaxcfZTJ
        YtKha4wWl3fNYbOYv+wpu8WNCU8ZLda9fs/iwO5x/t5GFo/LZ0s9Nq3qZPPYvKTeY/fNBjaP
        z5vkAtii9GyK8ktLUhUy8otLbJWiDS2M9AwtLfSMTCz1DI3NY62MTJX07WxSUnMyy1KL9O0S
        9DK2tr5hKXjIVXH6/yHWBsbXHF2MnBwSAiYS73//Yeti5OIQEljKKLFh3S9WiISMxMYvV6Fs
        YYk/17qgij4yShx5dYoVwjnDKPFw7i0WCGclo8TMqd+YQFrYBDQl9p3cxA6SEBFoZ5S4sWQ6
        WBWzwD9Gid+fe1hAqoQFnCSmXXjJCGKLCLhL3Hh6ghXC1pOYeeo3WJxFQFXiQf88oKkcHLwC
        FhKzunlBwowCshJfGlczg9jMAuISt57MZ4K4VUBiyZ7zzBC2qMTLx/+gftCROHv9CSOEbSCx
        dek+FghbWeLpilvsEHP0JG5MncIGYWtLLFv4GmwOr4CgxMmZT1gmMErOQrJuFpKWWUhaZiFp
        WcDIsopRJLW0ODc9t9hIrzgxt7g0L10vOT93EyMwUWw79nPLDsaVrz7qHWJk4mA8xCjBwawk
        wmubWJwixJuSWFmVWpQfX1Sak1p8iNEUGBQTmaVEk/OBqSqvJN7QzMDU0MTM0sDU0sxYSZzX
        s6AjUUggPbEkNTs1tSC1CKaPiYNTqoFJpDdztu9L73ON/1fdvzqx5O6kF7ss1sip+z40qHeT
        2b4kjE9t76/LgdlXVHfsmHZL98v1Jw+mu8zik1cQ/iRd8mlSnJ08c4ZY+lf7HeH6lxd9fdqh
        zN66PUjD4deMaysieGTNF2a8ZJNqLLM9s8z0VLnFlL43XC/eHPaZa3z1zQGJP19K0xo363gI
        ih040xA8UVuBMazz/D9Ved+rs60Zvl46u9AtSuh87bUvwmrrBV9nOrFazdp3plEs48hB++up
        v2367Pb/1FVbcuCn6iOVbwcMjj222WO928Eret9a6W8nT715eEbpcqaeWN2zpGcvjX9v1GBI
        SF+87FjnNdvu2tsH1pzhqr6knvjlJkvifiWW4oxEQy3mouJEAK5chmGdAwAA
X-CMS-MailID: 20230530154254eucas1p241e57af99e4d4ee0e1a677904c3db68c
X-Msg-Generator: CA
X-RootMTR: 20230530154254eucas1p241e57af99e4d4ee0e1a677904c3db68c
X-EPHeader: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20230530154254eucas1p241e57af99e4d4ee0e1a677904c3db68c
References: <CGME20230530154254eucas1p241e57af99e4d4ee0e1a677904c3db68c@eucas1p2.samsung.com>
X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Increase block size variable size to 32-bit unsigned to be able to
support block devices larger than 32k (starting from 64 KiB).

Physical and logical block size already support unsigned 32-bit.

Signed-off-by: Daniel Gomez <da.gomez=40samsung.com>
---

While experimenting and doing code inspection for large block
devices, we found a limitation of a 32 KiB block size due to the bs
variable type. With that limitation and in combination with a large
block device, this results in a kernel BUG when the block layer
attempts to split a block size of 0 bytes.

Increasing the value to 32-bit unsigned, allows to support large block
devices starting from 64 KiB. In addition, this bs variable type
aligns with the queue_limits logical/physical_block_size types.


 drivers/nvme/host/core.c =7C 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 151b23400ada..b4bc48f2a011 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
=40=40 -1835,7 +1835,7 =40=40 static void nvme_update_disk_info(struct gend=
isk *disk,
 		struct nvme_ns *ns, struct nvme_id_ns *id)
 =7B
 	sector_t capacity =3D nvme_lba_to_sect(ns, le64_to_cpu(id->nsze));
-	unsigned short bs =3D 1 << ns->lba_shift;
+	u32 bs =3D 1 << ns->lba_shift;
 	u32 atomic_bs, phys_bs, io_opt =3D 0;

 	/*
--
2.40.1