Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230517160326.10732-1-osmtendev@gmail.com> <35dea714-6a0f-4673-fd33-23644ea85d33@linaro.org>
In-Reply-To: <35dea714-6a0f-4673-fd33-23644ea85d33@linaro.org>
From:   Osama Muhammad <osmtendev@gmail.com>
Date:   Tue, 30 May 2023 20:54:47 +0500
Message-ID: <CAK6rUAOn_+WSqc8R94deSsZHHwJaJLL2LxFGv929bMj7foCcGw@mail.gmail.com>
Subject: Re: [PATCH] lvts_thermal.c: Fix error checking for debugfs_create_dir
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com,
        matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
        bchihi@baylibre.com, wenst@chromium.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

After Reading more about it I also learned about this and I was
planning to send a patch to remove the error checking for debugfs
API.Should I send the patch for it?

Thanks
osmten


On Tue, 30 May 2023 at 20:47, Daniel Lezcano <daniel.lezcano@linaro.org> wr=
ote:
>
> On 17/05/2023 18:03, Osama Muhammad wrote:
> > This patch fixes the error checking in lvts_thermal.c in
> > debugfs_create_dir. The correct way to check if an error occurred
> > is 'IS_ERR' inline function.
>
> We do no longer check debugfs functions return values.
>
> eg.
>
>   https://www.spinics.net/lists/linux-spi/msg37903.html
>   https://lore.kernel.org/lkml/2023052835-oxidant-doily-404f@gregkh/
>
>
> > Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
> > ---
> >   drivers/thermal/mediatek/lvts_thermal.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/=
mediatek/lvts_thermal.c
> > index d0a3f95b7884..61386be78fa0 100644
> > --- a/drivers/thermal/mediatek/lvts_thermal.c
> > +++ b/drivers/thermal/mediatek/lvts_thermal.c
> > @@ -188,7 +188,7 @@ static int lvts_debugfs_init(struct device *dev, st=
ruct lvts_domain *lvts_td)
> >       int i;
> >
> >       lvts_td->dom_dentry =3D debugfs_create_dir(dev_name(dev), NULL);
> > -     if (!lvts_td->dom_dentry)
> > +     if (IS_ERR(lvts_td->dom_dentry))
> >               return 0;
> >
> >       for (i =3D 0; i < lvts_td->num_lvts_ctrl; i++) {
> > @@ -197,7 +197,7 @@ static int lvts_debugfs_init(struct device *dev, st=
ruct lvts_domain *lvts_td)
> >
> >               sprintf(name, "controller%d", i);
> >               dentry =3D debugfs_create_dir(name, lvts_td->dom_dentry);
> > -             if (!dentry)
> > +             if (IS_ERR(dentry))
> >                       continue;
> >
> >               regset =3D devm_kzalloc(dev, sizeof(*regset), GFP_KERNEL)=
;
>
> --
> <http://www.linaro.org/> Linaro.org =E2=94=82 Open source software for AR=
M SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>