Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp4895559rwd; Tue, 30 May 2023 11:26:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Z6hVfV4D5oop3H88SSS5CsIxXnglZHRKzdmvLaMyAKmMVA/aNWg/nEAlz6a0iMPy2eTPb X-Received: by 2002:a17:903:1249:b0:1ae:50cc:455 with SMTP id u9-20020a170903124900b001ae50cc0455mr3374516plh.39.1685471165798; Tue, 30 May 2023 11:26:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685471165; cv=none; d=google.com; s=arc-20160816; b=yATe6L6sNkH9a/RkFa4TdWxbFEVamqn66HPGKt456d8Lp6i0waULJXUJNMHhC+xc2S 9UG3xReH9PtNsO/8OVLbAK0Dslur3109zgJlwkUfjzU8iZxfxvdgoF1NNBrSOPSXsJoh MFWBTNQUW4bj4JhcW9Dj/EyC+gQFZpfalEbErFGCkHXjos1ZGWc1Nt0LczvACHYs1/21 e4rNVdoS9ujvB+vLFMRXOn9BcOfLT4cixtplny1yXS1Eix+nGlQyYi9DwJx+73ePDj+C nRCzJRthr10mKe3P0Ez5cE8cazvcOBk35GLg3Iv5f4tzCVa+VAU14ZPFXxhAPCPtF2Dg 46Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:in-reply-to :from:references:cc:to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=24Ry0beQgWrLSFF8krNBwN4KJRINBEkewKnwBgtX8s0=; b=vFAyNd32SzFnNYISdmUJ1bGrBOv9VeJ1+FgIO+owNkaTYe6MynkhdCC3V0dmKE81aa LvMve4cfmKFj3WyqZoizTnaslTd+whEfQrxVsTlU/W1NMYIL5OvasfO3I9SkfUfLhfL0 FKYwyzAb7B2DhnqtcBO5IOHyea7laV5BShZL5U3yBQXjL2pydeCQp+Yq8+TfRzxJCluK trGcx2l1nUcDq6bNPOB3KsvJXGGgbOc7F+pCBypTT0QoBxOe682z6otA2gm9EkCOfe7t gcHIRh1LwQ76J6BTWfI/KPLjjlA76KGHEcX4WT3BSSxMlEIDzJiQyZkWqfvK51lCjaPW aBqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=IXdLdyGG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u60-20020a17090a51c200b00250c9a70af9si424613pjh.63.2023.05.30.11.25.51; Tue, 30 May 2023 11:26:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=IXdLdyGG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=deltatee.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232792AbjE3SDQ (ORCPT + 99 others); Tue, 30 May 2023 14:03:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232318AbjE3SDF (ORCPT ); Tue, 30 May 2023 14:03:05 -0400 X-Greylist: delayed 2235 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 30 May 2023 11:03:02 PDT Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9CC6EC for ; Tue, 30 May 2023 11:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=24Ry0beQgWrLSFF8krNBwN4KJRINBEkewKnwBgtX8s0=; b=IXdLdyGG3/j+MW0vZgOMVsZew4 EQGHw0rZ/Qs/tVekOd/EA0IXxQUyJ4eUybgB6Zqzh80ikhKQd9h6gxjv7NX53TEOoYyG/LhjowQmn TG/u7iYYPAwDYfVtPtfHtbBXcQTKfgck38ghgHXddVNwdaybMLMEz9YSjFNcA6owTljt2GczGBWvC N5a/P+mDnHmGlQ8AxESLLF8Y+W2+Y3j14xHBInQkanZR0k5I7MBvp3+AxjZBa/GsgbdYgWKuSlpCj Yndybi5XQK5GV2xuzH1nFjq/yf3FQ8auqtcDKz4CxK6GYh2GI23rhZvuGflKVMvvDjwIld9cJVWjA 65a9QJUw==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q433y-00DzWB-3A; Tue, 30 May 2023 11:23:14 -0600 Message-ID: <8a411404-a2fc-694c-c41e-5d7efba38472@deltatee.com> Date: Tue, 30 May 2023 11:23:12 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-CA To: Robin Murphy , hch@infradead.org Cc: m.szyprowski@samsung.com, iommu@lists.linux.dev, catalin.marinas@arm.com, linux-kernel@vger.kernel.org References: From: Logan Gunthorpe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: robin.murphy@arm.com, hch@infradead.org, m.szyprowski@samsung.com, iommu@lists.linux.dev, catalin.marinas@arm.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH] dma-mapping: Name SG DMA flag helpers consistently X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-05-25 11:46, Robin Murphy wrote: > sg_is_dma_bus_address() is inconsistent with the naming pattern of its > corresponding setters and its own kerneldoc, so take the majority vote > and rename it sg_dma_is_bus_address() (and fix up the missing > underscores in the kerneldoc too). This gives us a nice clear pattern > where SG DMA flags are SG_DMA_, and the helpers for acting on them > are sg_dma__(). > > Signed-off-by: Robin Murphy Looks good to me. Thanks. Reviewed-by: Logan Gunthorpe