Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   chris hyser <chris.hyser@oracle.com>
To:     chris.hyser@oracle.com, linux-kernel@vger.kernel.org,
        peterz@infradead.org, gregkh@linuxfoundation.org,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: [PATCH v2 0/4] debugfs: Add simple min/max "files" to debugfs to fix sched debug code.
Date:   Tue, 30 May 2023 15:40:08 -0400
Message-Id: <20230530194012.44411-1-chris.hyser@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QfdcTbHIyq9szlQiFT0cKPzsEMYTntiTnuhXQXJ2rtoRy7ErHGfrXizwhTbW?=
 =?us-ascii?Q?X0wSN452IxNPuloOglDTwzr/+ezGOJWduF5JetCZmHhFpm7sbQRJ44iGN9Mj?=
 =?us-ascii?Q?2zM6hF5VkyNeXgvKidnaD5sWiNdBzXa5LWRizpW/l3zCjWxjTaWCLk5SHsDc?=
 =?us-ascii?Q?RUlRM/t+MgEHeNwu8t0NcZiE9w8ZPtRAY+af++AsJaQr1nGGxO2oQNg+Zy47?=
 =?us-ascii?Q?KwTyYfQw+1mlD29seODczyTYLPWppHUWJUV4TK0ZmCdwnFwxW4Ot6++V6rK/?=
 =?us-ascii?Q?grqJkQaZRW3AtGJPHriX+rkeTi1YPz1JDUxKj8aJpzE3gKvddJq5luOgQzqF?=
 =?us-ascii?Q?CWWhYalHc1MV6Onf8JjDjQAk0hCUVqnPo2xEULX3NBXqseH8+uL0rzlY6f4/?=
 =?us-ascii?Q?3k20wZfpzDy0rwrM7zJGAA11c9e/1OZD7ipfe3Sq0uxAAPky2HE1I1psRuv1?=
 =?us-ascii?Q?dy4UvJzRPp4rM0EaXofyyacBSZ691aC6hz0kQt6bZxxfizGMeDdfdiN/r3MJ?=
 =?us-ascii?Q?EFJ+k+qxnUeenR/HtWPsRlLh9/9IMtu4b9Shd6LKQo8E0m045gCZG6oTmMYj?=
 =?us-ascii?Q?Fl/ueB4GcSlekdJD8kgUTHLuWJya0m9MEgtIf47KX5P6drCESnhL6AgIuw/j?=
 =?us-ascii?Q?Q9gXQN3v1v8COZVtnAkIG7WXux2jsQvZ6S7gcQ68/Yk5D3wYGI0yKXpkRddQ?=
 =?us-ascii?Q?dYXITEPDKjUKpdYLSHUofad0cWP+c6xQ+6sKRT1ltl6/XnUWQYXoYzokv+Pi?=
 =?us-ascii?Q?HoKM8JDHxt8q96fa4yebLKUZ7MYtj4YRe9fxmKN2aQnPMm0U5GnX5fUUWalb?=
 =?us-ascii?Q?9ToxDYlKFGDSP4lZxeHrXmUbdd0RjJfoMBCXMGc3A0ZPlKtMBPcgWmVNOgue?=
 =?us-ascii?Q?qGKCF14UuaeRSBEo8zwPRyQI/ZYlvKxoXmkOK09cqlOqzfvftnjo02xDrcW3?=
 =?us-ascii?Q?t4ljM1shMCBodNWI0lZddMlrBD3pAUXdfB+HjcbHR1UgowAe5QK9DC8k/nTJ?=
 =?us-ascii?Q?ldbsmniyH3XYEpaVuF+0eWA8v9EmiPMsKjwu18mqCmD4DKXHaqXrrtOBhcij?=
 =?us-ascii?Q?iUkItq1zFqx5exSu2vEUid/ODy79K0W/tr/NJc8zT33Nit+qJVvg72bAJG8r?=
 =?us-ascii?Q?kNtudnvX06m0+EN/b1cMQBtTteqc3g0ZU1yE+S35AN6PoRquo2b8iCXTqec9?=
 =?us-ascii?Q?KsOY5MP5vISfCF+axstzHMNYHRW1VVQ22R5y4dtREXUhk35eh35jRMn21/6G?=
 =?us-ascii?Q?QNLfEbLcOw0+q2jQiYsrFBrBDXnEw3z0Nxjv2u/83JPKPPUrt/PcRr0mBEQD?=
 =?us-ascii?Q?MM9Ap0uEnXlUDdGNpKw4gwrqGfeX4+ISDFFty+EXohUXz1rAwWyZMUr8HZH9?=
 =?us-ascii?Q?EVyAoOrU/928IvtovxcXJZKMBbhNqEhYWPRp3GiNs5ETsL+PLSZwa4FgWhi4?=
 =?us-ascii?Q?ekRmtFC4lERytYVH3hhTcpBCF4Xis3N7g7cZo4O1lr5xumabzMfsZi18gUH/?=
 =?us-ascii?Q?KikC1AJhLgsu8fBf2DWUxB4EJJsS3NK157QQWd3nYOoISg2h9OekQ/jkLnfI?=
 =?us-ascii?Q?tQGDrKPzHLPbIwOS0NoUtaOTztJDjWtt7GscZEVt?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oeZI2BbXCO4wDlk3u2RX8CRutt39e01P2WNZBKz2xc1H2s3a0oFGlnawKXDs7xMTL5zb0rb9ATxFxNyoGTXjy0hshVW1IuGdIVdmPhI2V3HnrzJ08VXB8jZqqXKaIKzSvfC2zv7jh57zEaXd6JbzYHRaSzO0H3MMo0AoAcAGPEcJGP7qWgkXajMcMvfHY3ZCfC/y1e5Wlp/cO+J2LEXpAos4XTLP1iBhFvudOryn0rcaOgHaefgPEhadW0M2DC3/NURSFpG4ktPKu0/SH/2HGdhb5cdLe7/jSGH08bHQAw0IKesLWttwO75Nw1m2xKbQBBQg8N+wQr6Gl5Af2GtjlPPPNpbIVatz9yNs4sfmIc1VEfHEdUszrbVY5FzRIp7GGFh7No0ntU0D4VK+9ROu8Up6ZwpuYcSYcS5hXBMCmZzXxPSVCxDOQM6DpV6SYiaFckIGkUvsLZZ9JT5R1PRfprjDmVXLPDWa3lOqLq04mdpJTRtByx1JKIwkvrhWJJx9sDq/C8Po9tMepJL8qDStTRHu+aFQstaAg0eF69XclvIXYo3+Hyk+KWkeRrbJPu8ZROejV8c5qsKtx8o7eFM+KstEp3vW9p9N/Z6VFmBCoxK7b1f98exaeD7xpPqJHEZJNFE6Cmo6PSJPhVGbVBCVmNvl18L/A+kbZiINLCamWH5GoXUsGi5SbW/qLliBbi5kFMa5oGTMgYkf3+Wiqx37GtHQ9RGdBO0CKRFPDiBja3GGE15eQ/HsRYJtc/OvDsjDgCNvk4mj+9davj2SD8rdcuQ1Q12kWAgXmiGDeZN7xbJWMZkeO44DX5DOD94NIZkC/MpHS3NJcd6EKJiPezLRRMF9kr8A8kcSsoFJNPXMw650YFO0pncNJTuiaLAN7YXd
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 247cfe07-776c-46aa-7cea-08db6145b83f
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4705.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 19:40:27.6028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QCjdX8PkdkloDIGI/HKaJuFEWUVnrSfoY1dr91OLjLZrXFxNJK/szAxhezfrgZboJGMWjHp8jiQwYeesK5clRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6214
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-30_15,2023-05-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 phishscore=0
 bulkscore=0 adultscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305300159
X-Proofpoint-GUID: ZrjZamWv-nUtzUbZDf90GqDQMvHb6t1J
X-Proofpoint-ORIG-GUID: ZrjZamWv-nUtzUbZDf90GqDQMvHb6t1J
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

v2:
Apologies. I sent this the first time without including lkml.

v1:
This originally started as an attempt to solve a divide by zero issue in sched
debug code that was introduced when a sysctl value with non-zero checking was
moved to a simple u32 debugfs file. In looking at ways to solve this, it was
mentioned I should look at providing general debugfs files with min/max
checking. 

One problem was that a check for greater than zero for say a u8 succeeds for a
number like 256 (but stores a zero anyway) as the upper bits that don't fit into
storage are silently dropped. Therefore values greater than the storage capacity
must also fail. Getting an error when what the user wrote is not what was
actually stored, seems like a useful requirement for the other simple files and
so I moved the check into there.

To enable easy testing, a test module and test script are provided which can
validate the new functions as well as check the new limits on the older
functions. This was stuck under selftests, but it is not currently tied into the
testing infrastructure.

 Documentation/filesystems/debugfs.rst          |  47 +++++++++++++++--
 fs/debugfs/file.c                              | 195 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 include/linux/debugfs.h                        |  60 +++++++++++++++++++++
 kernel/sched/debug.c                           |   9 +++-
 tools/testing/selftests/debugfs/Makefile       |  15 ++++++
 tools/testing/selftests/debugfs/minmax_test.c  | 140 +++++++++++++++++++++++++++++++++++++++++++++++++
 tools/testing/selftests/debugfs/test_minmax.sh | 147 +++++++++++++++++++++++++++++++++++++++++++++++++++
 7 files changed, 609 insertions(+), 4 deletions(-)