Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 21:49:39 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc:     Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org,
        Thomas.Kopp@microchip.com,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        netdev@vger.kernel.org, marex@denx.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] can: length: refactor frame lengths definition to
 add size in bits
Message-ID: <ZHZTUw9HWE10CUn0@corigine.com>
References: <20230507155506.3179711-1-mailhol.vincent@wanadoo.fr>
 <20230530144637.4746-1-mailhol.vincent@wanadoo.fr>
 <20230530144637.4746-4-mailhol.vincent@wanadoo.fr>
 <ZHYbaYWeIaDcUhhw@corigine.com>
 <CAMZ6RqK2vr0KRq76UNOSKzHMEfhz1YPFdg7CdQJqq4pBH3hj5w@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMZ6RqK2vr0KRq76UNOSKzHMEfhz1YPFdg7CdQJqq4pBH3hj5w@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WfgbiONmnxbDlatV0ho75korMsVU52lzkz7PPoZEZdp9HJyd/O9Awg3xl799?=
 =?us-ascii?Q?5IFLFknTUINUBxJIiGBwilF5eoDKvlUUKR1eT1apKIq+kfoSZxg0RPRvNdbD?=
 =?us-ascii?Q?u2rxYzsdejk6T7DnyJrETHn020R2aCruFBafzDKIggh6eiBppXSVjZ7T6hkK?=
 =?us-ascii?Q?jeg+9L9JKRVJEunUDwfGowQFmrZuPUkf6/I6o/Y8OKBuaUckj+BEMQSyO1Vt?=
 =?us-ascii?Q?vF32lY9jGlk70/9HOSnb5neGQp+yKfgPzBnT0pRqly/jvCYN0I1A3C43nRYx?=
 =?us-ascii?Q?xILU9x7Bb13EfNbSnrFLDWr2fs6FM1XTPp1JOZOiT78neEx/LLnd/aqc6GIi?=
 =?us-ascii?Q?EmFZC2gv7ETNMXSX9luhyocQ69BQX2oy3gcHvHDz1NSTDKbu7fwXGl3AeEo4?=
 =?us-ascii?Q?HDa+DxeJFrFUrsmLreIu00YaggvzRLWpm6POmcFkXt6odFEVVIdjLxHvbVoP?=
 =?us-ascii?Q?MOrWlOktUdQZtPYZKcBg1/bR3/Jw24FkF7qMfn+vb0C2xK8Pbhpw1H778lNI?=
 =?us-ascii?Q?zfOsuo0y0RdjUD55it7hILEutsMTJCLasqfu5jvyEMQvDfBcs86+EoU4PAr7?=
 =?us-ascii?Q?o+pfnSCxf/d0juwbq65z8547JKVtjJRyCAVfgL87Qqd5vmANDf79rbdqP8LT?=
 =?us-ascii?Q?frMe5tWXWnkv+/PzwUKNB407HSF+cYjHG883HcIleuILEMJFpJTw3yqHHthC?=
 =?us-ascii?Q?py5EtAYk9It3iEKpDN5Qhumpv+A+mVqyhdl/brXJfHBYYKyeFlkc/sT3y2sE?=
 =?us-ascii?Q?srIWop8MPkv87s12YdoSkmlvusN73xvKkYHGJgw2W63i1EDcOgAdmkO/Kt9t?=
 =?us-ascii?Q?47V7aUpbpikxI0w9/REL1buFn6LHAdiTWdoA7tUuvfv43S71/NJyKYRtQVgn?=
 =?us-ascii?Q?MQprfwArCAbfJwVcgrLciENVPV0mpAK0hHEw/D1dwDQRtckmJC57OBxoG0mb?=
 =?us-ascii?Q?V/rw6VEnl+/kM9aUYgB9rAuBGsUrmJf7yc2XRXmhfa7VArGFCcoyN+C/i0gP?=
 =?us-ascii?Q?NoBH7b4xvJTdbkeldUs3pc1F/gu3SNhbD31ed74aorl/SJqH3OcYdBO8+U7v?=
 =?us-ascii?Q?xkwTT/DpXcPafxI9DYSq1PGIKYoiBPOegwQKToT9+JMiFIACdv/SsBNuXjWV?=
 =?us-ascii?Q?J5QPCuJWdVY+wTXgIcy9vzljeitjcJozVaEsWoT97qDMoNidmpmj1xZHDeTZ?=
 =?us-ascii?Q?f8cQgWCrGW+ZGTz5SVmfRZ1EWfOIGi4bbTzA7fsBBea/otTC2U4bmOpeOp9D?=
 =?us-ascii?Q?eiM2FYNG3a+OJpDnJtILHBos7mq/bg70/RrN0L5c6pMaf1yA9j9IoPXnyId0?=
 =?us-ascii?Q?o4xrIbdMuliVkizcW8DIARap45u4niU4PI73RpK5OMR7inVaH1DnSRk65Onx?=
 =?us-ascii?Q?evq3ll1Xp6ctXnz2La/L+nobpG6X4ZcoC8/tHpj95Nr6p38v5w+xzJDaRNct?=
 =?us-ascii?Q?7nzBd/Wrr+g8Y9sWs7kIU3l9WrZGvLr3XJ8kMwHPX/ZIskxX7EJSRtunokcj?=
 =?us-ascii?Q?8vElaFC0sqd1aAT8MgCBjb05E2Tw/b7DSvkpy7eI91/C+2zbZvGpVS1QxuKS?=
 =?us-ascii?Q?7iBH6Cg/lobQNpFtbM52wnMfSvgGHt98MqvDjWjaqJAtZzqxH7eHJdBiKbSr?=
 =?us-ascii?Q?CXikokpSNRznubcWQKIYc5QqFJcg53n/AdP4cDz89BPGch9xt1LG9CfkA9Hz?=
 =?us-ascii?Q?RSkK7A=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cd1c923-85d6-4cbe-2dee-08db6147056b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 19:49:46.6085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yYrJVoo0OgAHlzIfhrSS6MLsRjQB35t9p+9yWnMKs64sfvZwtjzkQ6SXHCWDE50vWUlZFkYe/jypGQqcw4NR5ktaWrORfW9GDFcyBWwuuWw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR13MB4615
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 31, 2023 at 02:29:43AM +0900, Vincent MAILHOL wrote:
> On Wed. 31 May 2023 at 00:56, Simon Horman <simon.horman@corigine.com> wrote:
> > On Tue, May 30, 2023 at 11:46:37PM +0900, Vincent Mailhol wrote:

...

> > > +/**
> > > + * can_bitstuffing_len() - Calculate the maximum length with bitsuffing
> > > + * @bitstream_len: length of a destuffed bit stream
> >
> > Hi Vincent,
> >
> > it looks like an editing error has crept in here:
> >
> >         s/bitstream_len/destuffed_len/
> 
> Doh! Thanks for picking this up.
> 
> I already prepared a v4 locally. Before sending it, I will wait one
> day to see if there are other comments.

Thanks, sounds good.

-- 
pw-bot: cr