Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 00:14:46 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     Osama Muhammad <osmtendev@gmail.com>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] spi-dw-core.c: Fix error checking for
 debugfs_create_dir
Message-ID: <20230530211446.foqpcfha6hjruhow@mobilestation>
References: <20230520224025.14928-1-osmtendev@gmail.com>
 <168546845148.691057.9965315836245052581.b4-ty@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <168546845148.691057.9965315836245052581.b4-ty@kernel.org>
Precedence: bulk

Hi Mark,

On Tue, May 30, 2023 at 06:40:51PM +0100, Mark Brown wrote:
> On Sun, 21 May 2023 03:40:25 +0500, Osama Muhammad wrote:
> > This patch fixes the error checking in spi-dw-core.c in
> > debugfs_create_dir. The DebugFS kernel API is developed in
> > a way that the caller can safely ignore the errors that
> > occur during the creation of DebugFS nodes.
> > 
> > 
> 

> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
> 
> Thanks!
> 
> [1/1] spi-dw-core.c: Fix error checking for debugfs_create_dir
>       commit: 0178f1e5d9845a31024eddd37e93a182e2dbab5d

Oh, thanks. I've absolutely missed the respinned version of the patch
(it should have been marked as v2 though). Anyway the change looks
good except it introduces a redundant empty line at the tail of the
dw_spi_debugfs_init() function. Is it possible to rebase the branch
and drop the line it? If it's not I'll send an incremental cleanup
patch then.

-Serge(y)

> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
> 
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
> 
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
> 
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
> 
> Thanks,
> Mark
>