Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 23:13:49 +0200
From:   Joel Granados <j.granados@samsung.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     <keescook@chromium.org>, <yzaikin@google.com>,
        <ebiederm@xmission.com>, <dave.hansen@intel.com>, <arnd@arndb.de>,
        <bp@alien8.de>, <James.Bottomley@HansenPartnership.com>,
        <deller@gmx.de>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <luto@kernel.org>,
        <peterz@infradead.org>, <brgerst@gmail.com>,
        <christophe.jaillet@wanadoo.fr>, <kirill.shutemov@linux.intel.com>,
        <jroedel@suse.de>, <akpm@linux-foundation.org>,
        <willy@infradead.org>, <linux-parisc@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] sysctl: remove empty dev table
Message-ID: <20230530211349.olrowajsp3idiurd@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="ocfcrlwnlg7a4bub"
Content-Disposition: inline
In-Reply-To: <20230526222207.982107-2-mcgrof@kernel.org>
CMS-TYPE: 201P
References: <20230526222207.982107-1-mcgrof@kernel.org>
        <CGME20230526222249eucas1p1d38aca6c5a5163bd6c48b3a56e2618b4@eucas1p1.samsung.com>
        <20230526222207.982107-2-mcgrof@kernel.org>
Precedence: bulk

--ocfcrlwnlg7a4bub
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 26, 2023 at 03:22:05PM -0700, Luis Chamberlain wrote:
> Now that all the dev sysctls have been moved out we can remove the
> dev sysctl base directory. We don't need to create base directories,
> they are created for you as if using 'mkdir -p' with register_syctl()
> and register_sysctl_init(). For details refer to sysctl_mkdir_p()
> usage.
>=20
> We save 90 bytes with this changes:
>=20
> ./scripts/bloat-o-meter vmlinux.2.remove-sysctl-table vmlinux.3-remove-de=
v-table
> add/remove: 0/1 grow/shrink: 0/1 up/down: 0/-90 (-90)
> Function                                     old     new   delta
> sysctl_init_bases                            111      85     -26
> dev_table                                     64       -     -64
> Total: Before=3D21257057, After=3D21256967, chg -0.00%
>=20
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  kernel/sysctl.c | 5 -----
>  1 file changed, 5 deletions(-)
>=20
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index fa2aa8bd32b6..a7fdb828afb6 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -2344,16 +2344,11 @@ static struct ctl_table debug_table[] =3D {
>  	{ }
>  };
> =20
> -static struct ctl_table dev_table[] =3D {
> -	{ }
> -};
> -
>  int __init sysctl_init_bases(void)
>  {
>  	register_sysctl_init("kernel", kern_table);
>  	register_sysctl_init("vm", vm_table);
>  	register_sysctl_init("debug", debug_table);
> -	register_sysctl_init("dev", dev_table);
> =20
>  	return 0;
>  }
> --=20
> 2.39.2
>=20
Reviewed-by: Joel Granados <j.granados@samsung.com>

--=20

Joel Granados

--ocfcrlwnlg7a4bub
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmR2Zw0ACgkQupfNUreW
QU/sFwv/Szlm33QSWmZp4jNZj0nRdiSW/Bhzrw0gvEHK8N2xTpMMLoWL4ZyVOOq1
/UXJQszbKqDSHCuGcvx8PeLsJc+YD47MTS41BzsU3T+EYFaxQbMgzWGmOi+ysl3g
XWmlmvNz+B6Jn2i/dyqccml9IsaXKGkMT0ujvSDD9J90fB6LhS+cXGpTFmTJPRm5
fphQxo8+5DMNn8fV21pIYwKhLTGzE9i3VXbtJgUa8cjv+OeUIELsRSI3YizjNx/t
baJZch/yR5a7CJYyVk9Vu4Hl7LN6tG7kqu333a9D71G8vkeS9myqPnwJDwoHE0GL
jSZLy13uIlLXpQz5QLHX/4vI29T2jwfVTJ08t+ufA7CwRrKU0Vmn78pj3qSGzRO3
l0Y758g/AxA75+cWoE2cQUBkb5TnVLzzgBjLzehn8TzXLWtN3hJDCpsWYJSRa8q6
fXnmEt1+fh5ikvKO54H0vm9HVRC+DYDCaZhDzbsZoECI55ziH529IcQfTUZ9+QTe
hz5X//5S
=i/vQ
-----END PGP SIGNATURE-----

--ocfcrlwnlg7a4bub--