Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 23:10:32 +0200
From:   Joel Granados <j.granados@samsung.com>
To:     Luis Chamberlain <mcgrof@kernel.org>
CC:     <keescook@chromium.org>, <yzaikin@google.com>,
        <ebiederm@xmission.com>, <dave.hansen@intel.com>, <arnd@arndb.de>,
        <bp@alien8.de>, <James.Bottomley@hansenpartnership.com>,
        <deller@gmx.de>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <luto@kernel.org>,
        <peterz@infradead.org>, <brgerst@gmail.com>,
        <christophe.jaillet@wanadoo.fr>, <kirill.shutemov@linux.intel.com>,
        <jroedel@suse.de>, <akpm@linux-foundation.org>,
        <willy@infradead.org>, <linux-parisc@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] sysctl: remove empty dev table
Message-ID: <20230530211032.mfrmvv64vfzgb7fx@localhost>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="x47pof7mcp2uyogs"
Content-Disposition: inline
In-Reply-To: <ZHYnXKb8g0zSJe7+@bombadil.infradead.org>
CMS-TYPE: 201P
References: <20230526222207.982107-1-mcgrof@kernel.org>
        <CGME20230526222249eucas1p1d38aca6c5a5163bd6c48b3a56e2618b4@eucas1p1.samsung.com>
        <20230526222207.982107-2-mcgrof@kernel.org>
        <20230529200457.a42hwn7cq6np5ur4@localhost>
        <ZHYnXKb8g0zSJe7+@bombadil.infradead.org>
Precedence: bulk

--x47pof7mcp2uyogs
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 30, 2023 at 09:42:04AM -0700, Luis Chamberlain wrote:
> On Mon, May 29, 2023 at 10:04:57PM +0200, Joel Granados wrote:
> > On Fri, May 26, 2023 at 03:22:05PM -0700, Luis Chamberlain wrote:
> > > Now that all the dev sysctls have been moved out we can remove the
> > > dev sysctl base directory. We don't need to create base directories,
> > > they are created for you as if using 'mkdir -p' with register_syctl()
> > > and register_sysctl_init(). For details refer to sysctl_mkdir_p()
> > > usage.
> > >=20
> > > We save 90 bytes with this changes:
> > >=20
> > > ./scripts/bloat-o-meter vmlinux.2.remove-sysctl-table vmlinux.3-remov=
e-dev-table
> > > add/remove: 0/1 grow/shrink: 0/1 up/down: 0/-90 (-90)
> > > Function                                     old     new   delta
> > > sysctl_init_bases                            111      85     -26
> > > dev_table                                     64       -     -64
> > > Total: Before=3D21257057, After=3D21256967, chg -0.00%
> > >=20
> > > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> > > ---
> > >  kernel/sysctl.c | 5 -----
> > >  1 file changed, 5 deletions(-)
> > >=20
> > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> > > index fa2aa8bd32b6..a7fdb828afb6 100644
> > > --- a/kernel/sysctl.c
> > > +++ b/kernel/sysctl.c
> > > @@ -2344,16 +2344,11 @@ static struct ctl_table debug_table[] =3D {
> > >  	{ }
> > >  };
> > > =20
> > > -static struct ctl_table dev_table[] =3D {
> > > -	{ }
> > > -};
> > > -
> > >  int __init sysctl_init_bases(void)
> > >  {
> > >  	register_sysctl_init("kernel", kern_table);
> > >  	register_sysctl_init("vm", vm_table);
> > >  	register_sysctl_init("debug", debug_table);
> > > -	register_sysctl_init("dev", dev_table);
> > > =20
> > >  	return 0;
> > >  }
> > > --=20
> > > 2.39.2
> > >=20
> > LGTM.
>=20
> BTW, please use proper tags like Reviewed-by, and so on even if you use
> LGTM so that then if anyone uses things like b4 it can pick the tags for
> you.
Sure thing. Will send the reviewed-by for the patches

>=20
> > But why was dev there to begin with?
>=20
> I will enhance the commit log to mention that, it was there because
> old APIs didn't create the directory for you, and now it is clear it
> is not needed. I checked ant he dev table was there since the beginning
> of sysctl.c on v2.5.0.
That would be great!

>=20
>   Luis

--=20

Joel Granados

--x47pof7mcp2uyogs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmR2ZkUACgkQupfNUreW
QU8p3gv9E28zq3xql4Zt9T4J2AYBgwOc074GmjXf007UpYleHSi7d5Pokj5gSquF
mvyuxKFtjRCMaMGaot+0FhH/kVBYBFpm+bBtpkuF3Yr9wBh4KQfrKVPbDrnClX5V
NPABq3FlYG29Dowfd/TnboLZKt95Go8GgXo4wlIr+DhQzNkkU29+PF7vnwgwFi0J
1gz+CC92Mu+816n7FQE7nphv+24yJe7RWLe9BlhGNbvhQIEL1bJpSu06KWbkvXZZ
yne9TGOjDUa3GvoZihHSPkuSHZMMxQHTJSnD8yNOhz8zAUXFRwp6IrXX64k4fKst
wAVLa/HKPWwVdy9X6j5VWluoLRTsIZEj49qh0R7FtoPgku/DNWI8yumeotJwhVsW
FAKDIGYIwRQ5tOBbRWoxOTsovo0TD3i7S3WcYpCr1yrbD8tbqpNNLGlD5wTiaMmO
jp7deMehOblVlS76Zdu7Dxnojiw5IOZGxiDcC/RoVLbVGgzM67kJCorJ2n565gPa
zyABUu5Y
=m47J
-----END PGP SIGNATURE-----

--x47pof7mcp2uyogs--