Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 22:25:26 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Shay Drory <shayd@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>,
        Eli Cohen <elic@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-rdma@vger.kernel.org
Subject: Re: [PATCH net] net/mlx5: Fix setting of irq->map.index for static
 IRQ case
Message-ID: <7469ae42-63a2-4078-b997-30d959429d70@sirena.org.uk>
References: <20230530141304.1850195-1-schnelle@linux.ibm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="EZeP2Ayk5L3aJND3"
Content-Disposition: inline
In-Reply-To: <20230530141304.1850195-1-schnelle@linux.ibm.com>
Precedence: bulk


--EZeP2Ayk5L3aJND3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 30, 2023 at 04:13:04PM +0200, Niklas Schnelle wrote:
> When dynamic IRQ allocation is not supported all IRQs are allocated up
> front in mlx5_irq_table_create() instead of dynamically as part of
> mlx5_irq_alloc(). In the latter dynamic case irq->map.index is set
> via the mapping returned by pci_msix_alloc_irq_at(). In the static case
> and prior to commit 1da438c0ae02 ("net/mlx5: Fix indexing of mlx5_irq")
> irq->map.index was set in mlx4_irq_alloc() twice once initially to 0 and
> then to the requested index before storing in the xarray. After this
> commit it is only set to 0 which breaks all other IRQ mappins.

s/mappins/mappings/

We were seeing the issue that this fixes on a Cavium ThunderX2 system
and the analysis looks good so:

Tested-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Mark Brown <broonie@kernel.org>

--EZeP2Ayk5L3aJND3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmR2acUACgkQJNaLcl1U
h9CyKwf/fk+JCCweTuB1F1pHhuuKuWees2MC0dMrpv7VT2X2DcuakOc+KMjUwODW
o0gZ0Hq009KEesiIQN95nyUf8R6MJQHaeKbMQ/CdxQk6g247yKjeS5jcYfenphsf
0IulzAjix0uqHM7TTMO3Rv/C+tfvsI5C7odcJrL1fWQwlTCScdhGHnWs0by1B4QI
0Ki8F1HCXbDIMfNgAH/MrKdIC0Rz0zeTAEIhhhiZcJjDOHAXbcHC+T8ruk3K7t31
gf2AzU/OWw/OL0eAz1uOoaTKSczh6Kq2hTZHpF5yVttJOeESTpqq8oUE9UQEhuLf
eoISI7psNmYdrhMXifygdMYrwBbKIQ==
=puE3
-----END PGP SIGNATURE-----

--EZeP2Ayk5L3aJND3--