Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 00:32:52 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Roger Quadros <rogerq@kernel.org>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
        Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Jacob Keller <jacob.e.keller@intel.com>,
        linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Subject: Re: [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch"
 variable in taprio_dump_class_stats()
Message-ID: <20230530213252.pddrmwgppneawmht@skbuf>
References: <20230530091948.1408477-1-vladimir.oltean@nxp.com>
 <20230530091948.1408477-2-vladimir.oltean@nxp.com>
 <87edmxv7x2.fsf@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87edmxv7x2.fsf@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IE9XI14G+gn/IJvtCEyGxzsmFrd6F2vjHurKZk1YtXIngYo3lAGwiSNpzzZK?=
 =?us-ascii?Q?c0qzmF8Kp44c2XcbU/wG42mmWvS0bWI4mndv0ntTRXBMbt02AWE9w3KnuQ9i?=
 =?us-ascii?Q?SadeIwz0jR7JsXlndn9vo112upXIZDM5WAs7fYn/1Y6d6e1qylgxhtp+CazX?=
 =?us-ascii?Q?e0YHaMe77D2EeTrPJPJWRsM4KVqI04OiIeuWOzaqeDlQVmB8Yjoi8JTS4IiC?=
 =?us-ascii?Q?gUmhvoFa8MUFhxrLEW61iSApDRcYrRIOjpRUSKepwvXPYLTCyKxQ81OPQ7iL?=
 =?us-ascii?Q?qjbp9HWZkFPgnqTsJvJM7WueWZaXSy73LKwCC8gpWWesqwOnVj/coi24QalV?=
 =?us-ascii?Q?v2698VOxCkiUj/V9fFGhL9RxEu4k+z5Qwi2ffwyAveEVKL1LNRqIjmdCej4A?=
 =?us-ascii?Q?5NB9c6ecKkuFQ9bfynd5NIxHLaqrqH0+aXqfEn1MGEJCsfErX1k28FQrNvMg?=
 =?us-ascii?Q?tmxxwwDYqRyE0OwRx1ayW/kIBiSeRyFGigSWVXqLBc2xRQPIVEWqOBQ5jLsa?=
 =?us-ascii?Q?S7KrbEhr6HURzGAMa7QS5HWNBpgsNvaxtYVcOlUcG6Iz6sE4S0BpqwX+qKpn?=
 =?us-ascii?Q?q2rqAlZ5ISOIwUW/wZp596L4tu5KlIqa5LpV/Sc1v+vp6/K6R+39SpZoA0+0?=
 =?us-ascii?Q?sWwwjjUiylZANMNMU3/01Tuqti/+6aQ7skfc9REGvRmtlKaSRkt5eaeqRwy+?=
 =?us-ascii?Q?4S4mbwn9FFn+FfGWfk82ncplUrZFec+pEu4puNWT80emXD4ERLXH5njn22bA?=
 =?us-ascii?Q?fXDX91mEN4TVw5DZOKqYZX8PY0HRrCNipyUg/tfQ0ghSBmN2pNW3OnypZo9S?=
 =?us-ascii?Q?ssitUV3khXe92Tiu8JnPr6ijc9UUGrSBkCN/SqKFurH2WFlkig1gy80Y7ysj?=
 =?us-ascii?Q?YMK1LzCEkSG8dVsyiGVeJjxRvyy2DuEz19wPEMU7+kzPyXgViAFrdVzgLBaH?=
 =?us-ascii?Q?Tbjp6upFtJShud1hHXsQ2c7gRoYeB4mvaoW+CKgwj+d73IiqKeBuUpwYs6K1?=
 =?us-ascii?Q?rq5N3J9fj8wh3oLP2SiWYKSMZCA9Ty64ZQsED3Xm+icJrFDRETvS1e0eUTct?=
 =?us-ascii?Q?NiQr56IxQ1wXOg18ALx1DnxjhFZH4epiJMAo2ZJyiGjBtLRC4AdRGBBIOau2?=
 =?us-ascii?Q?/xTeiXyfwiAtqh68RkSrJivUCILULMFNjnuiddca7YwwzRlI12+0umFnFXF+?=
 =?us-ascii?Q?u3Vs4t6c9GUlUQek9hbpgv12g430+iGl7JvLASrNcDyZ35kSkU+tDQ4rRxdn?=
 =?us-ascii?Q?N1mJ98o6Cj3fuMHAf17VnIOrGmwPkaSXQ3Dc1XS8burI3lsw/TtKTRiHtHEp?=
 =?us-ascii?Q?uZzjaoEhN5+upadgR+E5JACFaioTG5ZHB9zigFTod7i1ecz3MMvV+y5wDZYf?=
 =?us-ascii?Q?VDUbFnd+d7WbsA+R/68Vz7MAHLLpqN86v4CDMaw57J/MWewpP0sibH07lc32?=
 =?us-ascii?Q?XX1gOdu+/7V7US5Xdw+vQSjB2RHVULT9jP4KkqgWV0oWtM2BBnk+hcIGrJzg?=
 =?us-ascii?Q?AqpBHnm50DNHaGcYPTKHaoCAjg9cQwGLUBpdLPw32Ug1p7yq0Bqbp2+LxLkf?=
 =?us-ascii?Q?SAZHPOuIHflJcGeVBCde5L0N+4rDHyhbydR7NikSHO2kQhTQDAyphA7Dzy4j?=
 =?us-ascii?Q?xQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b2e2069-b931-4070-1289-08db61556f2e
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 21:32:57.0645
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xL18dFdIK19zvuC1WTLCUcMj9l5TAerdzCwzHWTcuhjPvK43J+Md7SunVlFSGsbNDCKP2UQZgxQmc2SN+TQwKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8838
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 30, 2023 at 02:14:17PM -0700, Vinicius Costa Gomes wrote:
> But I have a suggestion, this "taprio_queue_get() ->
> dev_queue->qdisc_sleeping()" dance should have the same result as
> calling 'taprio_leaf()'.
> 
> I am thinking of using taprio_leaf() here and in taprio_dump_class().
> Could be a separate commit.

Got it, you want to consolidate the dev_queue->qdisc_sleeping pattern.
Since taprio_dump_class() could benefit from the consolidation too, they
could really be both converted separately. Or I could also handle that
in this patch set, if I need to resend it.