Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 23:02:56 +0100
From:   Conor Dooley <conor@kernel.org>
To:     matthias.bgg@kernel.org
Cc:     rafael@kernel.org, Daniel Lezcano <daniel.lezcano@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        devicetree@vger.kernel.org, Amit Kucheria <amitk@kernel.org>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        Zhang Rui <rui.zhang@intel.com>,
        linux-arm-kernel@lists.infradead.org,
        Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding
 to yaml
Message-ID: <20230530-thaw-unpaved-a1708d46eb5a@spud>
References: <20230530150413.12918-1-matthias.bgg@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ObYA+NJ4eGs7IVg9"
Content-Disposition: inline
In-Reply-To: <20230530150413.12918-1-matthias.bgg@kernel.org>
Precedence: bulk


--ObYA+NJ4eGs7IVg9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hey Matthias,

On Tue, May 30, 2023 at 05:04:12PM +0200, matthias.bgg@kernel.org wrote:

> +  The MediaTek thermal controller measures the on-SoC temperatures.
> +  This device does not have its own ADC, instead it directly controls
> +  the AUXADC via AHB bus accesses. For this reason this device needs
> +  phandles to the AUXADC. Also it controls a mux in the apmixedsys
> +  register space via AHB bus accesses, so a phandle to the APMIXEDSYS
> +  is also needed.

That double "also" bothers my OCD greatly, but it is a faithful
conversion.

> +  "#thermal-sensor-cells":
> +    const: 1

> -- #thermal-sensor-cells : Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description.

How come this has changed? I didn't see an explanation for it in either
of the patches.

Cheers,
Conor.

--ObYA+NJ4eGs7IVg9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZHZykAAKCRB4tDGHoIJi
0hC4AP4umpuP8KFghCmvHITUZSdVQShZ8HJEKLtQj22QodFfQQD/UUmajqYpMOxp
TG5jLg2JDrr4wbLO6ArZSJORQtEAVQE=
=WerN
-----END PGP SIGNATURE-----

--ObYA+NJ4eGs7IVg9--