Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5d359d2b24670e37b9ff8cac7e922c46af30d3ba.camel@kernel.org>
Subject: Re: [PATCH] tpm: factor out the user space mm from
 tpm_vtpm_set_locality()
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     linux-integrity@vger.kernel.org
Cc:     Jason Gunthorpe <jgg@nvidia.com>,
        Alejandro Cabrera <alejandro.cabreraaldaya@tuni.fi>,
        Jarkko Sakkinen <jarkko.sakkinen@tuni.fi>,
        stable@vger.kernel.org, Stefan Berger <stefanb@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org
Date:   Wed, 31 May 2023 00:49:21 +0300
In-Reply-To: <20230530205001.1302975-1-jarkko@kernel.org>
References: <20230530205001.1302975-1-jarkko@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2023-05-30 at 23:50 +0300, Jarkko Sakkinen wrote:
> -	if (!(proxy_dev->state & STATE_DRIVER_COMMAND) &&
> -	    vtpm_proxy_is_driver_command(chip, buf, count))
> +	if ((chip->flags & TPM_CHIP_FLAG_TPM2) && ord =3D=3D TPM2_CC_SET_LOCALI=
TY)
> +		return -EFAULT;
> +
> +	if (ord =3D=3D TPM_ORD_SET_LOCALITY)
>  		return -EFAULT;

Oops, should really be:

diff --git a/drivers/char/tpm/tpm_vtpm_proxy.c b/drivers/char/tpm/tpm_vtpm_=
proxy.c
index 83496742cc19..6da878952a0d 100644
--- a/drivers/char/tpm/tpm_vtpm_proxy.c
+++ b/drivers/char/tpm/tpm_vtpm_proxy.c
@@ -337,8 +337,7 @@ static int vtpm_proxy_tpm_op_send(struct tpm_chip *chip=
, u8 *buf, size_t count)
=20
 	if ((chip->flags & TPM_CHIP_FLAG_TPM2) && ord =3D=3D TPM2_CC_SET_LOCALITY=
)
 		return -EFAULT;
-
-	if (ord =3D=3D TPM_ORD_SET_LOCALITY)
+	else if (ord =3D=3D TPM_ORD_SET_LOCALITY) /* TPM 1.2 */
 		return -EFAULT;
=20
 	mutex_lock(&proxy_dev->buf_lock);


BR, Jarkko