Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 15:21:21 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Luis Chamberlain <mcgrof@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Sedat Dilek <sedat.dilek@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Johan Hovold <johan@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        Adam Manzanares <a.manzanares@samsung.com>,
        Davidlohr Bueso <dave@stgolabs.net>
Subject: Re: Revert "module: error out early on concurrent load of the same
 module file"'
Message-ID: <647676e1e5973_168e29477@dwillia2-xfh.jf.intel.com.notmuch>
References: <CA+icZUVZSBx-=Sm8ZM12dWY4hmpnfDdhmg6UwXsR4OLSgPXY2w@mail.gmail.com>
 <64766df07f013_e067a29410@dwillia2-xfh.jf.intel.com.notmuch>
 <ZHZxdz6TSkf7aBJD@bombadil.infradead.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZHZxdz6TSkf7aBJD@bombadil.infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ONx22zXcnavd4u1ShNTSC0moM2pncuUKDZfGjtZxl8pCHBGRhaqctoYmmw4C?=
 =?us-ascii?Q?PLlbY0ZBWBdTcTtwYJFXsJQUql/bSZ9BZNJimbNBq4zBZywQr04/cyMicrff?=
 =?us-ascii?Q?M0R1if6tGIgDuZD1zyCZqG2/aAvUKcJQdLBgRDInJqMZEtoZ+18V720MUMZg?=
 =?us-ascii?Q?3i4F4fM+6ZpTfoY9in9EeGltuXdpzqAkpOfMYmp8AwVq9Hpu0rKhLgJ0B9ZJ?=
 =?us-ascii?Q?T/zf30gcwDuQRZEKMEDC75ScV14lM1pNQ+tLQtjEr0dz7QTClXZBuaSD205u?=
 =?us-ascii?Q?yhoI5gfXNMVPSDuzgte6FTyQ1udwRI6kcccGexH6wjrkf9DpbJeBjJkIBMmU?=
 =?us-ascii?Q?7mPBS+P64ATAY7Y8WyFGKxBbAtBMTx7/mY2gGmgsM5ZTrW3qZlsAUMZ1c71u?=
 =?us-ascii?Q?dayqmns4J2piKQBgqzLtirXl/Vx5b8/h/JQ/pNPS/JG5Mt0tsLAyniNQpvyt?=
 =?us-ascii?Q?uoAE320Tmh+X/znCYxGmyj1oAw+G8fSYc/vJK532WetdJPED3tE9u2BoeWUo?=
 =?us-ascii?Q?gNLhvGBsNFi1LNTaCQdvqc+xHzobiqJxnn1cPYcFKWc8r5P+r1smgjgLMj35?=
 =?us-ascii?Q?cuA0wnweWm0tyq/zrrVIQe4jQDliN49tT+b13YulAZJGdOtbhHh78Te178X4?=
 =?us-ascii?Q?0jxRI+fAwzFLSfF7H4nwaLZ9h7Evndi5FFOfCXpc+yYWgbKHDjO9x9hZdfKR?=
 =?us-ascii?Q?06c5HEhbB3WcDeatIavW+SlkyNsCgB54RdThHzkjR8WNBjCsY2H8mGaD8w1i?=
 =?us-ascii?Q?Wq6ZuFyD88iYkHbw+uhM2jBNiJs17OvPGDbzMRVbcHqvrriObSfJunSj41cn?=
 =?us-ascii?Q?yS2CHFqNQFHQzMw7PaomMX2a2jYC1h6coTq8PShFiHQcRfrW1NJ4Zc374eGz?=
 =?us-ascii?Q?AhkJVg/oGvsgHrWMv9m3ZB49MUp4BrMG352u1HTB2CBZVqGO4jFn1GrFLoEn?=
 =?us-ascii?Q?xr539cqalWd+JgYo2/hlOImERXD8HktlX6qAs0L1ficKVma85q1roHk6UrCr?=
 =?us-ascii?Q?MfBH6UIIKdRyJCnTXZlUnhxADH/9zD8OTxovP4k46dVikjBDBI1GirNjS7qD?=
 =?us-ascii?Q?RtwuMHTRy1AR+rS9p3DDU1/QZlY56HYIbax0kHSc9QjhaffCl3Oj05Agplef?=
 =?us-ascii?Q?eSa7U2IgbNTiRYpr1uyjr8u1AsHADKCiGgZbGNtaC5J0E8He3vmFXmdN9xpK?=
 =?us-ascii?Q?9T4OtXp0Gam7Rf8EX2OOgfTcwmirOjQHWcprUI/DKqdoryxn7bHiT9LYa3l3?=
 =?us-ascii?Q?JRXUk1U9kYpHXIrLp281k2MO1jIv8492y7slx59OYYJ4LDeddb7JFXpzg4UZ?=
 =?us-ascii?Q?UJIgOG3Sw7HZSl5ImatbgFjCBQDakY8eoPr8jfiz9O73zrUVi7OaY8GMlgyV?=
 =?us-ascii?Q?q4NrIwM8DDwzmODYnRjRcrwB3vuGKx2WMn+PggIHG03KuilDtdrWZ0Dl36Go?=
 =?us-ascii?Q?3YKkB1OX/Y+lt1JsWAy9myUYs6ksnYsYTSlmRBT9+114Agtf05AUfA99iqeP?=
 =?us-ascii?Q?LE1Wb795agPBWnkC7uOHax2DtZzelb1YNakwS6C8LGAdGxfDPiK3XOQMdjeH?=
 =?us-ascii?Q?YgXSDUpb/O4kdNilegkXO3N8/Q8S90LVkTxXW046zIMJy085Cj6xMpuoNSej?=
 =?us-ascii?Q?sQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a36a1395-c087-4221-4da9-08db615c3411
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 22:21:24.2907
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9IsZ7qpXKoEt4A1nVuh/qGnHRHAIMB3XV/VWqUVLg+k+Sma2SdGwbjUcqP4t6uGdQYxuJGswUyc+EipvjynGXMZ4T7KTtcyg97gIjKYQZJM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6409
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Luis Chamberlain wrote:
> On Tue, May 30, 2023 at 02:43:12PM -0700, Dan Williams wrote:
> > [ add linux-cxl ]
> > 
> > Sedat Dilek wrote:
> > > Hi,
> > > 
> > > after building Linux v6.4-rc4 I can NOT boot into my Debian GNU/Linux
> > > AMD64 system with root-ext4 (/dev/sdc2 - of course using UUID in
> > > /etc/fstab).
> > 
> > I did not find a mailing-list thread for "9828ed3f695a module: error out early
> > on concurrent load of the same module file", so replying here. This
> > commit breaks the basic CXL smoke test of loading the combination of
> > cxl_acpi, cxl_pci, and cxl_mem modules.
> > 
> > Just wanted to highlight this a test case for the next attempt at this
> > fix.
> 
> The revert has already been done:

Yup, found that shortly after.

> 
> commit ac2263b588dffd3a1efd7ed0b156ea6c5aea200d
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Mon May 29 06:40:33 2023 -0400
> 
>     Revert "module: error out early on concurrent load of the same
>     module file"
> 
> The smoke test, is this the ndctl cxl tests with the mock driver? If so
> then I could use it to test future efforts for alternatives for this
> work before any new changes get merged.

In this case this was even before running those. I typically just run
"cxl list" on my base QEMU config, and if it comes up empty then
something regressed.