Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230527101851.3266500-1-linan666@huaweicloud.com>
 <20230527101851.3266500-2-linan666@huaweicloud.com> <216ed892-11a9-2d8b-c6d5-a0c7dabe2c9d@huaweicloud.com>
In-Reply-To: <216ed892-11a9-2d8b-c6d5-a0c7dabe2c9d@huaweicloud.com>
From:   Song Liu <song@kernel.org>
Date:   Tue, 30 May 2023 15:20:20 -0700
Message-ID: <CAPhsuW56xuywG80HsS_AQLh9pUUTAztM9wkN=c6Q2ukSqTtNbw@mail.gmail.com>
Subject: Re: [PATCH] md/raid10: clean up md_add_new_disk()
To:     Yu Kuai <yukuai1@huaweicloud.com>
Cc:     linan666@huaweicloud.com, linux-raid@vger.kernel.org,
        linux-kernel@vger.kernel.org, linan122@huawei.com,
        yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com,
        "yukuai (C)" <yukuai3@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, May 28, 2023 at 12:49=E2=80=AFAM Yu Kuai <yukuai1@huaweicloud.com> =
wrote:
>
> =E5=9C=A8 2023/05/27 18:18, linan666@huaweicloud.com =E5=86=99=E9=81=93:
> > From: Li Nan <linan122@huawei.com>
> >
> > Commit 1a855a060665 ("md: fix bug with re-adding of partially recovered
> > device.") only add device which is set to In_sync. But it let devices
> > without metadata cannot be added when they should be.
> >
> > Commit bf572541ab44 ("md: fix regression with re-adding devices to arra=
ys
> > with no metadata") fix the above issue, it set device without metadata =
to
> > In_sync when add new disk.
> >
> > However, after commit f466722ca614 ("md: Change handling of save_raid_d=
isk
> > and metadata update during recovery.") deletes changes of the first pat=
ch,
> > setting In_sync for devcie without metadata is meanless because the fla=
g
> > will be cleared soon and will not be used during this period. Clean it =
up.
>
> LGME, feel free to add:
>
> Reviewed-by: Yu Kuai <yukuai3@huawei.com>
> >
> > Signed-off-by: Li Nan <linan122@huawei.com>

Applied to md-next.

Thanks,
Song