Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp31894rwd; Tue, 30 May 2023 15:42:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6AHJlD/Lk6rr65gVaicbKSFZv5y4nE+oS8Cj0CRJHwgN2yzRXxfbGd11dMFAcgoF/lD9LW X-Received: by 2002:a05:6a00:8c4:b0:63a:ea82:b7b7 with SMTP id s4-20020a056a0008c400b0063aea82b7b7mr4428537pfu.28.1685486569023; Tue, 30 May 2023 15:42:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685486569; cv=none; d=google.com; s=arc-20160816; b=ov8G9HLz5EGT0gsRhLEjNp8yC7rrfVKx8JA/J50nGA3On0BM4LaR0SGiw1UFqzU7X9 M23bbDUNkHLJ9ULtjdnwP6xxcUAeoR4Vg/yerYUpqz5gEnBDmqLSbL7IW5XRIGAGlWp1 Lx8hKwozsjIfgWM1hSQlo313Y8LPUTxF01dqn8OSjQGlCHG4/Ec0A9Fyb+wNFL2bJPV+ LNmeGvQ+EgYbrmmonAtNJNYClxRD5cNwO5zmkGZn9tx8Qo+exKHm/LUA8uEyPumbHMic ESgDVVcL29C4jpzcKm2aDkDJxRg32mMEGbAHkAz1d/YIGUdH8XKt+Pv+AESLYH2ruRxx N+DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=Z2fWQR9dr5fNF4W9QBm20gElUH7CgmrHLP5QHLUBsd8=; b=qcC6iVEBgdgMuZy0BE2pQGRAEIzxdsA6SHFVrgCseKGNZ/lA9fAk965BP41fMEDK5u A7/KHfBSYE2/m27IpVu4Ysc0apT5nbSvwU079yltXMlJMWaGs98u05v4By2RQUjZzRKw vxAGH1jG5dLdfpEM3L6pzELBj2RuSA6ewhbrZjIOUEeaOngJ39PbIamiTDtm00PxpsAb pwPUbofLxReLi+bC06XpM/mja0VPHGNVqvZCzNl6JAO3JVugVIvgzcJX15iGy8ug2qot GNDA4qyEvAG0MKHHVSDA5EHW52e1hBanTCNZHFJSE+7BKYzV5jw6JwhhP5MXcq+b4U+j FybQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=P+kkw8dY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a5-20020aa795a5000000b0064fbe0ad004si2493907pfk.90.2023.05.30.15.42.37; Tue, 30 May 2023 15:42:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=P+kkw8dY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233513AbjE3WdH (ORCPT + 99 others); Tue, 30 May 2023 18:33:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229946AbjE3WdG (ORCPT ); Tue, 30 May 2023 18:33:06 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D91093; Tue, 30 May 2023 15:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685485985; x=1717021985; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=VABDFdCJy0Ud+Ks8o/SFbThuZCncKrRivw4ObAAYIR8=; b=P+kkw8dYQD+M0bIFBD1IBW+RdX870JA2uZdwRybdWDIMrH9HK+Ct3hPV 6bN3e9PR06zpcBztXTt8X5llR7CR5uJ/D3bDapn9dLMkjQq6hC/gBvIsH 1kalHg4bCQW6xbbvpGZaeZLuydg7NDweUxAvMIKZkb6h0xqpAuVfnkpkZ Uu8+gZJMwrkR1yOkXfbURBFMBszeihhHx0xrUaioXwEzwko4179P846Dx EYdQTjtx5YOZVLEktoyllgFVyHKKQ0cnrQnsmE4IrOtXTv/IZZdBJUZeM w0aCavBOI5t6JOyj69uN4WCpNHbgCx9CgkqdOB5DvWKW573gRvYgkMLSx Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="358322047" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="358322047" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2023 15:33:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="880914492" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="880914492" Received: from vcostago-desk1.jf.intel.com (HELO vcostago-desk1) ([10.54.70.17]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2023 15:33:02 -0700 From: Vinicius Costa Gomes To: Vladimir Oltean Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Kurt Kanzenbach , Gerhard Engleder , Amritha Nambiar , Ferenc Fejes , Xiaoliang Yang , Roger Quadros , Pranavi Somisetty , Harini Katakam , Giuseppe Cavallaro , Alexandre Torgue , Michael Sit Wei Hong , Mohammad Athari Bin Ismail , Oleksij Rempel , Jacob Keller , linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Jesse Brandeburg , Tony Nguyen , Horatiu Vultur , Jose Abreu , Maxime Coquelin , intel-wired-lan@lists.osuosl.org, Muhammad Husaini Zulkifli Subject: Re: [PATCH net-next 1/5] net/sched: taprio: don't overwrite "sch" variable in taprio_dump_class_stats() In-Reply-To: <20230530213252.pddrmwgppneawmht@skbuf> References: <20230530091948.1408477-1-vladimir.oltean@nxp.com> <20230530091948.1408477-2-vladimir.oltean@nxp.com> <87edmxv7x2.fsf@intel.com> <20230530213252.pddrmwgppneawmht@skbuf> Date: Tue, 30 May 2023 15:33:02 -0700 Message-ID: <878rd5v49t.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vladimir Oltean writes: > On Tue, May 30, 2023 at 02:14:17PM -0700, Vinicius Costa Gomes wrote: >> But I have a suggestion, this "taprio_queue_get() -> >> dev_queue->qdisc_sleeping()" dance should have the same result as >> calling 'taprio_leaf()'. >> >> I am thinking of using taprio_leaf() here and in taprio_dump_class(). >> Could be a separate commit. > > Got it, you want to consolidate the dev_queue->qdisc_sleeping pattern. > Since taprio_dump_class() could benefit from the consolidation too, they > could really be both converted separately. Or I could also handle that > in this patch set, if I need to resend it. Exactly. Both options sound great. Cheers, -- Vinicius