Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp45823rwd; Tue, 30 May 2023 16:00:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6JeEAeySHmoeSXJ6XiVBwSL44b59tdbJTR5MIDHGbaR0/C4+ySp7cQPAGtLdqEfkpIDlHO X-Received: by 2002:a17:90b:485:b0:256:8dbd:74fa with SMTP id bh5-20020a17090b048500b002568dbd74famr3394695pjb.22.1685487655255; Tue, 30 May 2023 16:00:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685487655; cv=none; d=google.com; s=arc-20160816; b=C3L5rFf3SBo4mUyzgLRWo1Agzpwa/1Vy4WzaQB2/VhRPN45j0GBGz0Z+61um/8Rnd8 zvUucB2szXFZ2RgH2jBbImlnxynyo9smX3VREo4t78C5dVLw7I5I6ffJ5oNuvA4SlfpW iPR2Mv9ZVcVbsNJ9eGz986exEQ7ElzIlo2OiukVO/fl9HodZMsNvAzn9baC94+YPwT3k 2ZktSfyqCxwMAwDhy3KLtORTDppeBn5FNJtC8vMQaD4OivvDxkaNkdp4jYcNMdfLSiq6 DmGPfW3sIcpz6RS+xN3s8nDl5CB0Yn/5fwfBiNusfA6WMqRGH3TGJ5ZIbwRwOdOdA75k cD1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HVPCrHupYIDGk/MKCRILujiQNCUeyrDJevz6XX+Usd4=; b=ZWjE4KwMNSR9HaOLBDTliBM6qnBHgV1fwEn+NZtbno9Po2WrZxGai6weOv7Y8BE+M+ kfE69OLZrKONog021Nhrpsx4KqdQAfaWaHtIl5BxEWxONCrrs8e5AObVdblCve43hi91 tC9bCevoe4vW4G6VXebeAbpNjBvnAa0UEPzLQhgagabt5YtZdiku9tr/eInxahfGe1A9 dU2h5p9F98P+IUBcv6F4wHalC3R5lAnJw1+W74GZ8xF0Tm1getmlRfj4ImNkj3AxHgm5 esc/bHPkk7aSixrnAshjqIibVUXcuuQYDxkliDr5EASgBrWC2bj8ugv75TSHppqa/lS4 geEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KVEG8WOB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h24-20020a17090acf1800b002565ad7d177si6075958pju.93.2023.05.30.16.00.16; Tue, 30 May 2023 16:00:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KVEG8WOB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231679AbjE3WtI (ORCPT + 99 others); Tue, 30 May 2023 18:49:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233426AbjE3Ws6 (ORCPT ); Tue, 30 May 2023 18:48:58 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BC03EC for ; Tue, 30 May 2023 15:48:57 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-64f47448aeaso3723971b3a.0 for ; Tue, 30 May 2023 15:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685486937; x=1688078937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HVPCrHupYIDGk/MKCRILujiQNCUeyrDJevz6XX+Usd4=; b=KVEG8WOB453pw3bsrybg3odMNxDwTfyBDoaAR2i9OPiLPocgECs47Wmmej6XhqOAhB cfw+pgBcT9jdG8GZh+bfnU+Ts1mA7unuAq33Q51KqHuk6AXBLgfZ8ru4sDIKmNEbWP08 ApMZ12HOchUWAwGtRTv00JgDLh5YZ/aqFaDkY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685486937; x=1688078937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HVPCrHupYIDGk/MKCRILujiQNCUeyrDJevz6XX+Usd4=; b=A/75iZqzEXmp7ROWcLuowuGeCIxXSTBCM4vuFG0VCfgnoJpotsT4mVNyK2zLr+jwPF rv+hihy9nzuyv/Gh7ajlTSQgmBhspCLf6wI967JjnVIvwQj7c+8FvvPF/A4iP2oNdcAj 5w40xv8gVbNOyAk2tIlMN2TNHdZYWYFV8/1ON+OdBdScrY0FfcdsGyAWWV68qZicOr2o VkUGchORJk5hAXK76YE3+N37qGNsNUDOe2wWoASZBi7DGW/Yv7poM/PldfsWGOWohtgT bVKwtCP6kzz+ytJpxF462KVq1+w2irqdjsOiYXwfQg8gypVr7KlKvLXzITp9ffRfSOTN MhDA== X-Gm-Message-State: AC+VfDzPh+PfYWKeLKXbf+fp/xvDwdmT5zW0EnHMwHe9Z2aqdY5VtNTR yVEcyk3M8AxgzgUlUcD8d3qYug== X-Received: by 2002:a05:6a20:2d2a:b0:101:e4f3:5336 with SMTP id g42-20020a056a202d2a00b00101e4f35336mr4090246pzl.27.1685486936857; Tue, 30 May 2023 15:48:56 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id g3-20020a62e303000000b0064fdf5b1d7esm2084298pfh.157.2023.05.30.15.48.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 15:48:56 -0700 (PDT) From: Kees Cook To: arnd@kernel.org, kasan-dev@googlegroups.com Cc: Kees Cook , peterz@infradead.org, ardb@kernel.org, maskray@google.com, mingo@kernel.org, mark.rutland@arm.com, Arnd Bergmann , linux-kernel@vger.kernel.org, mcgrof@kernel.org, quic_mojha@quicinc.com Subject: Re: [PATCH] ubsan: add prototypes for internal functions Date: Tue, 30 May 2023 15:48:55 -0700 Message-Id: <168548693422.1303000.13322516962032319887.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517125102.930491-1-arnd@kernel.org> References: <20230517125102.930491-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 May 2023 14:50:34 +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Most of the functions in ubsan that are only called from generated > code don't have a prototype, which W=1 builds warn about: > > lib/ubsan.c:226:6: error: no previous prototype for '__ubsan_handle_divrem_overflow' [-Werror=missing-prototypes] > lib/ubsan.c:307:6: error: no previous prototype for '__ubsan_handle_type_mismatch' [-Werror=missing-prototypes] > lib/ubsan.c:321:6: error: no previous prototype for '__ubsan_handle_type_mismatch_v1' [-Werror=missing-prototypes] > lib/ubsan.c:335:6: error: no previous prototype for '__ubsan_handle_out_of_bounds' [-Werror=missing-prototypes] > lib/ubsan.c:352:6: error: no previous prototype for '__ubsan_handle_shift_out_of_bounds' [-Werror=missing-prototypes] > lib/ubsan.c:394:6: error: no previous prototype for '__ubsan_handle_builtin_unreachable' [-Werror=missing-prototypes] > lib/ubsan.c:404:6: error: no previous prototype for '__ubsan_handle_load_invalid_value' [-Werror=missing-prototypes] > > [...] Applied to for-next/hardening, thanks! [1/1] ubsan: add prototypes for internal functions https://git.kernel.org/kees/c/d25ad53db59e -- Kees Cook