Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fb2f0b6a4202d08857bc08a5507a62d7d9adaf78.camel@kernel.org>
Subject: Re: [PATCH] security: keys: perform capable check only on
 privileged operations
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Paul Moore <paul@paul-moore.com>,
        Christian =?ISO-8859-1?Q?G=F6ttsche?= <cgzones@googlemail.com>
Cc:     selinux@vger.kernel.org, David Howells <dhowells@redhat.com>,
        James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>, keyrings@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 31 May 2023 02:04:35 +0300
In-Reply-To: <CAHC9VhSbZ5YheAVec5a=Xht85mNu6wRjeYaoqPGSiHjFP2NN6Q@mail.gmail.com>
References: <20230511123252.723185-1-cgzones@googlemail.com>
         <CAHC9VhTcso+RTEOkGOCDxyMscznEXrUhp+quDWvATUhEzEOhRQ@mail.gmail.com>
         <CAJ2a_DfRGq+Cg_U7+Rsie9Bywxquu9CuMwYUGNv3+Sg9=wt9Og@mail.gmail.com>
         <CAHC9VhSbZ5YheAVec5a=Xht85mNu6wRjeYaoqPGSiHjFP2NN6Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-05-25 at 17:25 -0400, Paul Moore wrote:
> > A minor inconvenience is the number of needed arguments (and the
> > actual code after inlining should be the same to the inner scope in
> > the end).
>=20
> Well, lucky for you, Jarkko and David maintain the keys code, not me,
> and Jarkko seems to like your patch just fine :)
>=20
> Jarkko, I assume you'll be taking this via the keys tree?

I just picked it and mirrored to linux-next.

I think it is super important change because it tones down the human
error (a little bit at least). You could say improves user experience
kind of I guess :-)

BR, Jarkko