Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp60033rwd; Tue, 30 May 2023 16:13:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6jZfUCaE5bqEhh/iJPo9ZNNVN61701oiCkydukDj9dVNNx/Ur/6M/ZpvTig77eMx46gpXa X-Received: by 2002:a17:902:c40f:b0:1b0:286f:233a with SMTP id k15-20020a170902c40f00b001b0286f233amr3797939plk.61.1685488380268; Tue, 30 May 2023 16:13:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685488380; cv=none; d=google.com; s=arc-20160816; b=x/4/riB4dhj7HDXi3ZcTuzNF+CFtFvtpdcJ8r8zw85T4F76E5bIGVGKDcYd4eiMwRu cdZ3+WajAa1ji9dUfVigBQMYPCC03tYM+JIhbYXC76F87DOGBzKGgcx7AHZRDEGGqiJd NrqXjkrd67KK6u86ho6mFtcHl3Le6Nhyuy91PmpxNFQVDbPgHAgCCO0xlib3oHA674r7 batwxphDu+9BlLraoVVVCStBACmNQSCC9wL6wBYnT5Tark4P5TpaRJVztvKWz8mRONxR FGsM6qTaj7LqTIdcnqNGLrdF3CA9j5pm8ZWS5MyVIlxdSAjyJeylvtLjfj4lw5PNKx9l OXVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BkBhxE3ytz2kF3tpYV9IN2L47NlunYx7yD1fvIugVDg=; b=p6phmsVSLd2l6zMolqYfOD3dUx4GBO9Bmg537ZVbDVyx9pLAAaL6UfgrXK2gD0gNAU hqcpYVDM3n8x/GKpiHpFn1LcUt1ZZ98UevkPyRC9p+UYvQGKShhH9hdkD+ElUyUvInyj pmnnWe5DxtKGPaG8oVOoL7wKjhjcDtNCtXJONaQ8BAFA4jYYlFiXYFlX9Bt8pd0P/xtX 01+kH6cevVgSnx0EEtl7SDrqqR2VofHRwMfADKM5uKMCIhZV/aKR/JUgPFxtddedKbx6 PETXdqLpRHHKn8ZBR/sb70Bevz6mrna9XBGqDyDuCBVKOxwKsKC/8Qn8LZcaOEY3Ew4C 2PNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JkL4Tkma; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h7-20020a170902ac8700b001b02e8d8976si4599038plr.300.2023.05.30.16.12.47; Tue, 30 May 2023 16:13:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JkL4Tkma; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233057AbjE3Wzm (ORCPT + 99 others); Tue, 30 May 2023 18:55:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbjE3Wzk (ORCPT ); Tue, 30 May 2023 18:55:40 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44DA2EC for ; Tue, 30 May 2023 15:55:39 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-64d341bdedcso3709526b3a.3 for ; Tue, 30 May 2023 15:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685487339; x=1688079339; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BkBhxE3ytz2kF3tpYV9IN2L47NlunYx7yD1fvIugVDg=; b=JkL4TkmaBIayj5OCIMW991JmgQnj/gOpmqu0Jw8iYq3PMtBsrylqK5iciUUO1fhYgS 2o7CARmlg2bDXlKcJclJ9S/L2d10IK4UribgkAI3rT5ddfJwfkzp232e3xf8cjAq3sQt imoZlKZvz+c0GKoP6pL6IeBJqKSiae+R/iNng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685487339; x=1688079339; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BkBhxE3ytz2kF3tpYV9IN2L47NlunYx7yD1fvIugVDg=; b=ganh58nfey4ZJ+Dag4rMYMBZfgSX25nu1ZrTVx/UUjIbOu/t74rDotPJIwYP18Gs4y ZUwaAXuaVob98ZtToBNl2KK2xjV51ce7HBFoJOJXYHrOkQaNj4noz/sXlH7x18pw4ICe 03mIPAYu8A0ZJop8HTIAg8JDKLOYfi0fWg+sdTH0RCFe99vTP5OOpr3b8JIwCZXvBmeA ojXg8zhoRszuz+3SDtl/srPe4IJvuedawxqyKtlBNtQiVWTBTFXWLOrfFjBG8cxgrQxk 9wimM84J1iFynqGHtfDRhDyPLgrvvSecIWWbnqcZyFyEv6djGCkdvsQtlYmtGOfnEqWz SFeQ== X-Gm-Message-State: AC+VfDyymmQJuZL7TaFE7PXeQixvp1wBva8+1USZDcaQI7T9O92gMAiY W9pukv+O/xblTECpElGghFVSKA== X-Received: by 2002:a05:6a00:2e12:b0:640:defd:a6d5 with SMTP id fc18-20020a056a002e1200b00640defda6d5mr4441213pfb.12.1685487338720; Tue, 30 May 2023 15:55:38 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id s22-20020a63dc16000000b005344b30d449sm9336232pgg.86.2023.05.30.15.55.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 15:55:38 -0700 (PDT) Date: Tue, 30 May 2023 15:55:37 -0700 From: Kees Cook To: John Johansen Cc: "Gustavo A . R . Silva" , Paul Moore , James Morris , "Serge E. Hallyn" , apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] apparmor: aa_buffer: Convert 1-element array to flexible array Message-ID: <202305301555.102E1890@keescook> References: <20230511213441.never.401-kees@kernel.org> <7085879d-4d21-b90a-c08d-60450d1c7d38@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7085879d-4d21-b90a-c08d-60450d1c7d38@canonical.com> X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2023 at 02:48:29PM -0700, John Johansen wrote: > On 5/11/23 14:34, Kees Cook wrote: > > In the ongoing effort to convert all fake flexible arrays to proper > > flexible arrays, replace aa_buffer's 1-element "buffer" member with a > > flexible array. > > > > Cc: John Johansen > > Cc: Gustavo A. R. Silva > > Cc: Paul Moore > > Cc: James Morris > > Cc: "Serge E. Hallyn" > > Cc: apparmor@lists.ubuntu.com > > Cc: linux-security-module@vger.kernel.org > > Signed-off-by: Kees Cook > > Acked-by: John Johansen > > I have pulled this into my tree. Just a quick ping: I haven't seen this show up in -next yet... -- Kees Cook