Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp64592rwd; Tue, 30 May 2023 16:18:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5aDKrFcKMpbf0aobaAwRZ1PUsvLEfuseZdEXD8Kt7ymqjF/DtadPvGYxhY5WxW7FqFb4bS X-Received: by 2002:a17:902:8307:b0:1af:9b8a:9c6c with SMTP id bd7-20020a170902830700b001af9b8a9c6cmr3477012plb.8.1685488691666; Tue, 30 May 2023 16:18:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685488691; cv=none; d=google.com; s=arc-20160816; b=NdHzcA8PX36c9N0E8VdHZeNz7tvd8P9P315znIVUgSd+NlqdhwanMCCq3sV1gxGq9r QCa33nrh6zJD6E8QQZ2DI0+Gk1KwTSaVZuYA/8GQX+XTOHhSj6DGI2e24Coi7OXGurEi mkj6Y7GbsR2kp7xUJvNRWsErtZifXvhdTBknY7w+r5DX+4LyvYdC/6ebXIUdtgxN3c8w WWsbrq+alwfKGWXJxpmHRRgmOLgJSKgeThXvLZQU2cDKqrmJSTBfK2ICYpfW7cN2p4YM 1eEAhcTl5DCPnpxMbHM57Me9Q6GoqU9C26MmikQgrbNzpwQBAE5IY//R/3w49KkddpTv lGSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2ueHzQ8Wa2okWJ0fmfLLo52MhtIRbhBte5ZK2h7JXro=; b=alvVqeCQtNQ0jMFA1VyV9xwN6vi8Rq3C7KJWddHmCMTpJWcoU5r4Uikhdw/7K8aURK NAdn76DaCSQqvrTwq6D1wVj4UYnaN1j6glNGAzTqmB8HJV5XSTpwkbWMBd/sZZIRWjqF v8G0QViJEP9qQqShiwIOUFd4ffRBgHzZKW4wFNWdaJtWfk612+e/SbN88kuJfnPvy0XB oTcQ23RHQaWb3i77bAaX84RT+BnOVYKSSPX8K8mk3AbrKT0/d1n+tPaNytJi9fIS5uiE Tn4KCdWAuRy34/3z7yMLJj6EHeJ6n7w4DcbiSocPALv4s+zam1buKJgjMPNd3SjTC7+T EM1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Uq6HIEJP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x21-20020a170902821500b001a97e24eb34si9251813pln.201.2023.05.30.16.17.58; Tue, 30 May 2023 16:18:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Uq6HIEJP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233614AbjE3WxP (ORCPT + 99 others); Tue, 30 May 2023 18:53:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233495AbjE3WxI (ORCPT ); Tue, 30 May 2023 18:53:08 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C208A196 for ; Tue, 30 May 2023 15:52:55 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-53482b44007so3207710a12.2 for ; Tue, 30 May 2023 15:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685487175; x=1688079175; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2ueHzQ8Wa2okWJ0fmfLLo52MhtIRbhBte5ZK2h7JXro=; b=Uq6HIEJPqhlC136Vr3uDaJx/LiLYTMr0ktJdq1gXrz3vbtj1rUBgix8iIftoJRJE0u s0n2ZmNyvaXfahlPmLFPgKGLTC1R/PE/AexOHlFF+h4qCqm1X8Gzxt4UGEys9DU2AxMw qJLvr9ylGvgEI/uCFvZqM2M+37XDZ6hkc6iNA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685487175; x=1688079175; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2ueHzQ8Wa2okWJ0fmfLLo52MhtIRbhBte5ZK2h7JXro=; b=QMiioKf28n10quDa74fUQlYzJ9Kgp17/pL7tHp7/ykz4kimB20ji9oKokY0eLehoHv kNkiNM3Ii7QaAgmvXbV5z7iULKb+ui/V1b21gx4YtvmC9G8kpw97bk3R6aXufrb7IsCO QVqi3ualQXSE8ZFyG7HgsGo31HWkzNqP9NRDAQl1E4uJ1Vw7GqATn86YO0G0UfpV6nEa 3rQo80Ui/IAvdx+LpQ6GBD4ITkTdQlqtOCZt7rraWQKZibz7Qg7SHOP16JMUjAw83VCE 6ooyIOWtFveYLiVudeXQW92ccFBiKJgbZKpW2DJC22FOklfY6bg9//wMUr0ohahKRG7K Mxjw== X-Gm-Message-State: AC+VfDy8Iu2aiFmKV95XSug7Wn0CVvUHeUegGw3WU+2fK7l4etoThCqE qAF50jOX4QJ9fjjdu/eYDHglAg== X-Received: by 2002:a17:902:d4c8:b0:1b1:76c2:296a with SMTP id o8-20020a170902d4c800b001b176c2296amr312445plg.60.1685487175088; Tue, 30 May 2023 15:52:55 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id bg6-20020a1709028e8600b001a4fe00a8d4sm10829640plb.90.2023.05.30.15.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 15:52:54 -0700 (PDT) From: Kees Cook To: christophe.jaillet@wanadoo.fr, Al Viro , brauner@kernel.org, ebiederm@xmission.com Cc: Kees Cook , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] binfmt: Use struct_size() Date: Tue, 30 May 2023 15:52:50 -0700 Message-Id: <168548716819.1348275.7939799619978451997.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <53150beae5dc04dac513dba391a2e4ae8696a7f3.1685290790.git.christophe.jaillet@wanadoo.fr> References: <53150beae5dc04dac513dba391a2e4ae8696a7f3.1685290790.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 28 May 2023 18:20:24 +0200, Christophe JAILLET wrote: > Use struct_size() instead of hand-writing it. It is less verbose, more > robust and more informative. > > Applied to for-next/execve, thanks! [1/2] binfmt: Use struct_size() https://git.kernel.org/kees/c/e6302d5a285b [2/2] binfmt: Slightly simplify elf_fdpic_map_file() https://git.kernel.org/kees/c/36650a357eac -- Kees Cook