Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 02:15:09 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     linux-pci@vger.kernel.org, netdev@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh@kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Michael Walle <michael@walle.cc>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH pci] PCI: don't skip probing entire device if first fn OF
 node has status = "disabled"
Message-ID: <20230530231509.4bybb5nw4xyxxq2m@skbuf>
References: <20230530220436.fooxifm47irxqlrj@skbuf>
 <ZHZ4TFjFLrKeHPGi@bhelgaas>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZHZ4TFjFLrKeHPGi@bhelgaas>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XcBtnet2379H9K6CIL9VMSk2jeeozx5JWTtCKFUTbTzaJJZNCj5x4RhkLFi4?=
 =?us-ascii?Q?Y0lc6tJHohKLUEJEARyJRBBnzjXzWFZropa9RppzHgERaMHitQPZXtlN7hl9?=
 =?us-ascii?Q?d44IbmS60P5sD/q/u2S2DInsg9/gwCBk/zy1qd6V/RHc6mm/rJkCvTZ61Vgl?=
 =?us-ascii?Q?YCSkcJSpiPiMswm9v47LMSN31IMKAs9t7Nr7qUED0Pd+BH+UGUlwpsGgJ6+Q?=
 =?us-ascii?Q?3M6M6n1UTU6zIDjyTXxZBeekV0mLWkTdlp/bJzUEpofBuSA9YyZl1dN88+zD?=
 =?us-ascii?Q?TyfFB5uYq8rcd181dist7j2mlleYhfHh+s7FfyQNpF3tS8mQKDCUxr8vNDMh?=
 =?us-ascii?Q?13cLBu5wlH+zScG6lMX7r+e4SWKp3A8foWu+k10nvTa14I7KTM8AMYwgslXD?=
 =?us-ascii?Q?cD7pBSwbaEVZULbqqVzhk+PWMhPFsjzh0DWPCTc+snsUUWVoL5e8mBx4ElT+?=
 =?us-ascii?Q?2OLpUSenYZ49FDjyDZFtiuB9mtEp71LSNEQaghmoA+tv33SZslpSX3Gr7TDb?=
 =?us-ascii?Q?GSoDKwiQyAzHcYrtgaRce42in4m0Mvtplr8q58hr8A4mImzWt9vWdRvDehwg?=
 =?us-ascii?Q?18Uyqi3b0tgpMzfsy+WnbZCIwvfm/aU2k20+ciXzVDiGyi41qPYP4d5qh3j7?=
 =?us-ascii?Q?N8zcUUlKg+Gmo3Q1tZ+uwe0zrOZuNkwSah7uQdqaJwK4GuB5wnSAkofzFEWG?=
 =?us-ascii?Q?rWTYEGwUqyWvxXh4NflRFRoct+Ieds6ze+4zxjt6IHbEENtmwvmRqtfZR/Ou?=
 =?us-ascii?Q?gQTUlMInHHJ8aFGzUnE8NzKoqqiWu8BHFDW67JZef8gO1k1ztsmMXucv/0Hl?=
 =?us-ascii?Q?2VVdG9dVZkCNULBOnK7XQNz6ZtFpISXuQ4zJQnJIsLtlQfWGCJmaTKWM6gj+?=
 =?us-ascii?Q?STryORj54bkIy3vU06cJFQBULHNc3EsPT/SIlSVVJG7CDhJuDViCDA9FMP6f?=
 =?us-ascii?Q?FgwuqkPaZXRM4W+ez6oHqvhPK+1m5OsMeBTB0HNj2pFafQWbjJyHEXVXtXjM?=
 =?us-ascii?Q?yDhPb67GwF8CUvXVE//B3Mov7vyS4dC+LyofIF1EVfwa9nlbUn+SVUWffEfq?=
 =?us-ascii?Q?3KFzEKHYN3rBcwUH7ch4f800Bk0Aq6iBrikrJnfekMqA0sysr891pUA0+3j/?=
 =?us-ascii?Q?MXL4ESuCs3npWisAiwGf9Wtdr/7GA9PqQmuMEavB8Mx7dF83QIqXBZgDXLlz?=
 =?us-ascii?Q?p+w5JMJPjcX0uKuEU4RWmeSJAOeUUhCZ+Zn89yhhwDYqNu9Ibr1EPgftCtHY?=
 =?us-ascii?Q?SGH0FWGy8nWLKpwMVxK2IIY9z5/hbVzIvH9UiNIUJftal0Mg8WlPWo4YyD6w?=
 =?us-ascii?Q?u+m6HqXJhIgNpMxCxuDO8vZQFxy/XJ3JYhlTypAMWb3DoJpMmD/1rEF0als/?=
 =?us-ascii?Q?xXjwPAEfHMtcz8YFsASgqIkCWfZJvGZz1xJbuWzCRShgONBGJ5XQoGURk/9H?=
 =?us-ascii?Q?mY1OkiTiFHh/HMKNoTb3F1Uw5S6fIHkYMEwri9canDZTuSSY9cwP31PllLdr?=
 =?us-ascii?Q?Oh7eN+0tIqZfFPHk5MZ8NISGu8OVICYVZtvfzs4OEkTn59vrLrflWZQf21rB?=
 =?us-ascii?Q?HhWXjPHBFXyCoN7KhTnB8aM1NyFWWdUXpT/VYz37fzWRHFFTjokdxQE3alPf?=
 =?us-ascii?Q?ow=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42524e5a-df3b-468a-338f-08db6163b8d3
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB6459.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 23:15:13.4932
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TaDyFNBIXuHbP8o5puuQYgAldqGA3FbHbDxfxbxa0f5EUiR4N9S4UMnDmcblM5vXAqtfaN9GBu04zKuBm5H96g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7232
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 30, 2023 at 05:27:24PM -0500, Bjorn Helgaas wrote:
> Ah, you're right, sorry I missed that.  Dispensing with the SERDES
> details would make this more obvious.

Lesson learned. When I had just gotten out of college, every time I asked
the coworkers in my company what they're up to, I was amazed by them just
proceeding to tell me all the nitty gritty details of what they're doing
and debugging, like I was supposed to understand or care for that matter.
"Dude, can't you just paint the high level idea without using dorky words?"
Now I'm one of them...

> Not sure why this needs to change the pci_scan_slot() path, since
> Function 0 is present and enumerable even though it's not useful in
> some cases.

Well, the rationale for me was pretty simple: it's the pci_scan_slot() logic
that I want to change - continue enumeration in some cases when the pci_dev
for fn 0 is NULL - and I'm otherwise perfectly okay with pci_scan_slot()
getting a NULL pci_dev from pci_setup_device() for fn 0. That wasn't something
I had in mind to change.

This patch is what it takes to propagate a qualifier, without leaving a mark
in any structure, for that NULL return code: is it NULL because enumeration
came up with nothing, or is it NULL because pci_set_of_node() said so?

> Seems like something in pci_set_of_node() or a quirk could do whatever
> you need to do.

Could you help me out with a more detailed hint here? I'm not really
familiar with the PCI core code. You probably mean to suggest leaving a
stateful flag somewhere, though I'm not exactly sure where that is, that
would reach pci_scan_slot() enough to be able to alter its decision.