Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp120147rwd; Tue, 30 May 2023 17:20:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6boOTGdT7haznQZ0AtN0EbVuD1xWjF5M74fAeG7aJ9MG2exI5W/Ulz5+HQGFPqGxPdbuW6 X-Received: by 2002:a05:6a00:2e1b:b0:64f:4019:ec5b with SMTP id fc27-20020a056a002e1b00b0064f4019ec5bmr6154854pfb.7.1685492441499; Tue, 30 May 2023 17:20:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685492441; cv=none; d=google.com; s=arc-20160816; b=iHAUUIibnhIUU7EymM1fI+NNvY2zTb55dx0Ud/SivKyTxhjce99YQqc0c79nxsg8lP AMRRHqnELq7V8BZDjQUE7/hlQVLeCD4KfS+mtcsaLtXAlPVE3dB6kWxa7aJlSHchkunT ivpfoRB3WxQ95pt34tEU8WhGdleJgJjSGGc8u7KgJd9z6WdDVik9S1HLUeFJl2AWOPnK Rp5FEBCRICR+inu5NeJfn7rB3hKdwYfwJgqt0L7RfzbhOmVTvDRhWvJ1Jc2hNF3Oj96y OdQ4cczUiiSO4rKFasP/r+WCVcB8prY7YerMrg5WFDLppvfQSEU/TeLg4D22fkNCYYVV AGqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7FN5z/Bbo4F41FMSmQdaTAQtO0xV9HpjcxuBSMJEC24=; b=gkSox6k+cdPFL48pgabL/N0bOdOTCF1/ml98t6RBmocthdDjDBtburApthiOP5ejZU G9E7obUCO64S6JCmfMoZ3+dw0uvjZducFkqdYReLjwJVpk+GpIBnC7OIUuQG5NYnrj7N S/FwOgAn1Xyse8zv23EjWfYHjt33L1IG/O6R00oGi2K1VFJJ6seV4zoanYj3dATfHveE dv2bQ36d8WI/4yEad2mbJoEEEuOfmxGB2/pBleCiZOzZcUdEALbYZ9T2XNWRUdWJ5wty bFJss7eHj8js4zRHVjJ7TsGwuaGjt7Do5yuXapqg7GrOV9r7/JHAPfctmFvscYJeRnxY Ga9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WcJ99nWZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q136-20020a632a8e000000b0053fc25d02c5si1234711pgq.245.2023.05.30.17.20.29; Tue, 30 May 2023 17:20:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WcJ99nWZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233516AbjE3Xsi (ORCPT + 99 others); Tue, 30 May 2023 19:48:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbjE3Xsh (ORCPT ); Tue, 30 May 2023 19:48:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39D92AA for ; Tue, 30 May 2023 16:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685490473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7FN5z/Bbo4F41FMSmQdaTAQtO0xV9HpjcxuBSMJEC24=; b=WcJ99nWZ4CtqgvejMqKqstWQgM4MTTrkYybYi38ESBS/QJQODn5xibJmj5yEyVknFIDhT2 4ehdchbfBJsXAQTI/vjDES+6SHmRIWC9wHejxJ12//6FAfnHJ+BoGuEcogOSaViilMXUbV cU9/GIf0vN8ANPSBjwWqAPo/d1s5O/g= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-NpH3Y845OZy_N6ytzrQcUg-1; Tue, 30 May 2023 19:47:52 -0400 X-MC-Unique: NpH3Y845OZy_N6ytzrQcUg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6261a0b2391so19512216d6.1 for ; Tue, 30 May 2023 16:47:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685490471; x=1688082471; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7FN5z/Bbo4F41FMSmQdaTAQtO0xV9HpjcxuBSMJEC24=; b=JlEVZhevZbndOOocqeAEgod+jJ6rH9bZp0ObC7cc9fZDQTch+1YPN2/wOC5VugTYRR +oSLh1VO4lBeBlo34Y+9g/a7gX7ZdBYTDZzpimkY1VXPCMznrQGwlZm2Dn2qdfdYqK1d l+1oFi92i27bKHymZA1eUXbsjMenKKjOz7fM2VtdeJCf0prbdujGz3doHyuOBoOScjof rjfma6Iaofzk3rJ1BocJf0uy1YzH9bjqJyAsPnTyTrkVSN36+7Y2l3Mf36EY4Q8pmF14 +z8BXClL4utVxU9pj6ml/B7ZyEFEAdLVxCEia/+SAosrCTQvcZjEZMmf3TmQRlsg1W11 sl2Q== X-Gm-Message-State: AC+VfDxJrykkw9FhjGMz8KHOh9R5YZwDwv2kAJqnhIjWKrePSz8hN0AQ D/b+h8p8E6weCgnnqyvHgyMe5UOEgKPbo1+r0g60DI+vpSamP44SeH5XQVdmNshtP5QkY4c0PUd SX33V3ktk1H4Wy95E/q9vAbT0ILSAAIB6 X-Received: by 2002:ad4:5ec7:0:b0:625:aa48:fb71 with SMTP id jm7-20020ad45ec7000000b00625aa48fb71mr5034835qvb.59.1685490471706; Tue, 30 May 2023 16:47:51 -0700 (PDT) X-Received: by 2002:ad4:5ec7:0:b0:625:aa48:fb71 with SMTP id jm7-20020ad45ec7000000b00625aa48fb71mr5034822qvb.59.1685490471480; Tue, 30 May 2023 16:47:51 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id e7-20020ad450c7000000b00626234be222sm2320369qvq.57.2023.05.30.16.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 16:47:51 -0700 (PDT) From: Tom Rix To: pavel@ucw.cz, lee@kernel.org Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static Date: Tue, 30 May 2023 19:47:48 -0400 Message-Id: <20230530234748.3641630-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org smatch reports drivers/leds/leds-cht-wcove.c:144:21: warning: symbol 'cht_wc_leds_brightness_get' was not declared. Should it be static? This function is only used in its defining file, so it should be static. Signed-off-by: Tom Rix --- drivers/leds/leds-cht-wcove.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c index 0cfebee98910..0a5c30e5ed5d 100644 --- a/drivers/leds/leds-cht-wcove.c +++ b/drivers/leds/leds-cht-wcove.c @@ -141,7 +141,7 @@ static int cht_wc_leds_brightness_set(struct led_classdev *cdev, return ret; } -enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev) +static enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev) { struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev); unsigned int val; -- 2.27.0