Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6e1e9de9-8def-46c3-a238-c1b4ef52e331@intel.com>
Date:   Wed, 31 May 2023 09:11:26 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH v3 07/21] KVM:x86: Refresh CPUID on write to guest
 MSR_IA32_XSS
To:     Chao Gao <chao.gao@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
        <rppt@kernel.org>, <binbin.wu@linux.intel.com>,
        <rick.p.edgecombe@intel.com>, <john.allen@amd.com>,
        Zhang Yi Z <yi.z.zhang@linux.intel.com>
References: <20230511040857.6094-1-weijiang.yang@intel.com>
 <20230511040857.6094-8-weijiang.yang@intel.com> <ZG77wu4PyBn1z587@chao-email>
 <23169e5f-9793-9486-fd5f-287e3317b837@intel.com>
 <ZHXnP5bEvxPrDg3m@chao-email>
Content-Language: en-US
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZHXnP5bEvxPrDg3m@chao-email>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzJpdmMxV1JBKzd2MnFNWTRQODA2aWxGaTBFK0N0aE4vem91cUF2Y2wrMjR6?=
 =?utf-8?B?SUNQQWRXMzdpYW9YdnVNbXFUeTBGeDlOL2lxOXhVODVheG9JaytWU09ydGk0?=
 =?utf-8?B?LzNrczhjd29VSU9FNlh1K0FiWnY4bVRmYmI0SE5NN01RWkN5cGk3d2RGS3J4?=
 =?utf-8?B?c2J2Mk1nRmJFVXVvWDBqemIwV1E3VHI1ZXNIVjFXRjhyYmtOQXRLVThqOW1J?=
 =?utf-8?B?RW9ndzJPNjhTanpDR0VnbC9MR29GYzE3dmhiU1pBeHB2N2t0QW9ocXJuL1dM?=
 =?utf-8?B?ZEVDa1BnUXJSeDVPVzkwaytQZCtxcS9HQ0FZKzFwS1FuaDYzQ0pUQ3VycnVM?=
 =?utf-8?B?MDd2S2thTjczV01QajBuaFNPMWwwbTJmU1hWTXBRNENrWmE1NFZBN3FhRzc4?=
 =?utf-8?B?ak02RHJBZGROL0wxU1A1UTFmMUN2Q050M241bTRaR3VETUtWdFROcDl6cktk?=
 =?utf-8?B?MEEwL3hyNGpSTWhEK3g2R0pSZnRvTDNucU0rWDMra3hHOTJXWjVGcnVBQTF4?=
 =?utf-8?B?dmJ6OGlhbkRicVljb2xLazRNcmNPeUFWVVhCQ0cxL3BpK3orbHJBN3RzT1h5?=
 =?utf-8?B?KytTVHN5N3VjdWY4RTJTYU9lZ2JHVFhTdEpJVlZLeG1hNmM3aTFZZ0hZSC9N?=
 =?utf-8?B?dC9MOE9ocEpHSVhkRzN1dm1BclIva3l1VnNGcWMzcU11aGlPbnNFMExEcXFw?=
 =?utf-8?B?K1JxNU1BTFU5Qk9CNXJsbEI4RmhiRk1mb2dwYzNQVW4vV1JEbzR3YitqZDFP?=
 =?utf-8?B?WG4rOEcvNmJrWkUyZnpra0FKY2xvYUlFdnV4S09zNVNXeGFlZFR2aFdCWmVB?=
 =?utf-8?B?YWpqUmorMXpyS3Z5T0xTNGcwbzFXT2JZOFVCVHU2WHBzR2tGbkFqMDFseXVY?=
 =?utf-8?B?UU9ic3lNcUgwNkk4NXlseHozNXliNWhRWUJLaDQ5Z2VRRHZaNElZQ0ZYbVht?=
 =?utf-8?B?RjNaNWtJNWxWaWZqNlFpTVNkbkZ6UW8zNjMrbG93VDBVK2pNNHo4VnVxcTh4?=
 =?utf-8?B?NTJ2M0VCQWUvQXQ5TzFyODVJazZwSTBodDFkcjRTTXdLb1E3c1RrU2JmWTNU?=
 =?utf-8?B?cnFVUFl6QjIwSnJpa2oxR3FyVjYvNDhWL1FodExQQVFaOUlvY1lTZjRKSFRs?=
 =?utf-8?B?MVNobXpHWGNVdmVIOU9vdDVIeVM2NUNyeEpFbzltb2ZHSVcyRDlpTG93UDl2?=
 =?utf-8?B?MGxPSlJVdmRtY01PZ1FNNTAzMjBHanJ4OTQxeXBTMFRiZGs3UUpRYS9leW1z?=
 =?utf-8?B?TjJVTE9tS3pHelZRL3dEdlNRaUJHM054RnNBaUlEbmc5UldHMmNHbXl4RW1h?=
 =?utf-8?B?V3c0L3JGZjhSYXREbzQ2RTFRRVduZFhxNU53UHFmdWJVdERRc1ExdzZsZWds?=
 =?utf-8?B?TGlGNzBqeSs3Wld0YmRLV29XRjRoRDBSU3h0RDN3ZnFoWXpPdUVyVUZoWlRs?=
 =?utf-8?B?S1B1aVFVZXd6c2xvYlpldlZVUC9mZTFkYVdlbEo0cjkyRk9kZkVUdEp0aldV?=
 =?utf-8?B?Tmc0YmpHRDlQbnl6SzFrSXM1ZnJvU1gzUFVDYWllUkpZNi9ROVMrSFBodXl5?=
 =?utf-8?B?dXdkOFMraDdaNGErNFhMN0VSMWNDbEpKN0ZiVGg2QzgrcXh4Q1g0T2VYVUh0?=
 =?utf-8?B?WExXci8zZVVjdGhrQUxpTzhodmd5WlhTYUpURHhJVjR1VUR3eUNMZUMzbDht?=
 =?utf-8?B?ZlVwSEdaKzB5OVpjM1gvQ3E3QmkzTmNCTWpDV0R0cTlDRzUvdHZWMlhRM0dF?=
 =?utf-8?B?bkduYVJMN1lLV1JzQVBRR09IaUhyTkpYQWdpTklyeXdkaDI2ZUhENmZwZExq?=
 =?utf-8?B?UXFjSVM5czEyZzBtT1dJSUVZMkUzcHZwaUZiQ21jS0s4Z3FtdEg5RldDRGpK?=
 =?utf-8?B?bUdHSGtvYmRSWUpmcHNheWEzNkpEZ1lBd1BDVDk3RHZ6ZVBTZ2Q5MEl4OGRK?=
 =?utf-8?B?U0dDTEczcVo3RktHRWNReDRoYlpUMysyaHlITXpBMGNOby9NNmprOG4rZ0ht?=
 =?utf-8?B?elprZVNMazNqRng4eUtKTWJENmhxU0JrdG5TcFZ2UDlkNWdzdFRvVmcyZmZs?=
 =?utf-8?B?eDAvNDY4U1pTOEZDd2cwTzhnZTRVbWFGT20wNTRpWlpaZE5hVXdxZGtoaDFx?=
 =?utf-8?B?dHkwbktsZGhqcHFUNUg2R3hTeW5rTjZoWmNVOWdsOEcxRnFEMm9OcGFEYUFD?=
 =?utf-8?B?eWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a391ef12-3194-4f06-22ac-08db6173fcfe
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 01:11:40.0365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aCbgi8/5Yg1F5SMdrHXvgVqdLy+0g110aZHgN828akTzKAqyhkXFzkQeFHxarbatlWfszmy0fwgRefi1IV1CAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7825
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/30/2023 8:08 PM, Chao Gao wrote:
>>>> --- a/arch/x86/kvm/x86.c
>>>> +++ b/arch/x86/kvm/x86.c
>>>> @@ -3776,8 +3776,10 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>>>> 		 */
>>>> 		if (data & ~kvm_caps.supported_xss)
>>> Shouldn't we check against the supported value of _this_ guest? similar to
>>> guest_supported_xcr0.
>> I don't think it requires an extra variable to serve per guest purpose.
>>
>> For guest XSS settings, now we don't add extra constraints like XCR0, thus
> QEMU can impose constraints by configuring guest CPUID.0xd.1 to indicate
> certain supervisor state components cannot be managed by XSAVES, even
> though KVM supports them. IOW, guests may differ in the supported values
> for the IA32_XSS MSR.

OK, will change this part to align with xcr0 settings. Thanks!