Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1685438374-33287-1-git-send-email-renyu.zj@linux.alibaba.com> <1685438374-33287-8-git-send-email-renyu.zj@linux.alibaba.com>
In-Reply-To: <1685438374-33287-8-git-send-email-renyu.zj@linux.alibaba.com>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 30 May 2023 18:19:39 -0700
Message-ID: <CAP-5=fWadoqvUfEYKNEvfQ-5q4cdm8j0fXh7TJgPnA9u3Rz+-g@mail.gmail.com>
Subject: Re: [PATCH v3 7/7] docs: perf: Update metric usage for Alibaba's
 T-Head PMU driver
To:     Jing Zhang <renyu.zj@linux.alibaba.com>
Cc:     John Garry <john.g.garry@oracle.com>,
        Will Deacon <will@kernel.org>,
        Shuai Xue <xueshuai@linux.alibaba.com>,
        Robin Murphy <robin.murphy@arm.com>,
        James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org,
        Zhuo Song <zhuo.song@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, May 30, 2023 at 2:19=E2=80=AFAM Jing Zhang <renyu.zj@linux.alibaba.=
com> wrote:
>
> Alibaba's T-Head ali_drw PMU supports DDR bandwidth metrics. Update
> its usage in the documentation.
>
> Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  Documentation/admin-guide/perf/alibaba_pmu.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/admin-guide/perf/alibaba_pmu.rst b/Documentati=
on/admin-guide/perf/alibaba_pmu.rst
> index 11de998..7d84002 100644
> --- a/Documentation/admin-guide/perf/alibaba_pmu.rst
> +++ b/Documentation/admin-guide/perf/alibaba_pmu.rst
> @@ -88,6 +88,11 @@ data bandwidth::
>      -e ali_drw_27080/hif_rmw/ \
>      -e ali_drw_27080/cycle/ -- sleep 10
>
> +Example usage of counting all memory read/write bandwidth by metric::
> +
> +  perf stat -M ddr_read_bandwidth.all -- sleep 10
> +  perf stat -M ddr_write_bandwidth.all -- sleep 10
> +
>  The average DRAM bandwidth can be calculated as follows:
>
>  - Read Bandwidth =3D  perf_hif_rd * DDRC_WIDTH * DDRC_Freq / DDRC_Cycle
> --
> 1.8.3.1
>