Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp246828rwd; Tue, 30 May 2023 19:49:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ew9u6bocDxzjYyAHUiZ3JaaOL3LvPZqONwaRDsADtpq92WfVZHtWJVuQCDAKOS8w3RXJe X-Received: by 2002:a17:90a:d3cd:b0:255:4b79:1ef9 with SMTP id d13-20020a17090ad3cd00b002554b791ef9mr4521307pjw.16.1685501371908; Tue, 30 May 2023 19:49:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685501371; cv=none; d=google.com; s=arc-20160816; b=VOD784wE21D1wU/oJHTMq97cONBlXhxnkVmhbLQLS4vDxAR0yHn0m5k0r8Qqo7fMmV R2yDgrIai7mSF7BLeJe2xd3CWU6d1JAzTu9EMHDfbZn02wjbdNti1Fe8LrQ4GUQrIngb favwYXv8XRs5jGAYRbApPp2lDMP2F48BJXugcJvRBI+eHXvN/Rwu1TRBia3e7uHeHszX tl2ZKDuSa1IM/Atp7sKJNNMXrn7tNNm+ujAIYV9Br1AUXRtcB+qOJ8/WGQueWcUefi73 KDTJxKrUNFWh7WpG6AfD4fMow1TrJnQUbHUrnmftJE5CkoVq+Bq06TKycxMRKCVkmUzI 1QVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FmJ3DHTBl64LXVdAW7z0puqWani4RV9QXeKPYa0qoPs=; b=s7BF6waGGq+0ngdlDvZxC6wPIGhaxsZ4FS34PGQBDiXrnfE5lcMSIMun4+ViDhvqnW fpQ7fRnlRxQB140dBznbNqPtm7ywBv9cr31dDCyeKliZdFhNiC31nKlOu+zaRkpRuvde /OGVPDwcy88UyQQ44QwH9wxefS0zmkj8lVZWXVn5mO84C5NisnmV9YekkL/WL/9a8jBL 2ZtF6RKJUAZ3cdnLEY7xSOuRt1A952eLiMeBKpu4wmi4LYvX0kPSiZdbWktAyC1hX3yI D7SEWqSrA0kvb/s1TTzRlsIVrtlZqam6XcGgvUHbtoJ3VDVd8RclsSbCx0m8I9nNo1Mr 6nLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e3-20020a17090a818300b00256c97defa9si176336pjn.54.2023.05.30.19.49.15; Tue, 30 May 2023 19:49:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231968AbjEaCRX (ORCPT + 99 others); Tue, 30 May 2023 22:17:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230494AbjEaCRV (ORCPT ); Tue, 30 May 2023 22:17:21 -0400 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44E70EC for ; Tue, 30 May 2023 19:17:19 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VjvXEdn_1685499435; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VjvXEdn_1685499435) by smtp.aliyun-inc.com; Wed, 31 May 2023 10:17:16 +0800 From: Yang Li To: airlied@gmail.com Cc: daniel@ffwll.ch, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] drm/i915: remove unreachable code Date: Wed, 31 May 2023 10:17:14 +0800 Message-Id: <20230531021714.125078-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code after the return will not be executed, so remove them. Eliminate the following warning: drivers/gpu/drm/i915/display/intel_color.c:1808 intel_color_prepare_commit() warn: ignoring unreachable code. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5342 Signed-off-by: Yang Li --- drivers/gpu/drm/i915/display/intel_color.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c index 8966e6560516..0bfebac1e3e2 100644 --- a/drivers/gpu/drm/i915/display/intel_color.c +++ b/drivers/gpu/drm/i915/display/intel_color.c @@ -1804,11 +1804,6 @@ void intel_color_prepare_commit(struct intel_crtc_state *crtc_state) /* FIXME DSB has issues loading LUTs, disable it for now */ return; - - if (!crtc_state->pre_csc_lut && !crtc_state->post_csc_lut) - return; - - crtc_state->dsb = intel_dsb_prepare(crtc, 1024); } void intel_color_cleanup_commit(struct intel_crtc_state *crtc_state) -- 2.20.1.7.g153144c