Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230529074227.636933-1-jiawenwu@trustnetic.com>
In-Reply-To: <20230529074227.636933-1-jiawenwu@trustnetic.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 31 May 2023 06:27:21 +0300
Message-ID: <CAHp75VcKn7KtX4VnfPD1Q8L6n4Bb0oA_rG9Z=0dtjpZgUswunQ@mail.gmail.com>
Subject: Re: [PATCH] gpiolib: Fix GPIO chip IRQ initialization restriction
To:     Jiawen Wu <jiawenwu@trustnetic.com>
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl,
        shreeya.patel@collabora.com, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 29, 2023 at 10:44=E2=80=AFAM Jiawen Wu <jiawenwu@trustnetic.com=
> wrote:
>
> In case of gpio-regmap, IRQ chip is added by regmap-irq and associated wi=
th
> GPIO chip by gpiochip_irqchip_add_domain(). The initialization flag was n=
ot
> added in gpiochip_irqchip_add_domain(), causing gpiochip_to_irq() to retu=
rn
> -EPROBE_DEFER.

Makes sense to me.

> Fixes: 5467801f1fcb ("gpio: Restrict usage of GPIO chip irq members befor=
e initialization")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

> Cc: shreeya.patel@collabora.com

This can be replaced with the --cc option.

...

>         gc->to_irq =3D gpiochip_to_irq;
>         gc->irq.domain =3D domain;

I'm wondering if you need the same (compiler) barrier here as in the
other place.

> +       gc->irq.initialized =3D true;

--
With Best Regards,
Andy Shevchenko