Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230529152645.32680-1-lhenriques@suse.de>
In-Reply-To: <20230529152645.32680-1-lhenriques@suse.de>
From:   Mark Fasheh <mark@fasheh.com>
Date:   Tue, 30 May 2023 20:32:20 -0700
Message-ID: <CAGe7X7kxfrTvg0s3JGasnhFOLFS9FR7uTjwp+YGG7hTNi2UULw@mail.gmail.com>
Subject: Re: [PATCH] ocfs2: check new file size on fallocate call
To:     =?UTF-8?Q?Lu=C3=ADs_Henriques?= <lhenriques@suse.de>
Cc:     Joel Becker <jlbec@evilplan.org>,
        Joseph Qi <joseph.qi@linux.alibaba.com>,
        Heming Zhao <heming.zhao@suse.com>, ocfs2-devel@oss.oracle.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, May 29, 2023 at 8:26=E2=80=AFAM Lu=C3=ADs Henriques <lhenriques@sus=
e.de> wrote:
>
> When changing a file size with fallocate() the new size isn't being
> checked.  In particular, the FSIZE ulimit isn't being checked, which make=
s
> fstest generic/228 fail.  Simply adding a call to inode_newsize_ok() fixe=
s
> this issue.
>
> Signed-off-by: Lu=C3=ADs Henriques <lhenriques@suse.de>

Looks good, thanks Luis.

Reviewed-by: Mark Fasheh <mark@fasheh.com>