Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 May 2023 21:41:25 -0700
From:   Kees Cook <kees@kernel.org>
To:     kernel test robot <lkp@intel.com>,
        Azeem Shaikh <azeemshaikh38@gmail.com>,
        Maxim Krasnyansky <maxk@qti.qualcomm.com>
CC:     oe-kbuild-all@lists.linux.dev, linux-hardening@vger.kernel.org,
        linux-kernel@vger.kernel.org, Richard Weinberger <richard@nod.at>,
        Anton Ivanov <anton.ivanov@cambridgegreys.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-um@lists.infradead.org
Subject: Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy
User-Agent: K-9 Mail for Android
In-Reply-To: <202305311135.zGMT1gYR-lkp@intel.com>
References: <20230530164004.986750-1-azeemshaikh38@gmail.com> <202305311135.zGMT1gYR-lkp@intel.com>
Message-ID: <09A0C6FA-669F-4B73-9620-43AEA17E5D0C@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On May 30, 2023 8:18:42 PM PDT, kernel test robot <lkp@intel=2Ecom> wrote:
>Hi Azeem,
>
>kernel test robot noticed the following build errors:
>
>[auto build test ERROR on uml/next]
>[also build test ERROR on uml/fixes wireless-next/main wireless/main linu=
s/master v6=2E4-rc4 next-20230530]
>[If your patch is applied to the wrong git tree, kindly drop us a note=2E
>And when submitting patch, we suggest to use '--base' as documented in
>https://git-scm=2Ecom/docs/git-format-patch#_base_tree_information]
>
>url:    https://github=2Ecom/intel-lab-lkp/linux/commits/Azeem-Shaikh/uml=
-Replace-all-non-returning-strlcpy-with-strscpy/20230531-004115
>base:   git://git=2Ekernel=2Eorg/pub/scm/linux/kernel/git/uml/linux next
>patch link:    https://lore=2Ekernel=2Eorg/r/20230530164004=2E986750-1-az=
eemshaikh38%40gmail=2Ecom
>patch subject: [PATCH] uml: Replace all non-returning strlcpy with strscp=
y
>config: um-i386_defconfig (https://download=2E01=2Eorg/0day-ci/archive/20=
230531/202305311135=2EzGMT1gYR-lkp@intel=2Ecom/config)
>compiler: gcc-12 (Debian 12=2E2=2E0-14) 12=2E2=2E0
>reproduce (this is a W=3D1 build):
>        # https://github=2Ecom/intel-lab-lkp/linux/commit/c51d7beb37cfbda=
321feb3811bbe0e381f804899
>        git remote add linux-review https://github=2Ecom/intel-lab-lkp/li=
nux
>        git fetch --no-tags linux-review Azeem-Shaikh/uml-Replace-all-non=
-returning-strlcpy-with-strscpy/20230531-004115
>        git checkout c51d7beb37cfbda321feb3811bbe0e381f804899
>        # save the config file
>        mkdir build_dir && cp config build_dir/=2Econfig
>        make W=3D1 O=3Dbuild_dir ARCH=3Dum SUBARCH=3Di386 olddefconfig
>        make W=3D1 O=3Dbuild_dir ARCH=3Dum SUBARCH=3Di386 SHELL=3D/bin/ba=
sh
>
>If you fix the issue, kindly add following tag where applicable
>| Reported-by: kernel test robot <lkp@intel=2Ecom>
>| Closes: https://lore=2Ekernel=2Eorg/oe-kbuild-all/202305311135=2EzGMT1g=
YR-lkp@intel=2Ecom/
>
>All errors (new ones prefixed by >>):
>
>   arch/um/os-Linux/drivers/tuntap_user=2Ec: In function 'tuntap_open':
>>> arch/um/os-Linux/drivers/tuntap_user=2Ec:149:17: error: implicit decla=
ration of function 'strscpy'; did you mean 'strncpy'? [-Werror=3Dimplicit-f=
unction-declaration]
>     149 |                 strscpy(ifr=2Eifr_name, pri->dev_name, sizeof(=
ifr=2Eifr_name));
>         |                 ^~~~~~~
>         |                 strncpy
>   cc1: some warnings being treated as errors

Ah, yeah, this is another "not actually in the kernel" cases=2E Let's igno=
re this strlcpy for now=2E

-Keed


--=20
Kees Cook