Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp396266rwd; Tue, 30 May 2023 23:06:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7+rNQ2Xu6uxP8AiZaVxoRnrZ1YLkULqCRLufLIADb7nZXXlffRladeOrVjHBq3j54Ebg+V X-Received: by 2002:a05:6358:89c:b0:122:2c33:9f40 with SMTP id m28-20020a056358089c00b001222c339f40mr1217050rwj.13.1685513162210; Tue, 30 May 2023 23:06:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685513162; cv=none; d=google.com; s=arc-20160816; b=pYcIZMM9Tiaq9myYOgisnOyKgUwMDp3SAMSZf8Qh1IFi7KA0JrGF2qZbH+q1lIVdVr Vuw2L3Zn6XexvXS+guQNYJcAH1TUOeXWmyuu8wys9LwOY+IDgB8VplJNETZsyyAasIRR ZtOMWck+B2/vXogLzGfzhS2oX5afQzicopPA945mAZAWjmwoXUtS1n3vRsIKUQgZ0RbP LJq+hsUiGtHT9NIYnv6U8oCsp1NWtqlMsLSn8BYGbuW059LJ53rqZbgcNSeCC1ypxxTP 6JiA2gBzXI4hM/kHuMOl44kWrPDBBmdcgR1sOmqHXeIgVt3hixt9/oY5mMVPJ5gvaNtL /XSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zXFbghN5Oa6JE4b5vk2VR/hhTLQNTSqD9OkNgOn3LKA=; b=J/c2tqz+pxnDXpzaCTSkTJA6CdEUDKtEOM4ZyvcxNi3stLda7g30ZS0uj8r7OwwJl3 LIiAhh1txZeiZLlNchza9Ax/n4D87qOBKDC9XSRV4cZR7hqWlDu7NFUJ/zNGivu/1qNw zjER7srWAs+wDUBfyYt6g6W+Z3Tiw6+FryYoJzBUiLa+S50qcBml+8yV/eErkzDVHsTI rqv2eI9We+qU54cduS9tnHkCzWLJ7kQIBu5ajfj6rD0XiFqot2r20Bb+Wu93z2fDqbNs fcoHD6WH+Fd04fUa3cq01fJw7mnFoIah3mZHOMrJIKiwSiFukB1mTiBJZfFUaTfyYytT Z1VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=TuRIxgkO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b5-20020aa78ec5000000b0063b8935bcbasi2946000pfr.310.2023.05.30.23.05.50; Tue, 30 May 2023 23:06:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=TuRIxgkO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234285AbjEaGBJ (ORCPT + 99 others); Wed, 31 May 2023 02:01:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjEaGBH (ORCPT ); Wed, 31 May 2023 02:01:07 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E238D11C for ; Tue, 30 May 2023 23:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zXFbghN5Oa6JE4b5vk2VR/hhTLQNTSqD9OkNgOn3LKA=; b=TuRIxgkOysvpuskkTTblNke1x2 8kQW9AYsK0NPuQbEbOOlw6j28RDvPbSLKVv6fgtoIhZqiYkI2Sp7+Y8ftXPOgADBxvXRhKzk80M/n VLtY7uzaFNz4w+PVyQWNb21eB2qoKbU5/cWNoGRJeIaJDyNz2OpV1e3GD8pvAvWcvaoBQ1kMS/y6P pnasDNYMf4NBE9pgIeHwNMz0kLd5hnRbG0x5EY8Jcaj1kZbCZPHiMNZL1dGstf8juU42KYY6ptoew qM1JwRApgGprj1omrt876fMzRLZ9zEzOoVdY5W7mIOrSNAyn2PSDC7wZ3EEUb9GTKaKnJQcW05UfL WVjPlK1g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q4EtA-00GEeU-2m; Wed, 31 May 2023 06:00:52 +0000 Date: Tue, 30 May 2023 23:00:52 -0700 From: Christoph Hellwig To: Johannes Weiner Cc: Yosry Ahmed , Konrad Rzeszutek Wilk , Andrew Morton , Seth Jennings , Dan Streetman , Vitaly Wool , Nhat Pham , Domenico Cerasuolo , Yu Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: zswap: support exclusive loads Message-ID: References: <20230530210251.493194-1-yosryahmed@google.com> <20230530235447.GB102494@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230530235447.GB102494@cmpxchg.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2023 at 07:54:47PM -0400, Johannes Weiner wrote: > Somewhat tangential, but is there still a point to the frontswap > layer? It seems usecases other than zswap have never materialized, at > least not in tree. Life would be a lot easier if we were to just > hardcode the zswap callbacks in the swap functions. I've been wanting to remove it for a while, as it really is rather pointless.